Skip to content

OpenRAG is a comprehensive, single package Retrieval-Augmented Generation platform built on Langflow, Docling, and Opensearch.

Python

Fix search bar clear/submit buttons requiring two clicks (#2357)

Nathan Bakaree9106b9ff3a3
diff --git a/frontend/components/knowledge-search-bar.tsx b/frontend/components/knowledge-search-bar.tsx
index dd3c68095..bb74acc39 100644
--- a/frontend/components/knowledge-search-bar.tsx
+++ b/frontend/components/knowledge-search-bar.tsx
@@ -1,4 +1,4 @@
-import { ArrowRight, RefreshCw, Search, X } from "lucide-react";
+import { ArrowRight, Download, RefreshCw, Search, X } from "lucide-react";
import { type ChangeEvent, type FormEvent, useCallback, useState } from "react";
import { toast } from "sonner";
import { useRefreshOpenragDocs } from "@/app/api/mutations/useRefreshOpenragDocs";
@@ -133,9 +133,9 @@ export const KnowledgeSearchBar = () => {
onChange={(e: ChangeEvent<HTMLInputElement>) =>
setSearchQueryInput(e.target.value)
}
- className="h-full w-full bg-transparent text-sm text-[hsl(var(--placeholder))] placeholder:text-[hsl(var(--placeholder))] focus:outline-none focus:ring-0"
+ className="h-full w-full bg-transparent text-sm text-foreground placeholder:text-[hsl(var(--placeholder))] focus:outline-none focus:ring-0"
/>
- {queryOverride && (
+ {searchQueryInput && (
<button
type="button"
aria-label="Clear search"
@@ -147,7 +147,10 @@ export const KnowledgeSearchBar = () => {
)}
<Button
variant="ghost"
- className="h-auto rounded-none hover:bg-accent hover:text-foreground p-2 hidden group-focus-within/input:block"
+ className={cn(
+ "h-auto rounded-none hover:bg-accent hover:text-foreground p-2 hidden group-focus-within/input:block",
+ searchQueryInput && "block",
+ )}
type="submit"
>
<ArrowRight className="h-4 w-4 text-[var(--icon-primary)]" />
@@ -172,7 +175,12 @@ export const KnowledgeSearchBar = () => {
type="button"
variant="ghost"
disabled={refreshOpenragDocsMutation.isPending}
- className="h-auto flex-shrink-0 rounded-none px-3 text-sm hover:bg-accent hover:text-foreground"
+ aria-label={
+ refreshOpenragDocsMutation.isPending
+ ? "Refreshing docs..."
+ : "Fetch latest docs"
+ }
+ className="h-auto flex-shrink-0 rounded-none px-3 text-sm hover:bg-accent hover:text-foreground gap-2"
onClick={async () => {
try {
toast.info("Refreshing OpenRAG docs...");
@@ -187,9 +195,12 @@ export const KnowledgeSearchBar = () => {
}
}}
>
- {refreshOpenragDocsMutation.isPending
- ? "Refreshing docs..."
- : "Fetch latest docs"}
+ <Download className="h-4 w-4 flex-shrink-0" />
+ <span className="hidden lg:inline">
+ {refreshOpenragDocsMutation.isPending
+ ? "Refreshing docs..."
+ : "Fetch latest docs"}
+ </span>
</Button>
</RequirePermission>
<div className="ml-auto">