Skip to content

OpenRAG is a comprehensive, single package Retrieval-Augmented Generation platform built on Langflow, Docling, and Opensearch.

Python

fix: Update EnvManager to use class-level regex for environment variable assignment

Rico Furtadof29e35d13b89
diff --git a/src/tui/managers/env_manager.py b/src/tui/managers/env_manager.py
index 3d707103e..ad467d6bd 100644
--- a/src/tui/managers/env_manager.py
+++ b/src/tui/managers/env_manager.py
@@ -120,6 +120,7 @@ class EnvManager:
logger.warning(f"Failed to migrate .env file: {e}")
self.config = EnvConfig()
+ self.assignment_pattern = re.compile(r"^\s*(?:export\s+)?([A-Za-z_][A-Za-z0-9_]*)\s*=")
def generate_secure_password(self) -> str:
"""Generate a secure password for OpenSearch."""
@@ -209,7 +210,6 @@ class EnvManager:
return []
managed_vars = set(self._env_attr_map().keys())
- assignment_pattern = re.compile(r"^\s*(?:export\s+)?([A-Za-z_][A-Za-z0-9_]*)\s*=")
preserved_lines: list[str] = []
try:
@@ -218,7 +218,7 @@ class EnvManager:
if not stripped or stripped.startswith("#"):
continue
- match = assignment_pattern.match(raw_line)
+ match = self.assignment_pattern.match(raw_line)
if not match:
continue
@@ -227,7 +227,10 @@ class EnvManager:
continue
preserved_lines.append(raw_line)
except Exception:
- logger.warning(f"Failed to preserve custom .env lines from {self.env_file}")
+ logger.warning(
+ f"Failed to preserve custom .env lines from {self.env_file}",
+ exc_info=True,
+ )
return preserved_lines
diff --git a/tests/unit/test_env_manager.py b/tests/unit/test_env_manager.py
index 267fb3e93..d81d80daf 100644
--- a/tests/unit/test_env_manager.py
+++ b/tests/unit/test_env_manager.py
@@ -105,6 +105,7 @@ class TestSaveEnvFilePermissions:
assert "OPENRAG_BACKEND_HOST='my-host'" in content
assert content.count("OPENRAG_BACKEND_HOST=") == 1
assert "OPENSEARCH_PASSWORD='NewSecurePass!123'" in content
+ assert "OPENSEARCH_PASSWORD='old-password'" not in content
# ---------------------------------------------------------------------------