Skip to content

Record your screen, ship a demo. Free and open-source, GPU-accelerated, no watermarks, no subscriptions. Windows, macOS, Linux. Actively maintained.

feat(export): one settings panel in the export dialog

EtienneLescot3a34628c2672
diff --git a/src/components/ai-edition/ExportDialog.cancel.test.tsx b/src/components/ai-edition/ExportDialog.cancel.test.tsx
index fe52beb90..8d2403b9c 100644
--- a/src/components/ai-edition/ExportDialog.cancel.test.tsx
+++ b/src/components/ai-edition/ExportDialog.cancel.test.tsx
@@ -98,7 +98,7 @@ async function start() {
<ExportDialog open onClose={onClose} document={DOC} />
</I18nProvider>,
);
- fireEvent.click(screen.getByRole("button", { name: /README GIF/ }));
+ fireEvent.click(screen.getByRole("button", { name: "GIF" }));
fireEvent.click(screen.getByRole("button", { name: "Export GIF" }));
await waitFor(() => expect(exportGifNative).toHaveBeenCalledOnce());
const id = vi.mocked(exportGifNative).mock.calls[0][4];
@@ -240,7 +240,7 @@ describe("GIF export cancellation", () => {
<ExportDialog open onClose={onClose} document={DOC} />
</I18nProvider>,
);
- fireEvent.click(screen.getByRole("button", { name: /README GIF/ }));
+ fireEvent.click(screen.getByRole("button", { name: "GIF" }));
fireEvent.click(screen.getByRole("button", { name: "Export GIF" }));
view.unmount();
await act(async () => choose({ success: true, path: "/tmp/late.gif" }));
diff --git a/src/components/ai-edition/ExportDialog.params.test.tsx b/src/components/ai-edition/ExportDialog.params.test.tsx
index 14760de02..d13326d69 100644
--- a/src/components/ai-edition/ExportDialog.params.test.tsx
+++ b/src/components/ai-edition/ExportDialog.params.test.tsx
@@ -137,7 +137,6 @@ describe("ExportDialog MP4 params", () => {
const at60 = await exportMp4();
expect(at60).toMatchObject({ width: 1920, height: 1080, fps: 60, bitrate: expected(60) });
- fireEvent.click(screen.getByRole("button", { name: "Advanced" }));
fireEvent.click(screen.getByRole("button", { name: "30" }));
const at30 = await exportMp4();
expect(at30).toMatchObject({ fps: 30, bitrate: expected(30) });
@@ -145,7 +144,7 @@ describe("ExportDialog MP4 params", () => {
});
});
-describe("ExportDialog destinations", () => {
+describe("ExportDialog format settings", () => {
beforeEach(() => {
window.electronAPI = {
pickExportSavePath: vi.fn(async () => ({ path: "/tmp/out.mp4" })),
@@ -158,47 +157,25 @@ describe("ExportDialog destinations", () => {
vi.clearAllMocks();
});
- const destination = (name: RegExp) => screen.getByRole("button", { name });
-
- it("opens on Web / YouTube, with the detailed settings folded under Advanced", () => {
+ it("opens on MP4, 1080p, 60 fps, H.264", async () => {
renderDialog();
- expect(destination(/Web \/ YouTube/)).toHaveAttribute("aria-pressed", "true");
- expect(destination(/Web \/ YouTube/)).toHaveTextContent("MP4 · 1920 × 1080 · 60 fps");
- expect(screen.getByRole("button", { name: "Advanced" })).toHaveAttribute(
- "aria-expanded",
- "false",
- );
- expect(screen.queryByRole("button", { name: "H.265" })).toBeNull();
+ expect(await exportMp4()).toMatchObject({ width: 1920, height: 1080, fps: 60, codec: "h264" });
});
- it("Social exports the same frame at half the frame rate, so half the bitrate", async () => {
+ it("half the frame rate is half the bitrate, same frame", async () => {
renderDialog();
const web = await exportMp4();
- fireEvent.click(destination(/Social/));
+ fireEvent.click(screen.getByRole("button", { name: "30" }));
const social = await exportMp4();
- // Same size: a destination never touches the project's format.
expect(social).toMatchObject({ width: web?.width, height: web?.height, fps: 30 });
expect(social?.bitrate).toBe((web?.bitrate ?? 0) / 2);
});
- it("stops showing a destination as picked once an Advanced setting leaves it", () => {
- renderDialog();
- fireEvent.click(destination(/Social/));
- expect(destination(/Social/)).toHaveAttribute("aria-pressed", "true");
- fireEvent.click(screen.getByRole("button", { name: "Advanced" }));
- fireEvent.click(screen.getByRole("button", { name: "H.265" }));
- for (const d of [/Web \/ YouTube/, /Social/, /Studio/, /README GIF/]) {
- expect(destination(d)).toHaveAttribute("aria-pressed", "false");
- }
- });
-
- it("README GIF asks for a README-sized GIF", async () => {
+ it("a GIF is 15 fps and README-sized at the small preset", async () => {
renderDialog();
- fireEvent.click(destination(/README GIF/));
- expect(destination(/README GIF/)).toHaveTextContent("GIF · 852 × 480 · 15 fps");
- fireEvent.click(screen.getByRole("button", { name: /export gif/i }));
- await waitFor(() => expect(exportGifNative).toHaveBeenCalled());
- expect(vi.mocked(exportGifNative).mock.calls[0][3]).toMatchObject({
+ fireEvent.click(screen.getByRole("button", { name: "GIF" }));
+ fireEvent.click(screen.getByRole("button", { name: "Small (480p)" }));
+ expect(await exportGif()).toMatchObject({
width: 852,
height: 480,
fps: 15,
@@ -206,24 +183,23 @@ describe("ExportDialog destinations", () => {
});
});
- it("sizes README GIF from the source, whatever MP4 tier was picked before", async () => {
- // The report on #814: a 640x360 clip got an 852x480 GIF straight away, sized from the hidden
- // 1080p tier the dialog opens on, and a 640x360 one after Studio, whose tier is "Source".
+ it("sizes a GIF from the source, whatever MP4 tier was picked before", async () => {
+ // The report on #814: a 640x360 clip got an 852x480 GIF straight away, sized from the
+ // 1080p tier the dialog opens on. It must always come off the source size.
renderDialog(SMALL_SOURCE_DOC);
- fireEvent.click(destination(/README GIF/));
- expect(destination(/README GIF/)).toHaveTextContent("GIF · 640 × 360 · 15 fps");
+ fireEvent.click(screen.getByRole("button", { name: "GIF" }));
+ fireEvent.click(screen.getByRole("button", { name: "Small (480p)" }));
const direct = await exportGif();
expect(direct).toMatchObject({ width: 640, height: 360 });
- fireEvent.click(destination(/Studio/));
- fireEvent.click(destination(/README GIF/));
- expect(destination(/README GIF/)).toHaveTextContent("GIF · 640 × 360 · 15 fps");
+ fireEvent.click(screen.getByRole("button", { name: "MP4" }));
+ fireEvent.click(screen.getByRole("button", { name: /^Source/ }));
+ fireEvent.click(screen.getByRole("button", { name: "GIF" }));
expect(await exportGif()).toEqual(direct);
});
it("never exports a GIF bigger than its source, whatever the tier and size preset", async () => {
renderDialog(SMALL_SOURCE_DOC);
- fireEvent.click(screen.getByRole("button", { name: "Advanced" }));
for (const tier of [/^720p/, /^1080p/, /^Source/]) {
fireEvent.click(screen.getByRole("button", { name: "MP4" }));
fireEvent.click(screen.getByRole("button", { name: tier }));
diff --git a/src/components/ai-edition/ExportDialog.tsx b/src/components/ai-edition/ExportDialog.tsx
index a17f427a0..08ff97a86 100644
--- a/src/components/ai-edition/ExportDialog.tsx
+++ b/src/components/ai-edition/ExportDialog.tsx
@@ -6,7 +6,7 @@
// Format/quality/GIF options live in the dialog's local state. The
// dialog uses the new shell's modal style.
-import { ChevronDown, Download, FileVideo, FolderOpen, Loader2, Star } from "lucide-react";
+import { Download, FileVideo, FolderOpen, Loader2, Star } from "lucide-react";
import { useEffect, useMemo, useRef, useState } from "react";
import { toast } from "sonner";
import { useScopedT } from "@/contexts/I18nContext";
@@ -146,40 +146,6 @@ const QUALITY_OPTIONS: Array<{
{ value: "source", labelKey: "exportQuality.high" },
];
-interface ExportChoice {
- format: ExportFormat;
- quality: ExportQuality;
- fps: 24 | 30 | 60;
- codec: ExportVideoCodec;
- gifFrameRate: GifFrameRate;
- gifSize: GifSizePreset;
- gifLoop: boolean;
-}
-
-/** Named sets of the Advanced settings, nothing more: a destination sets controls the user can
- * see and change there, and never the aspect ratio, which belongs to the project. It shows as
- * picked while the settings still match it. */
-const DESTINATIONS: Array<{ labelKey: string; set: Partial<ExportChoice> }> = [
- { labelKey: "destinationWeb", set: { format: "mp4", quality: "good", fps: 60, codec: "h264" } },
- // Half the frames at the same bits per frame: half the bitrate.
- {
- labelKey: "destinationSocial",
- set: { format: "mp4", quality: "good", fps: 30, codec: "h264" },
- },
- {
- labelKey: "destinationStudio",
- set: { format: "mp4", quality: "source", fps: 60, codec: "h264" },
- },
- {
- labelKey: "destinationReadmeGif",
- set: { format: "gif", gifFrameRate: 15, gifSize: "small", gifLoop: true },
- },
-];
-
-function matchesDestination(choice: ExportChoice, set: Partial<ExportChoice>) {
- return (Object.keys(set) as Array<keyof ExportChoice>).every((key) => choice[key] === set[key]);
-}
-
interface ExportDialogProps {
open: boolean;
onClose: () => void;
@@ -199,7 +165,6 @@ export function ExportDialog({ open, onClose, document }: ExportDialogProps) {
const [gifFrameRate, setGifFrameRate] = useState<GifFrameRate>(15);
const [gifSize, setGifSize] = useState<GifSizePreset>("medium");
const [gifLoop, setGifLoop] = useState(true);
- const [advancedOpen, setAdvancedOpen] = useState(false);
const [phase, setPhase] = useState<Phase>("idle");
const [progress, setProgress] = useState<ExportProgress | null>(null);
const [error, setError] = useState<string | null>(null);
@@ -294,7 +259,7 @@ export function ExportDialog({ open, onClose, document }: ExportDialogProps) {
// GIF is 8-bit indexed and grows fast with area, so the size preset caps the output
// height. It starts from the "Source" size, never from the quality tier: that control is
// MP4-only and hidden while GIF is picked, yet the tier an MP4 choice left behind used to
- // size the GIF (a 640x360 clip gave 852x480 after Web / YouTube, 640x360 after Studio).
+ // size the GIF (a 640x360 clip gave 852x480 after the 1080p tier, 640x360 after Source).
// So no preset upscales and `original` is the source size. The native side falls back
// to its own defaults when undefined.
const gifOutputDims = (preset: GifSizePreset): { width?: number; height?: number } => {
@@ -523,27 +488,6 @@ export function ExportDialog({ open, onClose, document }: ExportDialogProps) {
const isBusy = phase === "rendering" || phase === "writing" || phase === "configuring";
const pct = progress?.percentage ?? 0;
const gifSizeLabel = GIF_SIZE_PRESETS[gifSize].label;
- const choice: ExportChoice = { format, quality, fps, codec, gifFrameRate, gifSize, gifLoop };
- const applyDestination = (set: Partial<ExportChoice>) => {
- if (set.format) setFormat(set.format);
- if (set.quality) setQuality(set.quality);
- if (set.fps) setFps(set.fps);
- if (set.codec) setCodec(set.codec);
- if (set.gifFrameRate) setGifFrameRate(set.gifFrameRate);
- if (set.gifSize) setGifSize(set.gifSize);
- if (set.gifLoop !== undefined) setGifLoop(set.gifLoop);
- };
- /** What a destination produces, in the numbers the Advanced settings show. */
- const destinationSummary = (set: Partial<ExportChoice>) => {
- if (set.format === "gif") {
- const gif = gifOutputDims(set.gifSize ?? gifSize);
- const size = gif.width ? `${gif.width} × ${gif.height} · ` : "";
- return `GIF · ${size}${set.gifFrameRate ?? gifFrameRate} fps`;
- }
- const dims = tierOutputDims(set.quality ?? quality);
- const size = dims ? `${dims.width} × ${dims.height} · ` : "";
- return `MP4 · ${size}${set.fps ?? fps} fps`;
- };
return (
<ModalShell
@@ -553,251 +497,198 @@ export function ExportDialog({ open, onClose, document }: ExportDialogProps) {
subtitle={t("exportDialog.subtitle")}
>
<div style={{ display: "flex", flexDirection: "column", gap: 18 }}>
- <section>
- <div className={styles.groupLabel}>{t("exportDialog.destination")}</div>
- <div style={{ display: "grid", gridTemplateColumns: "1fr 1fr", gap: 8 }}>
- {DESTINATIONS.map((d) => (
- <button
- type="button"
- key={d.labelKey}
- disabled={isBusy}
- aria-pressed={matchesDestination(choice, d.set)}
- onClick={() => applyDestination(d.set)}
- style={{
- display: "flex",
- flexDirection: "column",
- alignItems: "flex-start",
- gap: 4,
- padding: "10px 12px",
- ...choiceStyle(matchesDestination(choice, d.set)),
- cursor: "pointer",
- font: "500 13px/1 var(--font-body)",
- }}
- >
- <span style={{ color: "var(--fg)", fontWeight: 600 }}>
- {t(`exportDialog.${d.labelKey}`)}
- </span>
- <span
+ <div
+ style={{
+ display: "grid",
+ gridTemplateColumns: "1fr 1fr",
+ gap: 8,
+ }}
+ >
+ <FormatToggle
+ active={format === "mp4"}
+ label={ts("exportFormat.mp4")}
+ icon={<FileVideo size={18} />}
+ onClick={() => setFormat("mp4")}
+ disabled={isBusy}
+ />
+ <FormatToggle
+ active={format === "gif"}
+ label={ts("exportFormat.gif")}
+ icon={<Download size={18} />}
+ onClick={() => setFormat("gif")}
+ disabled={isBusy}
+ />
+ </div>
+
+ {format === "mp4" ? (
+ <section>
+ <div className={styles.groupLabel}>{t("exportDialog.quality")}</div>
+ <div style={{ display: "grid", gridTemplateColumns: "repeat(3, 1fr)", gap: 8 }}>
+ {QUALITY_OPTIONS.map((q) => (
+ <button
+ type="button"
+ key={q.value}
+ disabled={isBusy}
+ onClick={() => setQuality(q.value)}
style={{
- font: "500 12px var(--font-body)",
- fontVariantNumeric: "tabular-nums",
- color: "var(--muted)",
+ display: "flex",
+ flexDirection: "column",
+ gap: 2,
+ padding: "10px 12px",
+ ...choiceStyle(quality === q.value),
+ color: "var(--fg-2)",
+ cursor: "pointer",
+ font: "500 13px/1 var(--font-body)",
}}
>
- {destinationSummary(d.set)}
- </span>
- </button>
- ))}
- </div>
- </section>
-
- <button
- type="button"
- className={styles.exportAdvanced}
- aria-expanded={advancedOpen}
- onClick={() => setAdvancedOpen((open) => !open)}
- >
- {t("exportDialog.advanced")}
- <ChevronDown size={14} />
- </button>
-
- {advancedOpen ? (
- <>
+ <span style={{ color: "var(--fg)", fontWeight: 600 }}>{ts(q.labelKey)}</span>
+ {(() => {
+ const dims = tierOutputDims(q.value);
+ if (!dims) return null;
+ // Downscale badge removed everywhere — restated what picking a lower
+ // tier already means, not actionable. The upscale badge asks whether
+ // the clip has to be STRETCHED to fill this frame (`wouldUpscale`),
+ // which is a contain-fit question: a short-side compare read the
+ // letterbox rows a non-16:9 source gets in a 16:9 project as if they
+ // were stretched pixels, and flagged "1080p" on the very frame
+ // "Source" produced unflagged. No "Source" special case any more —
+ // its frame is the source's long side at the project ratio, so its
+ // contain scale is never above 1 and the general test covers it.
+ const isUpscale = smallestSource !== null && wouldUpscale(dims, smallestSource);
+ return (
+ <span
+ style={{
+ font: "500 12px var(--font-body)",
+ fontVariantNumeric: "tabular-nums",
+ color: isUpscale ? "var(--warn)" : "var(--muted)",
+ }}
+ >
+ {dims.width} × {dims.height}
+ {isUpscale ? ` · ${t("exportDialog.qualityUpscaleWarning")}` : ""}
+ </span>
+ );
+ })()}
+ </button>
+ ))}
+ </div>
<div
style={{
display: "grid",
gridTemplateColumns: "1fr 1fr",
- gap: 8,
+ gap: 12,
+ marginTop: 12,
}}
>
- <FormatToggle
- active={format === "mp4"}
- label={ts("exportFormat.mp4")}
- icon={<FileVideo size={18} />}
- onClick={() => setFormat("mp4")}
- disabled={isBusy}
- />
- <FormatToggle
- active={format === "gif"}
- label={ts("exportFormat.gif")}
- icon={<Download size={18} />}
- onClick={() => setFormat("gif")}
- disabled={isBusy}
- />
- </div>
-
- {format === "mp4" ? (
- <section>
- <div className={styles.groupLabel}>{t("exportDialog.quality")}</div>
- <div style={{ display: "grid", gridTemplateColumns: "repeat(3, 1fr)", gap: 8 }}>
- {QUALITY_OPTIONS.map((q) => (
+ <div>
+ <div className={styles.groupLabel}>{t("exportDialog.frameRate")}</div>
+ <div style={{ display: "grid", gridTemplateColumns: "repeat(3, 1fr)", gap: 6 }}>
+ {([24, 30, 60] as const).map((r) => (
<button
type="button"
- key={q.value}
+ key={r}
disabled={isBusy}
- onClick={() => setQuality(q.value)}
- style={{
- display: "flex",
- flexDirection: "column",
- gap: 2,
- padding: "10px 12px",
- ...choiceStyle(quality === q.value),
- color: "var(--fg-2)",
- cursor: "pointer",
- font: "500 13px/1 var(--font-body)",
- }}
+ onClick={() => setFps(r)}
+ style={segStyle(fps === r)}
>
- <span style={{ color: "var(--fg)", fontWeight: 600 }}>{ts(q.labelKey)}</span>
- {(() => {
- const dims = tierOutputDims(q.value);
- if (!dims) return null;
- // Downscale badge removed everywhere — restated what picking a lower
- // tier already means, not actionable. The upscale badge asks whether
- // the clip has to be STRETCHED to fill this frame (`wouldUpscale`),
- // which is a contain-fit question: a short-side compare read the
- // letterbox rows a non-16:9 source gets in a 16:9 project as if they
- // were stretched pixels, and flagged "1080p" on the very frame
- // "Source" produced unflagged. No "Source" special case any more —
- // its frame is the source's long side at the project ratio, so its
- // contain scale is never above 1 and the general test covers it.
- const isUpscale =
- smallestSource !== null && wouldUpscale(dims, smallestSource);
- return (
- <span
- style={{
- font: "500 12px var(--font-body)",
- fontVariantNumeric: "tabular-nums",
- color: isUpscale ? "var(--warn)" : "var(--muted)",
- }}
- >
- {dims.width} × {dims.height}
- {isUpscale ? ` · ${t("exportDialog.qualityUpscaleWarning")}` : ""}
- </span>
- );
- })()}
+ {r}
</button>
))}
</div>
+ </div>
+ <div>
+ <div className={styles.groupLabel}>{t("exportDialog.codec")}</div>
<div
style={{
display: "grid",
- gridTemplateColumns: "1fr 1fr",
- gap: 12,
- marginTop: 12,
+ gridTemplateColumns: "repeat(2, 1fr)",
+ gap: 6,
}}
>
- <div>
- <div className={styles.groupLabel}>{t("exportDialog.frameRate")}</div>
- <div style={{ display: "grid", gridTemplateColumns: "repeat(3, 1fr)", gap: 6 }}>
- {([24, 30, 60] as const).map((r) => (
- <button
- type="button"
- key={r}
- disabled={isBusy}
- onClick={() => setFps(r)}
- style={segStyle(fps === r)}
- >
- {r}
- </button>
- ))}
- </div>
- </div>
- <div>
- <div className={styles.groupLabel}>{t("exportDialog.codec")}</div>
- <div
- style={{
- display: "grid",
- gridTemplateColumns: "repeat(2, 1fr)",
- gap: 6,
- }}
+ {(
+ [
+ ["h264", "H.264"],
+ ["h265", "H.265"],
+ // VP9 has no AMF hardware encoder on this GPU — the native pipeline
+ // (the only MP4 export path now) rejects it outright (tested: a
+ // software libvpx-vp9 fallback worked but was too slow to ship).
+ // Hidden here rather than left selectable-then-erroring.
+ ] as Array<[ExportVideoCodec, string]>
+ ).map(([value, label]) => (
+ <button
+ type="button"
+ key={value}
+ disabled={isBusy}
+ onClick={() => setCodec(value)}
+ style={segStyle(codec === value)}
+ title={
+ value === "h264"
+ ? t("exportDialog.codecBestCompatibility")
+ : t("exportDialog.codecMaySupportVary")
+ }
>
- {(
- [
- ["h264", "H.264"],
- ["h265", "H.265"],
- // VP9 has no AMF hardware encoder on this GPU — the native pipeline
- // (the only MP4 export path now) rejects it outright (tested: a
- // software libvpx-vp9 fallback worked but was too slow to ship).
- // Hidden here rather than left selectable-then-erroring.
- ] as Array<[ExportVideoCodec, string]>
- ).map(([value, label]) => (
- <button
- type="button"
- key={value}
- disabled={isBusy}
- onClick={() => setCodec(value)}
- style={segStyle(codec === value)}
- title={
- value === "h264"
- ? t("exportDialog.codecBestCompatibility")
- : t("exportDialog.codecMaySupportVary")
- }
- >
- {label}
- </button>
- ))}
- </div>
- </div>
- </div>
- </section>
- ) : (
- <section style={{ display: "flex", flexDirection: "column", gap: 12 }}>
- <div>
- <div className={styles.groupLabel}>{t("exportDialog.frameRate")}</div>
- <div style={{ display: "grid", gridTemplateColumns: "repeat(4, 1fr)", gap: 6 }}>
- {GIF_FRAME_RATES.map((r) => (
- <button
- type="button"
- key={r.value}
- disabled={isBusy}
- onClick={() => setGifFrameRate(r.value)}
- style={segStyle(gifFrameRate === r.value)}
- >
- {r.value} FPS
- </button>
- ))}
- </div>
- </div>
- <div>
- <div className={styles.groupLabel}>{t("exportDialog.size")}</div>
- <div style={{ display: "grid", gridTemplateColumns: "repeat(2, 1fr)", gap: 6 }}>
- {(Object.keys(GIF_SIZE_PRESETS) as GifSizePreset[]).map((s) => (
- <button
- type="button"
- key={s}
- disabled={isBusy}
- onClick={() => setGifSize(s)}
- style={segStyle(gifSize === s)}
- >
- {GIF_SIZE_PRESETS[s].label}
- </button>
- ))}
- </div>
+ {label}
+ </button>
+ ))}
</div>
- <div className={styles.paneRow} style={{ margin: 0 }}>
- <span className={styles.label}>{t("exportDialog.loopGif")}</span>
+ </div>
+ </div>
+ </section>
+ ) : (
+ <section style={{ display: "flex", flexDirection: "column", gap: 12 }}>
+ <div>
+ <div className={styles.groupLabel}>{t("exportDialog.frameRate")}</div>
+ <div style={{ display: "grid", gridTemplateColumns: "repeat(4, 1fr)", gap: 6 }}>
+ {GIF_FRAME_RATES.map((r) => (
<button
type="button"
- className={`${styles.toggle} ${gifLoop ? styles.isOn : ""}`}
- aria-pressed={gifLoop}
+ key={r.value}
disabled={isBusy}
- onClick={() => setGifLoop((v) => !v)}
- />
- </div>
- <div
- style={{
- font: "500 12px/1.4 var(--font-body)",
- fontVariantNumeric: "tabular-nums",
- color: "var(--muted)",
- }}
- >
- {gifFrameRate} FPS · {gifSizeLabel} ·{" "}
- {gifLoop ? t("exportDialog.loopOn") : t("exportDialog.loopOff")}
- </div>
- </section>
- )}
- </>
- ) : null}
+ onClick={() => setGifFrameRate(r.value)}
+ style={segStyle(gifFrameRate === r.value)}
+ >
+ {r.value} FPS
+ </button>
+ ))}
+ </div>
+ </div>
+ <div>
+ <div className={styles.groupLabel}>{t("exportDialog.size")}</div>
+ <div style={{ display: "grid", gridTemplateColumns: "repeat(2, 1fr)", gap: 6 }}>
+ {(Object.keys(GIF_SIZE_PRESETS) as GifSizePreset[]).map((s) => (
+ <button
+ type="button"
+ key={s}
+ disabled={isBusy}
+ onClick={() => setGifSize(s)}
+ style={segStyle(gifSize === s)}
+ >
+ {GIF_SIZE_PRESETS[s].label}
+ </button>
+ ))}
+ </div>
+ </div>
+ <div className={styles.paneRow} style={{ margin: 0 }}>
+ <span className={styles.label}>{t("exportDialog.loopGif")}</span>
+ <button
+ type="button"
+ className={`${styles.toggle} ${gifLoop ? styles.isOn : ""}`}
+ aria-pressed={gifLoop}
+ disabled={isBusy}
+ onClick={() => setGifLoop((v) => !v)}
+ />
+ </div>
+ <div
+ style={{
+ font: "500 12px/1.4 var(--font-body)",
+ fontVariantNumeric: "tabular-nums",
+ color: "var(--muted)",
+ }}
+ >
+ {gifFrameRate} FPS · {gifSizeLabel} ·{" "}
+ {gifLoop ? t("exportDialog.loopOn") : t("exportDialog.loopOff")}
+ </div>
+ </section>
+ )}
<ProgressBlock
phase={phase}
diff --git a/src/components/ai-edition/NewEditorShell.module.css b/src/components/ai-edition/NewEditorShell.module.css
index 9b24797e6..667d0c5db 100644
--- a/src/components/ai-edition/NewEditorShell.module.css
+++ b/src/components/ai-edition/NewEditorShell.module.css
@@ -1280,22 +1280,6 @@ textarea.control {
border-color: var(--accent);
color: var(--accent);
}
-/* The export dialog's "Advanced" disclosure. Its own class: it must not ride on a pane's. */
-.exportAdvanced {
- display: inline-flex;
- align-self: flex-start;
- align-items: center;
- gap: 4px;
- padding: 0;
- border: 0;
- background: transparent;
- color: var(--fg-2);
- font: 500 13px/1.2 var(--font-body);
- cursor: pointer;
-}
-.exportAdvanced:hover { color: var(--fg); }
-.exportAdvanced svg { transition: transform var(--motion-fast) var(--ease); }
-.exportAdvanced[aria-expanded="true"] svg { transform: rotate(180deg); }
.bgThumb:hover { transform: translateY(-1px); }
.bgThumb.isActive {
border-color: var(--brand);
diff --git a/src/i18n/locales/ar/editor.json b/src/i18n/locales/ar/editor.json
index 7fa393cd2..cfba362af 100644
--- a/src/i18n/locales/ar/editor.json
+++ b/src/i18n/locales/ar/editor.json
@@ -171,12 +171,6 @@
"noSpeechDetected": "لم يتم اكتشاف كلام"
},
"exportDialog": {
- "destination": "الوجهة",
- "destinationWeb": "الويب / YouTube",
- "destinationSocial": "وسائل التواصل",
- "destinationStudio": "استوديو",
- "destinationReadmeGif": "GIF لملف README",
- "advanced": "متقدّم",
"title": "تصدير",
"subtitle": "عرض المخطط الزمني إلى ملف",
"addVideoBeforeExporting": "أضف فيديو قبل التصدير.",
diff --git a/src/i18n/locales/cs/editor.json b/src/i18n/locales/cs/editor.json
index eba1a63c1..63e8341ee 100644
--- a/src/i18n/locales/cs/editor.json
+++ b/src/i18n/locales/cs/editor.json
@@ -171,12 +171,6 @@
"noSpeechDetected": "Žádná řeč nezjištěna"
},
"exportDialog": {
- "destination": "Cíl",
- "destinationWeb": "Web / YouTube",
- "destinationSocial": "Sociální sítě",
- "destinationStudio": "Studio",
- "destinationReadmeGif": "GIF do README",
- "advanced": "Pokročilé",
"title": "Export",
"subtitle": "Vykreslení časové osy do souboru",
"addVideoBeforeExporting": "Před exportem přidejte video.",
diff --git a/src/i18n/locales/de/editor.json b/src/i18n/locales/de/editor.json
index 6e65c4c17..94758a940 100644
--- a/src/i18n/locales/de/editor.json
+++ b/src/i18n/locales/de/editor.json
@@ -171,12 +171,6 @@
"noSpeechDetected": "Keine Sprache erkannt"
},
"exportDialog": {
- "destination": "Ziel",
- "destinationWeb": "Web / YouTube",
- "destinationSocial": "Social Media",
- "destinationStudio": "Studio",
- "destinationReadmeGif": "README-GIF",
- "advanced": "Erweitert",
"title": "Export",
"subtitle": "Die Timeline in eine Datei rendern",
"addVideoBeforeExporting": "Füge vor dem Export ein Video hinzu.",
diff --git a/src/i18n/locales/en/editor.json b/src/i18n/locales/en/editor.json
index b241dba79..7998b34db 100644
--- a/src/i18n/locales/en/editor.json
+++ b/src/i18n/locales/en/editor.json
@@ -171,12 +171,6 @@
"noSpeechDetected": "No speech detected"
},
"exportDialog": {
- "destination": "Destination",
- "destinationWeb": "Web / YouTube",
- "destinationSocial": "Social",
- "destinationStudio": "Studio",
- "destinationReadmeGif": "README GIF",
- "advanced": "Advanced",
"title": "Export",
"subtitle": "Save your edit as a video or a GIF",
"addVideoBeforeExporting": "Add a video before exporting.",
diff --git a/src/i18n/locales/es/editor.json b/src/i18n/locales/es/editor.json
index 578b9cb12..0f8da2076 100644
--- a/src/i18n/locales/es/editor.json
+++ b/src/i18n/locales/es/editor.json
@@ -171,12 +171,6 @@
"noSpeechDetected": "No se detectó voz"
},
"exportDialog": {
- "destination": "Destino",
- "destinationWeb": "Web / YouTube",
- "destinationSocial": "Redes sociales",
- "destinationStudio": "Estudio",
- "destinationReadmeGif": "GIF para README",
- "advanced": "Avanzado",
"title": "Exportar",
"subtitle": "Renderizar la línea de tiempo a un archivo",
"addVideoBeforeExporting": "Añade un vídeo antes de exportar.",
diff --git a/src/i18n/locales/fr/editor.json b/src/i18n/locales/fr/editor.json
index 8494f0f27..242a7a262 100644
--- a/src/i18n/locales/fr/editor.json
+++ b/src/i18n/locales/fr/editor.json
@@ -171,12 +171,6 @@
"noSpeechDetected": "Aucune parole détectée"
},
"exportDialog": {
- "destination": "Destination",
- "destinationWeb": "Web / YouTube",
- "destinationSocial": "Réseaux sociaux",
- "destinationStudio": "Studio",
- "destinationReadmeGif": "GIF pour README",
- "advanced": "Avancé",
"title": "Exporter",
"subtitle": "Rendre la timeline dans un fichier",
"addVideoBeforeExporting": "Ajoutez une vidéo avant d'exporter.",
diff --git a/src/i18n/locales/it/editor.json b/src/i18n/locales/it/editor.json
index 4b7480f11..53de70d12 100644
--- a/src/i18n/locales/it/editor.json
+++ b/src/i18n/locales/it/editor.json
@@ -171,12 +171,6 @@
"noSpeechDetected": "Nessun parlato rilevato"
},
"exportDialog": {
- "destination": "Destinazione",
- "destinationWeb": "Web / YouTube",
- "destinationSocial": "Social",
- "destinationStudio": "Studio",
- "destinationReadmeGif": "GIF per README",
- "advanced": "Avanzate",
"title": "Esporta",
"subtitle": "Esegui il rendering della timeline in un file",
"addVideoBeforeExporting": "Aggiungi un video prima di esportare.",
diff --git a/src/i18n/locales/ja-JP/editor.json b/src/i18n/locales/ja-JP/editor.json
index 97ca8c18e..61051248a 100644
--- a/src/i18n/locales/ja-JP/editor.json
+++ b/src/i18n/locales/ja-JP/editor.json
@@ -171,12 +171,6 @@
"noSpeechDetected": "音声が検出されませんでした"
},
"exportDialog": {
- "destination": "書き出し先",
- "destinationWeb": "Web / YouTube",
- "destinationSocial": "SNS",
- "destinationStudio": "スタジオ",
- "destinationReadmeGif": "README 用 GIF",
- "advanced": "詳細設定",
"title": "エクスポート",
"subtitle": "タイムラインをファイルに書き出します",
"addVideoBeforeExporting": "エクスポートする前に動画を追加してください。",
diff --git a/src/i18n/locales/ko-KR/editor.json b/src/i18n/locales/ko-KR/editor.json
index bb885f92e..c5200a5d7 100644
--- a/src/i18n/locales/ko-KR/editor.json
+++ b/src/i18n/locales/ko-KR/editor.json
@@ -171,12 +171,6 @@
"noSpeechDetected": "음성이 감지되지 않음"
},
"exportDialog": {
- "destination": "내보낼 곳",
- "destinationWeb": "웹 / YouTube",
- "destinationSocial": "소셜 미디어",
- "destinationStudio": "스튜디오",
- "destinationReadmeGif": "README용 GIF",
- "advanced": "고급",
"title": "내보내기",
"subtitle": "타임라인을 파일로 렌더링합니다",
"addVideoBeforeExporting": "내보내기 전에 동영상을 추가하세요.",
diff --git a/src/i18n/locales/pt-BR/editor.json b/src/i18n/locales/pt-BR/editor.json
index 9f2cd0a50..4e7ca3eb0 100644
--- a/src/i18n/locales/pt-BR/editor.json
+++ b/src/i18n/locales/pt-BR/editor.json
@@ -171,12 +171,6 @@
"noSpeechDetected": "Nenhuma fala detectada"
},
"exportDialog": {
- "destination": "Destino",
- "destinationWeb": "Web / YouTube",
- "destinationSocial": "Redes sociais",
- "destinationStudio": "Estúdio",
- "destinationReadmeGif": "GIF para README",
- "advanced": "Avançado",
"title": "Exportar",
"subtitle": "Renderizar a linha do tempo para um arquivo",
"addVideoBeforeExporting": "Adicione um vídeo antes de exportar.",
diff --git a/src/i18n/locales/ru/editor.json b/src/i18n/locales/ru/editor.json
index f9a147890..a54c43796 100644
--- a/src/i18n/locales/ru/editor.json
+++ b/src/i18n/locales/ru/editor.json
@@ -171,12 +171,6 @@
"noSpeechDetected": "Речь не обнаружена"
},
"exportDialog": {
- "destination": "Назначение",
- "destinationWeb": "Веб / YouTube",
- "destinationSocial": "Соцсети",
- "destinationStudio": "Студия",
- "destinationReadmeGif": "GIF для README",
- "advanced": "Дополнительно",
"title": "Экспорт",
"subtitle": "Рендеринг таймлайна в файл",
"addVideoBeforeExporting": "Добавьте видео перед экспортом.",
diff --git a/src/i18n/locales/tr/editor.json b/src/i18n/locales/tr/editor.json
index 96b0cb3c7..3f6ca7d2d 100644
--- a/src/i18n/locales/tr/editor.json
+++ b/src/i18n/locales/tr/editor.json
@@ -171,12 +171,6 @@
"noSpeechDetected": "Konuşma algılanmadı"
},
"exportDialog": {
- "destination": "Hedef",
- "destinationWeb": "Web / YouTube",
- "destinationSocial": "Sosyal medya",
- "destinationStudio": "Stüdyo",
- "destinationReadmeGif": "README GIF'i",
- "advanced": "Gelişmiş",
"title": "Dışa Aktar",
"subtitle": "Zaman çizelgesini bir dosyaya işleyin",
"addVideoBeforeExporting": "Dışa aktarmadan önce bir video ekleyin.",
diff --git a/src/i18n/locales/vi/editor.json b/src/i18n/locales/vi/editor.json
index 2398c50d8..83bc5bdf5 100644
--- a/src/i18n/locales/vi/editor.json
+++ b/src/i18n/locales/vi/editor.json
@@ -171,12 +171,6 @@
"noSpeechDetected": "Không phát hiện giọng nói"
},
"exportDialog": {
- "destination": "Đích đến",
- "destinationWeb": "Web / YouTube",
- "destinationSocial": "Mạng xã hội",
- "destinationStudio": "Studio",
- "destinationReadmeGif": "GIF cho README",
- "advanced": "Nâng cao",
"title": "Xuất",
"subtitle": "Kết xuất dòng thời gian thành tệp",
"addVideoBeforeExporting": "Thêm video trước khi xuất.",
diff --git a/src/i18n/locales/zh-CN/editor.json b/src/i18n/locales/zh-CN/editor.json
index 0e7bf99cb..191c7ae96 100644
--- a/src/i18n/locales/zh-CN/editor.json
+++ b/src/i18n/locales/zh-CN/editor.json
@@ -171,12 +171,6 @@
"noSpeechDetected": "未检测到语音"
},
"exportDialog": {
- "destination": "导出用途",
- "destinationWeb": "网页 / YouTube",
- "destinationSocial": "社交媒体",
- "destinationStudio": "工作室",
- "destinationReadmeGif": "README GIF",
- "advanced": "高级",
"title": "导出",
"subtitle": "将时间轴渲染为文件",
"addVideoBeforeExporting": "导出前请先添加视频。",
diff --git a/src/i18n/locales/zh-TW/editor.json b/src/i18n/locales/zh-TW/editor.json
index e5f3a3f7e..18b07d3c7 100644
--- a/src/i18n/locales/zh-TW/editor.json
+++ b/src/i18n/locales/zh-TW/editor.json
@@ -171,12 +171,6 @@
"noSpeechDetected": "未偵測到語音"
},
"exportDialog": {
- "destination": "匯出用途",
- "destinationWeb": "網頁 / YouTube",
- "destinationSocial": "社群媒體",
- "destinationStudio": "工作室",
- "destinationReadmeGif": "README GIF",
- "advanced": "進階",
"title": "匯出",
"subtitle": "將時間軸轉譯為檔案",
"addVideoBeforeExporting": "匯出前請先新增影片。",
diff --git a/tests/e2e/gif-export.spec.ts b/tests/e2e/gif-export.spec.ts
index 712b8c8ef..30f4b0a02 100644
--- a/tests/e2e/gif-export.spec.ts
+++ b/tests/e2e/gif-export.spec.ts
@@ -163,8 +163,6 @@ async function exportFromLoadedVideo(
const dialog = editorWindow.getByRole("dialog");
await expect(dialog.getByRole("heading", { name: "Export" })).toBeVisible();
- // The format toggle sits under Advanced, behind the named destinations.
- await dialog.getByRole("button", { name: "Advanced", exact: true }).click();
await dialog
.getByRole("button", { name: format === "gif" ? "GIF" : "MP4", exact: true })
.click();