Record your screen, ship a demo. Free and open-source, GPU-accelerated, no watermarks, no subscriptions. Windows, macOS, Linux. Actively maintained.
TypeScript cross-platformelectronffmpegopen-sourceproduct-demorustscreen-capturescreen-recorderscreen-recordingscreen-studioscreencastspeech-to-texttypescriptvideo-editingvideo-editorwaylandwgpuwhisper
fix(windows): move the keep-alive tone above audible range
abduznik49c977e1d91b
diff --git a/electron/native/wgc-capture/src/wasapi_render_keepalive.cpp b/electron/native/wgc-capture/src/wasapi_render_keepalive.cppindex 56ef58b54..e51042dec 100644--- a/electron/native/wgc-capture/src/wasapi_render_keepalive.cpp+++ b/electron/native/wgc-capture/src/wasapi_render_keepalive.cpp@@ -1,5 +1,6 @@#include "wasapi_render_keepalive.h"+#include <algorithm>#include <chrono>#include <cmath>#include <cstring>@@ -9,11 +10,14 @@namespace {constexpr REFERENCE_TIME BufferDurationHns = 10'000'000;-// Quiet enough to be inaudible in any real listening scenario, loud enough to be-// genuine, non-zero signal rather than something a downstream limiter/gate could-// treat as silence.-constexpr double ToneAmplitude = 0.01;-constexpr double ToneFrequencyHz = 1000.0;+// A 1kHz tone at 1% amplitude was clearly audible in testing -- 1kHz sits right+// in the most sensitive part of human hearing, so "quiet" in raw amplitude terms+// was still loud in perceived loudness. 19kHz is above what the large majority of+// adults can hear at all (upper hearing limit typically drops well below 20kHz+// with age), so the actual amplitude can afford to be smaller still and remain+// robustly non-silent to the audio engine.+constexpr double ToneAmplitude = 0.003;+constexpr double ToneFrequencyHz = 19000.0;bool isFloatFormat(const WAVEFORMATEX* format) {if (format->wFormatTag == WAVE_FORMAT_IEEE_FLOAT) {@@ -34,7 +38,13 @@ constexpr double TwoPi = 2.0 * 3.14159265358979323846;// continue from on the next call, so the waveform stays continuous across// separate GetBuffer/ReleaseBuffer calls instead of clicking at each boundary.double writeToneFrames(BYTE* data, UINT32 frameCount, const WAVEFORMATEX* format, double phase) {- const double phaseStep = TwoPi * ToneFrequencyHz / format->nSamplesPerSec;+ // Keep comfortably below Nyquist regardless of the device's actual sample+ // rate (typically 44.1/48kHz, but not guaranteed): a device reporting+ // something unusually low would otherwise alias 19kHz down into an audible+ // frequency instead of staying inaudible.+ const double nyquist = format->nSamplesPerSec / 2.0;+ const double toneFrequencyHz = std::min(ToneFrequencyHz, nyquist * 0.9);+ const double phaseStep = TwoPi * toneFrequencyHz / format->nSamplesPerSec;const bool isFloat = isFloatFormat(format);const UINT16 bitsPerSample = format->wBitsPerSample;diff --git a/electron/native/wgc-capture/src/wasapi_render_keepalive.h b/electron/native/wgc-capture/src/wasapi_render_keepalive.hindex e13a78212..3862226be 100644--- a/electron/native/wgc-capture/src/wasapi_render_keepalive.h+++ b/electron/native/wgc-capture/src/wasapi_render_keepalive.h@@ -20,10 +20,16 @@// reads real audio, when something is playing) prevents the drop but mic-only// capture (which touches nothing) does not -- some headsets' firmware appears to// require genuine signal, not merely a live but silent stream, to register as-// activity. The tone amplitude is low enough (1%) to be inaudible in practice and-// is never captured into the recording itself, since this writes to the render-// endpoint and the recording only captures it when system-audio (loopback) is-// also on -- the same case that already doesn't need this workaround.+// activity.+//+// A first attempt at 1kHz / 1% amplitude was clearly audible in testing -- 1kHz+// sits in the most sensitive part of human hearing, so "quiet" in raw amplitude+// terms was still perceptibly loud. The tone is now 19kHz (above what the large+// majority of adults can hear at all) at 0.3% amplitude, adapted downward if the+// device's actual sample rate can't represent 19kHz cleanly. It is never captured+// into the recording itself, since this writes to the render endpoint and the+// recording only captures it when system-audio (loopback) is also on -- the same+// case that already doesn't need this workaround.//// Kill-switch: set OPENSCREEN_WGC_DISABLE_AUDIO_KEEPALIVE=1 to turn this off.