Skip to content

Record your screen, ship a demo. Free and open-source, GPU-accelerated, no watermarks, no subscriptions. Windows, macOS, Linux. Actively maintained.

fix(macos): accept 8-bit integer PCM microphone input

EtienneLescot9da9c54404c5
diff --git a/electron/native/screencapturekit/Sources/OpenScreenCaptureCore/AudioTrackMixer.swift b/electron/native/screencapturekit/Sources/OpenScreenCaptureCore/AudioTrackMixer.swift
index 47d62951e..18895cb66 100644
--- a/electron/native/screencapturekit/Sources/OpenScreenCaptureCore/AudioTrackMixer.swift
+++ b/electron/native/screencapturekit/Sources/OpenScreenCaptureCore/AudioTrackMixer.swift
@@ -505,7 +505,7 @@ public final class AudioTrackMixer {
sourceFrames > 0,
isFloat
? bitsPerChannel == 32 && bytesPerSample == 4
- : (8...32).contains(bitsPerChannel) && (2...4).contains(bytesPerSample)
+ : (8...32).contains(bitsPerChannel) && (1...4).contains(bytesPerSample)
&& bitsPerChannel <= bytesPerSample * 8
else {
return nil
diff --git a/electron/native/screencapturekit/Tests/OpenScreenCaptureCoreTests/AudioTrackMixerTests.swift b/electron/native/screencapturekit/Tests/OpenScreenCaptureCoreTests/AudioTrackMixerTests.swift
index 64492a7ce..baf8a7c9c 100644
--- a/electron/native/screencapturekit/Tests/OpenScreenCaptureCoreTests/AudioTrackMixerTests.swift
+++ b/electron/native/screencapturekit/Tests/OpenScreenCaptureCoreTests/AudioTrackMixerTests.swift
@@ -463,6 +463,7 @@ final class AudioTrackMixerTests: XCTestCase {
/// level and with the right sign.
func testIntegerMicrophoneFormatsAreHeardAtTheirLevel() {
let layouts: [(bits: Int, bytes: Int, alignedHigh: Bool, signed: Bool, label: String)] = [
+ (8, 1, false, true, "8-bit"),
(24, 3, false, true, "24-bit packed (the reported format)"),
(24, 4, false, true, "24-bit in 4 bytes, low-aligned"),
(24, 4, true, true, "24-bit in 4 bytes, high-aligned"),