Skip to content

Record your screen, ship a demo. Free and open-source, GPU-accelerated, no watermarks, no subscriptions. Windows, macOS, Linux. Actively maintained.

fix(cursor): put click impact right under click bounce

EtienneLescota10c65eb6b3b
diff --git a/src/components/ai-edition/CursorPane.levels.test.tsx b/src/components/ai-edition/CursorPane.levels.test.tsx
index 9dc86741e..bc714e2f7 100644
--- a/src/components/ai-edition/CursorPane.levels.test.tsx
+++ b/src/components/ai-edition/CursorPane.levels.test.tsx
@@ -203,6 +203,16 @@ describe("CursorPane click impact", () => {
});
});
+ it("sits right under the click bounce levels", () => {
+ renderWithCursor({});
+ const controls = [...document.querySelectorAll("button, input")];
+ const levels = within(screen.getByRole("group", { name: "Click bounce" })).getAllByRole(
+ "button",
+ );
+ const last = controls.indexOf(levels[levels.length - 1]);
+ expect(controls.indexOf(toggle() as HTMLElement)).toBe(last + 1);
+ });
+
// The impact follows the pointer you see: with the cursor hidden it has nothing to show.
it("is not offered while the cursor is hidden", () => {
renderWithCursor({ cursorShow: false });
diff --git a/src/components/ai-edition/RightPanes.tsx b/src/components/ai-edition/RightPanes.tsx
index 75c9050e7..8a92d2cc7 100644
--- a/src/components/ai-edition/RightPanes.tsx
+++ b/src/components/ai-edition/RightPanes.tsx
@@ -3726,18 +3726,6 @@ export function CursorPane() {
}}
/>
</div>
- {/* A hidden cursor has nothing to click with, so this row is not offered then. */}
- {settings.cursorShow ? (
- <div className={styles.paneRow}>
- <span className={styles.label}>{ts("cursor.clickImpact")}</span>
- <Toggle
- ariaLabel={ts("cursor.clickImpact")}
- checked={settings.cursor.clickImpact}
- disabled={!hasDocument}
- onChange={(v) => void set({ cursor: { clickImpact: v } })}
- />
- </div>
- ) : null}
{/* One option is not a choice: the picker shows once a pack ships beside the
default art (see CURSOR_THEMES). */}
{cursorThemeOptions.length > 1 ? (
@@ -3910,6 +3898,19 @@ export function CursorPane() {
if (isNativeCompositorActive()) setNativeParam("cursorClickBounce", clickBounce);
},
)}
+ {/* What the screen does on the click the bounce animates, so right under it. A hidden
+ cursor has nothing to click with, so the row is not offered then. */}
+ {settings.cursorShow ? (
+ <div className={styles.paneRow}>
+ <span className={styles.label}>{ts("cursor.clickImpact")}</span>
+ <Toggle
+ ariaLabel={ts("cursor.clickImpact")}
+ checked={settings.cursor.clickImpact}
+ disabled={!hasDocument}
+ onChange={(v) => void set({ cursor: { clickImpact: v } })}
+ />
+ </div>
+ ) : null}
</Pane>
);
}