Open-source status page, incident response and uptime monitoring
TypeScript alertingincident-managementmcpmcp-servermonitoringmonitoring-as-codeobservabilityon-callopen-sourcesrestatus-pagestatuspagesynthetic-monitoringterraformtinybirdtursouptimeuptime-checkeruptime-monitor
fix: missing portal (#729)
Maximilian Kaske374e5f9fe1c2
diff --git a/packages/ui/src/components/hover-card.tsx b/packages/ui/src/components/hover-card.tsxindex 3c5434ffb..edaa3db92 100644--- a/packages/ui/src/components/hover-card.tsx+++ b/packages/ui/src/components/hover-card.tsx@@ -7,23 +7,28 @@ import { cn } from "../lib/utils";const HoverCard = HoverCardPrimitive.Root;+// REMINDER: fixes the Safari 17.4. bug where portal floats somewhere+const HoverCardPortal = HoverCardPrimitive.Portal;+const HoverCardTrigger = HoverCardPrimitive.Trigger;const HoverCardContent = React.forwardRef<React.ElementRef<typeof HoverCardPrimitive.Content>,React.ComponentPropsWithoutRef<typeof HoverCardPrimitive.Content>>(({ className, align = "center", sideOffset = 4, ...props }, ref) => (- <HoverCardPrimitive.Content- ref={ref}- align={align}- sideOffset={sideOffset}- className={cn(- "bg-popover text-popover-foreground data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 z-50 w-64 rounded-md border p-4 shadow-md outline-none",- className,- )}- {...props}- />+ <HoverCardPortal>+ <HoverCardPrimitive.Content+ ref={ref}+ align={align}+ sideOffset={sideOffset}+ className={cn(+ "bg-popover text-popover-foreground data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 z-50 w-64 rounded-md border p-4 shadow-md outline-none",+ className,+ )}+ {...props}+ />+ </HoverCardPortal>));HoverCardContent.displayName = HoverCardPrimitive.Content.displayName;-export { HoverCard, HoverCardTrigger, HoverCardContent };+export { HoverCard, HoverCardPortal, HoverCardTrigger, HoverCardContent };diff --git a/packages/ui/src/components/tooltip.tsx b/packages/ui/src/components/tooltip.tsxindex 0dd180a76..91b804ce4 100644--- a/packages/ui/src/components/tooltip.tsx+++ b/packages/ui/src/components/tooltip.tsx@@ -9,22 +9,33 @@ const TooltipProvider = TooltipPrimitive.Provider;const Tooltip = TooltipPrimitive.Root;+// REMINDER: fixes the Safari 17.4. bug where portal floats somewhere+const TooltipPortal = TooltipPrimitive.Portal;+const TooltipTrigger = TooltipPrimitive.Trigger;const TooltipContent = React.forwardRef<React.ElementRef<typeof TooltipPrimitive.Content>,React.ComponentPropsWithoutRef<typeof TooltipPrimitive.Content>>(({ className, sideOffset = 4, ...props }, ref) => (- <TooltipPrimitive.Content- ref={ref}- sideOffset={sideOffset}- className={cn(- "bg-popover text-popover-foreground animate-in fade-in-0 zoom-in-95 data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=closed]:zoom-out-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 z-50 overflow-hidden rounded-md border px-3 py-1.5 text-sm shadow-md",- className,- )}- {...props}- />+ <TooltipPortal>+ <TooltipPrimitive.Content+ ref={ref}+ sideOffset={sideOffset}+ className={cn(+ "bg-popover text-popover-foreground animate-in fade-in-0 zoom-in-95 data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=closed]:zoom-out-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 z-50 overflow-hidden rounded-md border px-3 py-1.5 text-sm shadow-md",+ className,+ )}+ {...props}+ />+ </TooltipPortal>));TooltipContent.displayName = TooltipPrimitive.Content.displayName;-export { Tooltip, TooltipTrigger, TooltipContent, TooltipProvider };+export {+ Tooltip,+ TooltipTrigger,+ TooltipPortal,+ TooltipContent,+ TooltipProvider,+};