Open-source status page, incident response and uptime monitoring
TypeScript alertingincident-managementmcpmcp-servermonitoringmonitoring-as-codeobservabilityon-callopen-sourcesrestatus-pagestatuspagesynthetic-monitoringterraformtinybirdtursouptimeuptime-checkeruptime-monitor
fix: onboarding dom-based xss (#1980)
Maximilian Kaske43d9b2b9ef8a
diff --git a/apps/dashboard/src/app/(dashboard)/onboarding/client.tsx b/apps/dashboard/src/app/(dashboard)/onboarding/client.tsxindex dbfb2688c..8488c49be 100644--- a/apps/dashboard/src/app/(dashboard)/onboarding/client.tsx+++ b/apps/dashboard/src/app/(dashboard)/onboarding/client.tsx@@ -134,10 +134,15 @@ export function Client() {try {const url = new URL(callbackUrl, window.location.origin);if (url.pathname === "/" || url.pathname === "") return;+ // Only allow same-origin redirects with safe protocols+ if (url.origin !== window.location.origin) return;+ if (url.protocol !== "http:" && url.protocol !== "https:") return;router.push(callbackUrl);} catch {// If callbackUrl is a relative path, check it directlyif (callbackUrl === "/" || callbackUrl === "") return;+ // Only allow paths starting with / to prevent protocol-based attacks+ if (!callbackUrl.startsWith("/")) return;router.push(callbackUrl);}}, [callbackUrl, router]);