Skip to content

Open-source status page, incident response and uptime monitoring

fix: trpc security issues (#1866)

Maximilian Kaske44bdbc1641f4
diff --git a/packages/api/src/router/page.ts b/packages/api/src/router/page.ts
index 14c433f51..3a23ccbe5 100644
--- a/packages/api/src/router/page.ts
+++ b/packages/api/src/router/page.ts
@@ -191,11 +191,15 @@ export const pageRouter = createTRPCRouter({
});
}
- // TODO Add some check ?
await opts.ctx.db
.update(page)
.set({ customDomain: opts.input.customDomain, updatedAt: new Date() })
- .where(eq(page.id, opts.input.pageId))
+ .where(
+ and(
+ eq(page.id, opts.input.pageId),
+ eq(page.workspaceId, opts.ctx.workspace.id),
+ ),
+ )
.returning()
.get();
}),
diff --git a/packages/api/src/router/statusReport.ts b/packages/api/src/router/statusReport.ts
index a95849674..1d22e2a16 100644
--- a/packages/api/src/router/statusReport.ts
+++ b/packages/api/src/router/statusReport.ts
@@ -64,6 +64,18 @@ export const statusReportRouter = createTRPCRouter({
if (!statusReportUpdateInput.id) return;
+ const existing = await opts.ctx.db.query.statusReportUpdate.findFirst({
+ where: eq(statusReportUpdate.id, statusReportUpdateInput.id),
+ with: { statusReport: true },
+ });
+
+ if (existing?.statusReport.workspaceId !== opts.ctx.workspace.id) {
+ throw new TRPCError({
+ code: "FORBIDDEN",
+ message: "You are not allowed to update this status report update",
+ });
+ }
+
const currentStatusReportUpdate = await opts.ctx.db
.update(statusReportUpdate)
.set({ ...statusReportUpdateInput, updatedAt: new Date() })