Open-source status page, incident response and uptime monitoring
TypeScript alertingincident-managementmcpmcp-servermonitoringmonitoring-as-codeobservabilityon-callopen-sourcesrestatus-pagestatuspagesynthetic-monitoringterraformtinybirdtursouptimeuptime-checkeruptime-monitor
🔄 improve retry (#583)
Thibault Le Ouay45946a869a1c
diff --git a/apps/checker/cmd/main.go b/apps/checker/cmd/main.goindex 43b47da86..9deab4349 100644--- a/apps/checker/cmd/main.go+++ b/apps/checker/cmd/main.go@@ -66,12 +66,12 @@ func main() {}// if the request has been routed to a wrong region, we forward it to the correct one.- region := c.GetHeader("fly-prefer-region")- if region != "" && region != flyRegion {- c.Header("fly-replay", fmt.Sprintf("region=%s", region))- c.String(http.StatusAccepted, "Forwarding request to %s", region)- return- }+ region := c.GetHeader("fly-prefer-region")+ if region != "" && region != flyRegion {+ c.Header("fly-replay", fmt.Sprintf("region=%s", region))+ c.String(http.StatusAccepted, "Forwarding request to %s", region)+ return+ }var req request.CheckerRequestif err := c.ShouldBindJSON(&req); err != nil {@@ -79,14 +79,20 @@ func main() {c.JSON(http.StatusBadRequest, gin.H{"error": "invalid request"})return}-+ var called intop := func() error {+ called++res, err := checker.Ping(ctx, httpClient, req)if err != nil {return fmt.Errorf("unable to ping: %w", err)}statusCode := statusCode(res.StatusCode)+ // let's retry at least once if the status code is not successful.+ if !statusCode.IsSuccessful() && called < 2 {+ return fmt.Errorf("unable to ping: %v with status %v", res, res.StatusCode)+ }+if !statusCode.IsSuccessful() {// Q: Why here we do not check if the status was previously active?checker.UpdateStatus(ctx, checker.UpdateData{