Skip to content

Open-source status page, incident response and uptime monitoring

fix(server): stabilize GetPageComponent test for unset monitorId (#2393)

Maximilian Kaske50a622dbd36d
diff --git a/apps/server/src/routes/rpc/handlers/status-page/__tests__/status-page.test.ts b/apps/server/src/routes/rpc/handlers/status-page/__tests__/status-page.test.ts
index 400d8fab0..fbdf228c3 100644
--- a/apps/server/src/routes/rpc/handlers/status-page/__tests__/status-page.test.ts
+++ b/apps/server/src/routes/rpc/handlers/status-page/__tests__/status-page.test.ts
@@ -559,7 +559,9 @@ describe("StatusPageService.GetPageComponent", () => {
expect(data.component.name).toBe(`${TEST_PREFIX}-component`);
expect(data.component.pageId).toBe(String(testPageId));
expect(data.component.type).toBe("PAGE_COMPONENT_TYPE_STATIC");
- expect(data.component.monitorId).toBe("");
+ // proto3 omits default-valued scalars from JSON, so an unset monitor
+ // arrives as either "" or undefined.
+ expect(data.component.monitorId ?? "").toBe("");
});
test("returns 401 when no auth key provided", async () => {