Skip to content

Open-source status page, incident response and uptime monitoring

chore: include resolved in email subject (#2313)

Maximilian Kaske57c9e0efbcf0
diff --git a/packages/emails/src/client.integration.test.tsx b/packages/emails/src/client.integration.test.tsx
index caf8671d8..9733456fd 100644
--- a/packages/emails/src/client.integration.test.tsx
+++ b/packages/emails/src/client.integration.test.tsx
@@ -5,6 +5,7 @@ import { describe, expect, test } from "bun:test";
import { render } from "react-email";
import StatusReportEmail from "../emails/status-report";
+import { statusReportSubject } from "./client";
describe("Status Report Email - Unsubscribe Link in Body", () => {
const unsubscribeUrl =
@@ -83,6 +84,31 @@ describe("Status Report Email - Unsubscribe Link in Body", () => {
});
});
+describe("Status Report Email - Subject Line", () => {
+ const reportTitle = "API Outage";
+
+ test('prepends "RESOLVED:" only when status is "resolved"', () => {
+ expect(statusReportSubject({ status: "resolved", reportTitle })).toBe(
+ `RESOLVED: ${reportTitle}`,
+ );
+ });
+
+ test('does not prepend "RESOLVED:" for any non-resolved status', () => {
+ const nonResolved = [
+ "investigating",
+ "identified",
+ "monitoring",
+ "maintenance",
+ ] as const;
+
+ for (const status of nonResolved) {
+ const subject = statusReportSubject({ status, reportTitle });
+ expect(subject).toBe(reportTitle);
+ expect(subject).not.toContain("RESOLVED:");
+ }
+ });
+});
+
describe("Status Report Email - Email Content Validation", () => {
test("should include all required email fields", async () => {
const props = {
diff --git a/packages/emails/src/client.tsx b/packages/emails/src/client.tsx
index 61775152e..ce7b7a687 100644
--- a/packages/emails/src/client.tsx
+++ b/packages/emails/src/client.tsx
@@ -17,6 +17,15 @@ import TeamInvitationEmail from "../emails/team-invitation";
import type { TeamInvitationProps } from "../emails/team-invitation";
import { monitorAlertEmail } from "../hotfix/monitor-alert";
+export function statusReportSubject(req: {
+ status: StatusReportProps["status"];
+ reportTitle: string;
+}): string {
+ return req.status === "resolved"
+ ? `RESOLVED: ${req.reportTitle}`
+ : req.reportTitle;
+}
+
// split an array into chunks of a given size.
function chunk<T>(array: T[], size: number): T[][] {
const result: T[][] = [];
@@ -176,7 +185,7 @@ export class EmailClient {
const manageUrl = `${statusPageBaseUrl}/manage/${subscriber.token}`;
return {
from: `${req.pageTitle} <[email protected]>`,
- subject: req.reportTitle,
+ subject: statusReportSubject(req),
to: subscriber.email,
react: (
<StatusReportEmail