Skip to content

Open-source status page, incident response and uptime monitoring

fix: prevent spurious recovery notifications for private locations (#2531)

Max60f1527d3d33
diff --git a/apps/workflows/src/checker/private-location.ts b/apps/workflows/src/checker/private-location.ts
index f4653d543..b72a4cc22 100644
--- a/apps/workflows/src/checker/private-location.ts
+++ b/apps/workflows/src/checker/private-location.ts
@@ -326,8 +326,11 @@ export async function updateStatusPrivate(c: Context<Env>) {
latency,
},
});
- // Trigger notifications for cloud monitors always, private-only when threshold met
- if (hasCloudRegions || shouldTriggerIncident) {
+ // Trigger notifications for cloud monitors always, private-only when threshold met AND status changed
+ if (
+ hasCloudRegions ||
+ (shouldTriggerIncident && monitor.status !== "error")
+ ) {
triggeredNotifications = await triggerNotifications({
monitorId,
statusCode,
@@ -389,8 +392,11 @@ export async function updateStatusPrivate(c: Context<Env>) {
latency,
},
});
- // Trigger notifications for cloud monitors always, private-only when threshold met
- if (hasCloudRegions || shouldTriggerIncident) {
+ // Trigger notifications for cloud monitors always, private-only when threshold met AND status changed
+ if (
+ hasCloudRegions ||
+ (shouldTriggerIncident && monitor.status !== "degraded")
+ ) {
triggeredNotifications = await triggerNotifications({
monitorId,
statusCode,
@@ -449,8 +455,11 @@ export async function updateStatusPrivate(c: Context<Env>) {
latency,
},
});
- // Trigger notifications for cloud monitors always, private-only when threshold met
- if (hasCloudRegions || shouldTriggerIncident) {
+ // Trigger notifications for cloud monitors always, private-only when threshold met AND status changed
+ if (
+ hasCloudRegions ||
+ (shouldTriggerIncident && monitor.status !== "active")
+ ) {
triggeredNotifications = await triggerNotifications({
monitorId,
statusCode,