Open-source status page, incident response and uptime monitoring
TypeScript alertingincident-managementmcpmcp-servermonitoringmonitoring-as-codeobservabilityon-callopen-sourcesrestatus-pagestatuspagesynthetic-monitoringterraformtinybirdtursouptimeuptime-checkeruptime-monitor
Feat/never panic (#737)
Arthur EICHELBERGER631acb75f3f3
diff --git a/apps/checker/pkg/assertions/assertions.go b/apps/checker/pkg/assertions/assertions.goindex 93d01a41a..31a7f1434 100644--- a/apps/checker/pkg/assertions/assertions.go+++ b/apps/checker/pkg/assertions/assertions.go@@ -63,7 +63,7 @@ func (target HeaderTarget) HeaderEvaluate(s string) bool {headers := make(map[string]any)if err := json.Unmarshal([]byte(s), &headers); err != nil {- panic(err)+ return false}v, found := headers[target.Key]diff --git a/apps/checker/pkg/assertions/assertions_test.go b/apps/checker/pkg/assertions/assertions_test.goindex 3aef6300c..cdc19279b 100644--- a/apps/checker/pkg/assertions/assertions_test.go+++ b/apps/checker/pkg/assertions/assertions_test.go@@ -102,6 +102,7 @@ func TestHeaderTarget_HeaderEvaluate(t *testing.T) {}{{name: "Header 1", fields: fields{Comparator: request.StringEmpty, Target: "", Key: "headers1"}, args: args{s: `{"Content-Type":"text/plain;charset=UTF-8","Strict-Transport-Security":"max-age=3153600000","Vary":"Accept-Encoding"}`}, want: false},{name: "Header 2", fields: fields{Comparator: request.StringNotEmpty, Target: "", Key: "headers1"}, args: args{s: `{"Content-Type":"text/plain;charset=UTF-8","Strict-Transport-Security":"max-age=3153600000","headers1":"Accept-Encoding"}`}, want: true},+ {name: "it should return false if it can not decode the headers", fields: fields{Comparator: request.StringContains, Target: "Accept-Encoding", Key: "Vary"}, args: args{s: `}`}, want: false},}for _, tt := range tests {t.Run(tt.name, func(t *testing.T) {