Skip to content

Open-source status page, incident response and uptime monitoring

🚑 (#571)

Thibault Le Ouay711aec90dc26
diff --git a/apps/checker/ping.go b/apps/checker/ping.go
index 4b449d718..9581d90af 100644
--- a/apps/checker/ping.go
+++ b/apps/checker/ping.go
@@ -38,7 +38,9 @@ func Ping(ctx context.Context, client *http.Client, inputData request.CheckerReq
req.Header.Set("User-Agent", "OpenStatus/1.0")
for _, header := range inputData.Headers {
- req.Header.Set(header.Key, header.Value)
+ if header.Key != "" && header.Value != "" {
+ req.Header.Set(header.Key, header.Value)
+ }
}
start := time.Now()
diff --git a/apps/checker/ping_test.go b/apps/checker/ping_test.go
index c0dfe57ab..b55082c1c 100644
--- a/apps/checker/ping_test.go
+++ b/apps/checker/ping_test.go
@@ -19,7 +19,14 @@ func Test_ping(t *testing.T) {
want PingData
wantErr bool
}{
- {name: "200", args: args{client: &http.Client{}, inputData: request.CheckerRequest{URL: "https://openstat.us", CronTimestamp: 1}}, want: PingData{URL: "https://openstat.us", StatusCode: 200}, wantErr: false},
+ {name: "200", args: args{client: &http.Client{}, inputData: request.CheckerRequest{URL: "https://openstat.us", CronTimestamp: 1,Headers:[]struct {
+ Key string `json:"key"`
+ Value string `json:"value"`
+ } {{Key:"", Value:""}}}}, want: PingData{URL: "https://openstat.us", StatusCode: 200}, wantErr: false},
+ {name: "200", args: args{client: &http.Client{}, inputData: request.CheckerRequest{URL: "https://openstat.us", CronTimestamp: 1,Headers:[]struct {
+ Key string `json:"key"`
+ Value string `json:"value"`
+ } {{Key:"", Value:""}}}}, want: PingData{URL: "https://openstat.us", StatusCode: 200}, wantErr: false},
{name: "500", args: args{client: &http.Client{}, inputData: request.CheckerRequest{URL: "https://openstat.us/500", CronTimestamp: 1}}, want: PingData{URL: "https://openstat.us/500", StatusCode: 500}, wantErr: false},
{name: "500", args: args{client: &http.Client{}, inputData: request.CheckerRequest{URL: "https://somethingthatwillfail.ed", CronTimestamp: 1}}, want: PingData{URL: "https://openstat.us/500", StatusCode: 0}, wantErr: true},