Skip to content

Open-source status page, incident response and uptime monitoring

πŸ” Add another retry (#467)

Thibault Le Ouay8af1a6cf173a
diff --git a/apps/server/src/checker/checker.ts b/apps/server/src/checker/checker.ts
index 801560e71..7d60736b7 100644
--- a/apps/server/src/checker/checker.ts
+++ b/apps/server/src/checker/checker.ts
@@ -36,7 +36,7 @@ export const publishPingRetryPolicy = async ({
);
};
-const run = async (data: Payload, retry?: number | undefined) => {
+const run = async (data: Payload, retry: number) => {
let startTime = 0;
let endTime = 0;
let res = null;
@@ -67,11 +67,11 @@ const run = async (data: Payload, retry?: number | undefined) => {
});
}
} else {
- if (retry === 0) {
+ if (retry < 2) {
throw new Error(`error on ping for ${data.monitorId}`);
}
// Store the error on third task retry
- if (retry === 1) {
+ if (retry === 2) {
console.log(
`πŸ› error on fetching data for ${JSON.stringify(
data,
@@ -98,7 +98,9 @@ const run = async (data: Payload, retry?: number | undefined) => {
return { res, latency };
};
-export const checkerRetryPolicy = async (data: Payload, retry = 0) => {
+// We have this extensible retry policy because sometimes we have this error :
+// ConnectionClosed: The socket connection was closed unexpectedly.
+export const checkerRetryPolicy = async (data: Payload) => {
try {
console.log("πŸ₯‡ try run checker - attempt 1 ", JSON.stringify(data));
await run(data, 0);
@@ -107,7 +109,12 @@ export const checkerRetryPolicy = async (data: Payload, retry = 0) => {
console.log("πŸ₯ˆ try run checker - attempt 2 ", JSON.stringify(data));
await run(data, 1);
} catch (e) {
- throw e;
+ try {
+ console.log("πŸ₯‰ try run checker - attempt 3 ", JSON.stringify(data));
+ await run(data, 2);
+ } catch (e) {
+ throw e;
+ }
}
}
console.log("πŸ”₯ successfully run checker ", JSON.stringify(data));
diff --git a/apps/server/src/checker/index.ts b/apps/server/src/checker/index.ts
index 9ca069876..dbdaaaf75 100644
--- a/apps/server/src/checker/index.ts
+++ b/apps/server/src/checker/index.ts
@@ -41,7 +41,7 @@ checkerRoute.post("/checker", async (c) => {
console.log(
`start checker URL: ${result.data.url} monitorId ${result.data.monitorId}`,
);
- await checkerRetryPolicy(result.data, retry);
+ await checkerRetryPolicy(result.data);
console.log(
`end checker URL: ${result.data.url} monitorId ${result.data.monitorId}`,
);
@@ -88,13 +88,9 @@ checkerRoute.post("/checkerV2", async (c) => {
}
try {
- console.log(
- `🧭 start checker URL: ${result.data.url} monitorId ${result.data.monitorId}`,
- );
- await checkerRetryPolicy(result.data, retry);
- console.log(
- `πŸ”š end checker URL: ${result.data.url} monitorId ${result.data.monitorId}`,
- );
+ console.log(`🧭 start checker for: ${JSON.stringify(result.data)}`);
+ await checkerRetryPolicy(result.data);
+ console.log(`πŸ”š end checker for: ${JSON.stringify(result.data)} `);
return c.text("Ok", 200);
} catch (e) {
if (result.data.status === "error") {