Skip to content

Open-source status page, incident response and uptime monitoring

🐛 Bug monitor length (#1005)

Thibault Le Ouay96bbc4b8ca8a
diff --git a/apps/web/src/app/api/checker/cron/_cron.ts b/apps/web/src/app/api/checker/cron/_cron.ts
index 2219d2a4d..1a80dbbe1 100644
--- a/apps/web/src/app/api/checker/cron/_cron.ts
+++ b/apps/web/src/app/api/checker/cron/_cron.ts
@@ -80,10 +80,14 @@ export const cron = async ({
console.log(`Start cron for ${periodicity}`);
- const monitors = z.array(selectMonitorSchema).parse(result);
+ const monitors = z.array(selectMonitorSchema).safeParse(result);
const allResult = [];
+ if (!monitors.success) {
+ console.error(`Error while fetching the monitors ${monitors.error.errors}`);
+ throw new Error("Error while fetching the monitors");
+ }
- for (const row of monitors) {
+ for (const row of monitors.data) {
const selectedRegions = row.regions.length > 0 ? row.regions : ["ams"];
const result = await db
@@ -91,11 +95,17 @@ export const cron = async ({
.from(monitorStatusTable)
.where(eq(monitorStatusTable.monitorId, row.id))
.all();
- const monitorStatus = z.array(selectMonitorStatusSchema).parse(result);
+ const monitorStatus = z.array(selectMonitorStatusSchema).safeParse(result);
+ if (!monitorStatus.success) {
+ console.error(
+ `Error while fetching the monitor status ${monitorStatus.error.errors}`,
+ );
+ continue;
+ }
for (const region of selectedRegions) {
const status =
- monitorStatus.find((m) => region === m.region)?.status || "active";
+ monitorStatus.data.find((m) => region === m.region)?.status || "active";
const response = createCronTask({
row,
timestamp,
diff --git a/packages/db/src/schema/monitors/validation.ts b/packages/db/src/schema/monitors/validation.ts
index 05ac9540b..355f2277b 100644
--- a/packages/db/src/schema/monitors/validation.ts
+++ b/packages/db/src/schema/monitors/validation.ts
@@ -57,7 +57,10 @@ const headersSchema = z
.optional();
export const insertMonitorSchema = createInsertSchema(monitor, {
- name: z.string().min(1, "Name must be at least 1 character long"),
+ name: z
+ .string()
+ .min(1, "Name must be at least 1 character long")
+ .max(255, "Name must be at most 255 characters long"),
periodicity: monitorPeriodicitySchema.default("10m"),
status: monitorStatusSchema.default("active"),
regions: z.array(monitorRegionSchema).default([]).optional(),