Skip to content

Open-source status page, incident response and uptime monitoring

chore(play-checker): validation and console mute (#993)

Maximilian Kaskeac7a45a558d3
diff --git a/apps/web/src/app/play/checker/_components/checker-form.tsx b/apps/web/src/app/play/checker/_components/checker-form.tsx
index b210ddba0..443a09307 100644
--- a/apps/web/src/app/play/checker/_components/checker-form.tsx
+++ b/apps/web/src/app/play/checker/_components/checker-form.tsx
@@ -44,6 +44,7 @@ import {
type RegionChecker,
is32CharHex,
latencyFormatter,
+ regionCheckerSchema,
regionFormatter,
} from "@/components/ping-response-analysis/utils";
import useUpdateSearchParams from "@/hooks/use-update-search-params";
@@ -168,12 +169,14 @@ export function CheckerForm({ defaultValues, defaultData }: CheckerFormProps) {
});
}
} else {
- const parsed = JSON.parse(item) as RegionChecker;
- return parsed;
+ const parsed = JSON.parse(item);
+ const validation =
+ regionCheckerSchema.safeParse(parsed);
+ if (!validation.success) return null;
+ return validation.data;
}
return null;
- } catch (e) {
- console.error(e);
+ } catch (_e) {
return null;
}
})
@@ -195,8 +198,7 @@ export function CheckerForm({ defaultValues, defaultData }: CheckerFormProps) {
}
}
}
- } catch (e) {
- console.log(e);
+ } catch (_e) {
const searchParams = updateSearchParams({ id: null });
router.replace(`${pathname}?${searchParams}`);
toast.error("Something went wrong", {
diff --git a/apps/web/src/components/ping-response-analysis/utils.ts b/apps/web/src/components/ping-response-analysis/utils.ts
index 4c1cd7e54..a9a83dd29 100644
--- a/apps/web/src/components/ping-response-analysis/utils.ts
+++ b/apps/web/src/components/ping-response-analysis/utils.ts
@@ -115,9 +115,13 @@ export const cachedCheckerSchema = z.object({
checks: checkerSchema.extend({ region: monitorFlyRegionSchema }).array(),
});
+export const regionCheckerSchema = checkerSchema.extend({
+ region: monitorFlyRegionSchema,
+});
+
export type Timing = z.infer<typeof timingSchema>;
export type Checker = z.infer<typeof checkerSchema>;
-export type RegionChecker = Checker & { region: MonitorFlyRegion };
+export type RegionChecker = z.infer<typeof regionCheckerSchema>;
export type Method = "GET" | "POST" | "PUT" | "DELETE" | "HEAD";
export type CachedRegionChecker = z.infer<typeof cachedCheckerSchema>;