Open-source status page, incident response and uptime monitoring
TypeScript alertingincident-managementmcpmcp-servermonitoringmonitoring-as-codeobservabilityon-callopen-sourcesrestatus-pagestatuspagesynthetic-monitoringterraformtinybirdtursouptimeuptime-checkeruptime-monitor
fix(private-location): change TCP status from 'active' to 'success' (#2456)
Maxed6b96fa07ce
diff --git a/apps/checker/pkg/job/otel_wiring_test.go b/apps/checker/pkg/job/otel_wiring_test.goindex 84de16c04..1c2bf7437 100644--- a/apps/checker/pkg/job/otel_wiring_test.go+++ b/apps/checker/pkg/job/otel_wiring_test.go@@ -148,7 +148,7 @@ func TestTCPJob_RecordsOTelMetrics(t *testing.T) {data, err := job.NewJobRunner().TCPJob(context.Background(), monitor, "test-region")require.NoError(t, err)- assert.Equal(t, "active", data.RequestStatus)+ assert.Equal(t, "success", data.RequestStatus)otlp.requireMetric(t, "openstatus.status")}diff --git a/apps/checker/pkg/job/tcp_job.go b/apps/checker/pkg/job/tcp_job.goindex ab8324a92..d349e620c 100644--- a/apps/checker/pkg/job/tcp_job.go+++ b/apps/checker/pkg/job/tcp_job.go@@ -81,7 +81,7 @@ func (jobRunner) TCPJob(ctx context.Context, monitor *v1.TCPMonitor, region strilatency := res.TCPDone - res.TCPStartlastResult = checker.TCPResponse{Latency: latency, Timing: res}- var requestStatus = "active"+ var requestStatus = "success"if degradedAfter > 0 && latency > degradedAfter {requestStatus = "degraded"diff --git a/apps/checker/pkg/job/tcp_job_test.go b/apps/checker/pkg/job/tcp_job_test.goindex fb3f4db8c..2fad24eff 100644--- a/apps/checker/pkg/job/tcp_job_test.go+++ b/apps/checker/pkg/job/tcp_job_test.go@@ -19,8 +19,8 @@ func TestTCPJob_Success(t *testing.T) {if err != nil {t.Fatalf("expected no error, got %v", err)}- if data.RequestStatus != "active" {- t.Errorf("expected RequestStatus 'active', got '%s'", data.RequestStatus)+ if data.RequestStatus != "success" {+ t.Errorf("expected RequestStatus 'success', got '%s'", data.RequestStatus)}if data.Error != 0 {t.Errorf("expected Error 0, got %d", data.Error)