Open-source status page, incident response and uptime monitoring
TypeScript alertingincident-managementmcpmcp-servermonitoringmonitoring-as-codeobservabilityon-callopen-sourcesrestatus-pagestatuspagesynthetic-monitoringterraformtinybirdtursouptimeuptime-checkeruptime-monitor
bug maintenance (#1938)
Thibault Le Ouayf4fbc069996f
diff --git a/apps/server/src/routes/slack/interactions.test.ts b/apps/server/src/routes/slack/interactions.test.tsindex 561047b3f..27861e06a 100644--- a/apps/server/src/routes/slack/interactions.test.ts+++ b/apps/server/src/routes/slack/interactions.test.ts@@ -290,3 +290,222 @@ describe("handleSlackInteraction", () => {expect(redisStore.has(`slack:action:${pendingData.id}`)).toBe(false);});});++describe("createMaintenance execution", () => {+ const app = createTestApp();++ beforeEach(() => {+ slackCalls = [];+ redisStore.clear();+ });++ function seedMaintenanceAction(overrides: Record<string, unknown> = {}) {+ const data = {+ id: "maint-001",+ workspaceId: 1,+ limits: {},+ botToken: "xoxb-test",+ channelId: "C1",+ threadTs: "2.1",+ messageTs: "2.2",+ userId: "U_OWNER",+ createdAt: Date.now(),+ action: {+ type: "createMaintenance" as const,+ params: {+ title: "DB Maintenance",+ message: "Scheduled database upgrade.",+ from: new Date(Date.now() + 86400000).toISOString(),+ to: new Date(Date.now() + 86400000 + 3600000).toISOString(),+ pageId: 1,+ ...overrides,+ },+ },+ };+ redisStore.set(`slack:action:${data.id}`, JSON.stringify(data));+ redisStore.set(`slack:thread:${data.threadTs}`, data.id);+ return data;+ }++ test("approve creates maintenance and shows success", async () => {+ seedMaintenanceAction();++ const res = await signAndPost(app, {+ type: "block_actions",+ user: { id: "U_OWNER" },+ channel: { id: "C1" },+ message: { ts: "2.2" },+ team: { id: "T_KNOWN" },+ actions: [{ action_id: "approve_maint-001" }],+ });++ expect(res.status).toBe(200);+ const successCall = slackCalls.find(+ (c) =>+ c.method === "update" &&+ (c.args.text as string).includes(+ "Maintenance *DB Maintenance* scheduled",+ ),+ );+ expect(successCall).toBeDefined();+ expect(successCall?.args.text as string).not.toContain(+ "subscribers notified",+ );+ });++ test("approve_notify creates maintenance and notifies", async () => {+ seedMaintenanceAction();++ const res = await signAndPost(app, {+ type: "block_actions",+ user: { id: "U_OWNER" },+ channel: { id: "C1" },+ message: { ts: "2.2" },+ team: { id: "T_KNOWN" },+ actions: [{ action_id: "approve_notify_maint-001" }],+ });++ expect(res.status).toBe(200);+ const successCall = slackCalls.find(+ (c) =>+ c.method === "update" &&+ (c.args.text as string).includes("subscribers notified"),+ );+ expect(successCall).toBeDefined();+ });++ test("cancel does not create maintenance", async () => {+ seedMaintenanceAction();++ const res = await signAndPost(app, {+ type: "block_actions",+ user: { id: "U_OWNER" },+ channel: { id: "C1" },+ message: { ts: "2.2" },+ team: { id: "T_KNOWN" },+ actions: [{ action_id: "cancel_maint-001" }],+ });++ expect(res.status).toBe(200);+ const cancelCall = slackCalls.find(+ (c) =>+ c.method === "update" && (c.args.text as string).includes("Cancelled"),+ );+ expect(cancelCall).toBeDefined();+ });++ test("shows error for invalid page id", async () => {+ seedMaintenanceAction({ pageId: 99999 });++ const res = await signAndPost(app, {+ type: "block_actions",+ user: { id: "U_OWNER" },+ channel: { id: "C1" },+ message: { ts: "2.2" },+ team: { id: "T_KNOWN" },+ actions: [{ action_id: "approve_maint-001" }],+ });++ expect(res.status).toBe(200);+ const errorCall = slackCalls.find(+ (c) =>+ c.method === "update" &&+ (c.args.text as string).includes("Something went wrong"),+ );+ expect(errorCall).toBeDefined();+ });++ test("shows error when from is after to", async () => {+ const now = Date.now();+ seedMaintenanceAction({+ from: new Date(now + 7200000).toISOString(),+ to: new Date(now + 3600000).toISOString(),+ });++ const res = await signAndPost(app, {+ type: "block_actions",+ user: { id: "U_OWNER" },+ channel: { id: "C1" },+ message: { ts: "2.2" },+ team: { id: "T_KNOWN" },+ actions: [{ action_id: "approve_maint-001" }],+ });++ expect(res.status).toBe(200);+ const errorCall = slackCalls.find(+ (c) =>+ c.method === "update" &&+ (c.args.text as string).includes("Something went wrong"),+ );+ expect(errorCall).toBeDefined();+ });++ test("creates maintenance with page components", async () => {+ seedMaintenanceAction({ pageComponentIds: ["1", "2"] });++ const res = await signAndPost(app, {+ type: "block_actions",+ user: { id: "U_OWNER" },+ channel: { id: "C1" },+ message: { ts: "2.2" },+ team: { id: "T_KNOWN" },+ actions: [{ action_id: "approve_maint-001" }],+ });++ expect(res.status).toBe(200);+ const successCall = slackCalls.find(+ (c) =>+ c.method === "update" &&+ (c.args.text as string).includes(+ "Maintenance *DB Maintenance* scheduled",+ ),+ );+ expect(successCall).toBeDefined();+ });++ test("shows error for invalid page component ids", async () => {+ seedMaintenanceAction({ pageComponentIds: ["99999"] });++ const res = await signAndPost(app, {+ type: "block_actions",+ user: { id: "U_OWNER" },+ channel: { id: "C1" },+ message: { ts: "2.2" },+ team: { id: "T_KNOWN" },+ actions: [{ action_id: "approve_maint-001" }],+ });++ expect(res.status).toBe(200);+ const errorCall = slackCalls.find(+ (c) =>+ c.method === "update" &&+ (c.args.text as string).includes("Something went wrong"),+ );+ expect(errorCall).toBeDefined();+ });++ test("does not leak internal error details to user", async () => {+ seedMaintenanceAction({ pageId: 99999 });++ await signAndPost(app, {+ type: "block_actions",+ user: { id: "U_OWNER" },+ channel: { id: "C1" },+ message: { ts: "2.2" },+ team: { id: "T_KNOWN" },+ actions: [{ action_id: "approve_maint-001" }],+ });++ const errorCall = slackCalls.find(+ (c) =>+ c.method === "update" &&+ (c.args.text as string).includes("Something went wrong"),+ );+ expect(errorCall).toBeDefined();+ const text = errorCall?.args.text as string;+ expect(text).not.toContain("Page 99999");+ expect(text).not.toContain("ConnectError");+ expect(text).not.toContain("select");+ expect(text).not.toContain("query");+ });+});diff --git a/apps/server/src/routes/slack/interactions.ts b/apps/server/src/routes/slack/interactions.tsindex 973e5e673..a4b9531a2 100644--- a/apps/server/src/routes/slack/interactions.ts+++ b/apps/server/src/routes/slack/interactions.ts@@ -1,18 +1,15 @@-import { db, eq } from "@openstatus/db";+import { and, db, eq, inArray } from "@openstatus/db";import {maintenance,+ maintenancesToPageComponents,page,+ pageComponent,statusReport,statusReportUpdate,} from "@openstatus/db/src/schema";import { WebClient } from "@slack/web-api";import type { Context } from "hono";-import {- sendMaintenanceNotification,- updatePageComponentAssociations as updateMaintenanceComponentAssociations,- validatePageComponentIds as validateMaintenanceComponentIds,- validatePageExists,-} from "../rpc/services/maintenance";+import { sendMaintenanceNotification } from "../rpc/services/maintenance";import {getStatusReportById,sendStatusReportNotification,@@ -400,23 +397,59 @@ async function executeAction(}const newMaintenance = await db.transaction(async (tx) => {- await validatePageExists(maintenancePageId, workspaceId, tx);+ const pageRecord = await tx+ .select({ id: page.id })+ .from(page)+ .where(+ and(+ eq(page.id, maintenancePageId),+ eq(page.workspaceId, workspaceId),+ ),+ )+ .get();++ if (!pageRecord) {+ throw new Error(+ `Page ${maintenancePageId} not found in this workspace`,+ );+ }- const validated = maintenanceComponentIds?.length- ? await validateMaintenanceComponentIds(- maintenanceComponentIds,- workspaceId,- tx,+ let componentIds: number[] = [];+ if (maintenanceComponentIds?.length) {+ const numericIds = maintenanceComponentIds.map((id) => Number(id));+ const validComponents = await tx+ .select({ id: pageComponent.id, pageId: pageComponent.pageId })+ .from(pageComponent)+ .where(+ and(+ inArray(pageComponent.id, numericIds),+ eq(pageComponent.workspaceId, workspaceId),+ ),)- : { componentIds: [], pageId: null };+ .all();- if (- validated.pageId !== null &&- validated.pageId !== maintenancePageId- ) {- throw new Error(- `pageId ${maintenancePageId} does not match the page (${validated.pageId}) that the selected components belong to`,+ if (validComponents.length !== numericIds.length) {+ throw new Error("One or more page components not found");+ }++ const componentPageIds = new Set(+ validComponents.map((c) => c.pageId),);+ if (componentPageIds.size > 1) {+ throw new Error("All components must belong to the same page");+ }++ const componentPageId = validComponents[0]?.pageId;+ if (+ componentPageId !== null &&+ componentPageId !== maintenancePageId+ ) {+ throw new Error(+ `pageId ${maintenancePageId} does not match the page (${componentPageId}) that the selected components belong to`,+ );+ }++ componentIds = numericIds;}const record = await tx@@ -432,11 +465,12 @@ async function executeAction(.returning().get();- if (validated.componentIds.length > 0) {- await updateMaintenanceComponentAssociations(- record.id,- validated.componentIds,- tx,+ if (componentIds.length > 0) {+ await tx.insert(maintenancesToPageComponents).values(+ componentIds.map((pageComponentId) => ({+ maintenanceId: record.id,+ pageComponentId,+ })),);}