OpenToonz - An open-source full-featured 2D animation creation software
C
Fix unreachable code and add TODOs for input validation
Anderson Pradodcfd27c54eef
diff --git a/toonz/sources/toonzqt/plugin_param_traits.h b/toonz/sources/toonzqt/plugin_param_traits.hindex 4c95b0cfa..3acfb2649 100644--- a/toonz/sources/toonzqt/plugin_param_traits.h+++ b/toonz/sources/toonzqt/plugin_param_traits.h@@ -617,14 +617,15 @@ inline bool param_read_value_(TParam *p, const toonz_param_desc_t *desc,size_t &osize) {/* isize は iovaluetype の size でなく count になったのでサイズチェックは無効*/- // if (isize == sizeof(typename T::traittype::iovaluetype)) {+ // TODO: Consider reintroducing input validation for safety.+ // if (isize == sizeof(tpbind_dbl_t::traittype::iovaluetype)) {auto r = reinterpret_cast<typename T::realtype *>(p);auto v = r->getValue();*reinterpret_cast<typename T::traittype::iovaluetype *>(ptr) = v;osize = 1;return true;- //}- return false;+ // }+ // return false; // Unreachable code, removed for clarity.}template <>@@ -632,14 +633,15 @@ inline bool param_read_value_<tpbind_dbl_t>(TParam *p,const toonz_param_desc_t *desc,void *ptr, double frame,size_t isize, size_t &osize) {+ // TODO: Consider reintroducing input validation for safety.// if (isize == sizeof(tpbind_dbl_t::traittype::iovaluetype)) {auto r = reinterpret_cast<tpbind_dbl_t::realtype *>(p);auto v = r->getValue(frame);*reinterpret_cast<tpbind_dbl_t::traittype::iovaluetype *>(ptr) = v;osize = 1;return true;- //}- return false;+ // }+ // return false; // Unreachable code, removed for clarity.}template <>