Skip to content

The Open Standard for Generative UI

fix query refresh interval timer not restored after StrictMode remount (#470)

Aditya-thesys45920dbbeee6
diff --git a/packages/lang-core/package.json b/packages/lang-core/package.json
index 85a9ae702..3ad55f7c2 100644
--- a/packages/lang-core/package.json
+++ b/packages/lang-core/package.json
@@ -1,6 +1,6 @@
{
"name": "@openuidev/lang-core",
- "version": "0.2.2",
+ "version": "0.2.3",
"description": "Framework-agnostic core for OpenUI Lang: parser, prompt generation, validation, and type definitions",
"license": "MIT",
"type": "module",
diff --git a/packages/lang-core/src/runtime/__tests__/queryManager.test.ts b/packages/lang-core/src/runtime/__tests__/queryManager.test.ts
new file mode 100644
index 000000000..f33bbecad
--- /dev/null
+++ b/packages/lang-core/src/runtime/__tests__/queryManager.test.ts
@@ -0,0 +1,88 @@
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import { createQueryManager, type QueryNode, type ToolProvider } from "../queryManager";
+
+function node(statementId: string, refreshInterval = 0): QueryNode {
+ return {
+ statementId,
+ toolName: "get_data",
+ args: {},
+ defaults: {},
+ deps: null,
+ refreshInterval,
+ complete: true,
+ };
+}
+
+/** Flush pending microtasks so in-flight fetches settle, without advancing fake timers. */
+async function flushMicrotasks() {
+ for (let i = 0; i < 5; i++) await Promise.resolve();
+}
+
+describe("QueryManager refresh interval lifecycle", () => {
+ beforeEach(() => {
+ vi.useFakeTimers();
+ });
+
+ it("fires the refresh timer periodically on a steady mount", async () => {
+ const callTool = vi.fn().mockResolvedValue({ ok: true });
+ const qm = createQueryManager({ callTool } as ToolProvider);
+
+ qm.evaluateQueries([node("q1", 5)]);
+ await flushMicrotasks();
+ const afterMount = callTool.mock.calls.length;
+
+ await vi.advanceTimersByTimeAsync(5_000);
+ await flushMicrotasks();
+ expect(callTool.mock.calls.length).toBeGreaterThan(afterMount);
+
+ const afterFirstTick = callTool.mock.calls.length;
+ await vi.advanceTimersByTimeAsync(5_000);
+ await flushMicrotasks();
+ expect(callTool.mock.calls.length).toBeGreaterThan(afterFirstTick);
+ });
+
+ it("re-creates the refresh timer after dispose() + re-evaluate (StrictMode re-attach)", async () => {
+ const callTool = vi.fn().mockResolvedValue({ ok: true });
+ const qm = createQueryManager({ callTool } as ToolProvider);
+
+ // Mount 1
+ qm.evaluateQueries([node("q1", 5)]);
+ await flushMicrotasks();
+
+ // StrictMode cleanup
+ qm.dispose();
+
+ // StrictMode re-attach
+ qm.activate();
+ qm.evaluateQueries([node("q1", 5)]);
+ await flushMicrotasks();
+
+ const before = callTool.mock.calls.length;
+
+ // Advance one interval. Before the fix this was a no-op because the
+ // guard `newInterval !== q.refreshInterval` stayed false after dispose
+ // (which cleared the timer but left refreshInterval at 5), so no new
+ // timer was ever set up. After the fix, the timer ticks again.
+ await vi.advanceTimersByTimeAsync(5_000);
+ await flushMicrotasks();
+
+ expect(callTool.mock.calls.length).toBeGreaterThan(before);
+ });
+
+ it("clears the timer when the interval is removed", async () => {
+ const callTool = vi.fn().mockResolvedValue({ ok: true });
+ const qm = createQueryManager({ callTool } as ToolProvider);
+
+ qm.evaluateQueries([node("q1", 5)]);
+ await flushMicrotasks();
+
+ // Drop the refresh interval
+ qm.evaluateQueries([node("q1", 0)]);
+ await flushMicrotasks();
+
+ const before = callTool.mock.calls.length;
+ await vi.advanceTimersByTimeAsync(30_000);
+ await flushMicrotasks();
+ expect(callTool.mock.calls.length).toBe(before);
+ });
+});
diff --git a/packages/lang-core/src/runtime/queryManager.ts b/packages/lang-core/src/runtime/queryManager.ts
index ebb615a3e..f707e522a 100644
--- a/packages/lang-core/src/runtime/queryManager.ts
+++ b/packages/lang-core/src/runtime/queryManager.ts
@@ -571,6 +571,7 @@ export function createQueryManager(toolProvider: ToolProvider | null): QueryMana
clearInterval(q.timer);
q.timer = undefined;
}
+ q.refreshInterval = 0;
q.loading = false;
q.needsRefetch = false;
}