Skip to content

The Open Standard for Generative UI

typography updates and semicircle fix (#482)

Prakhar5b7390c0e1e7
diff --git a/packages/react-ui/src/components/Charts/PieChart/PieChart.tsx b/packages/react-ui/src/components/Charts/PieChart/PieChart.tsx
index d37090abd..da669c8a6 100644
--- a/packages/react-ui/src/components/Charts/PieChart/PieChart.tsx
+++ b/packages/react-ui/src/components/Charts/PieChart/PieChart.tsx
@@ -12,6 +12,7 @@ import { getCategoricalChartConfig } from "../utils/dataUtils.js";
import { PaletteName, useChartPalette } from "../utils/PalletUtils.js";
import { PieChartData } from "./types/index.js";
import {
+ calculateChartDimensions,
calculateTwoLevelChartDimensions,
createAnimationConfig,
createEventHandlers,
@@ -127,7 +128,15 @@ const PieChartComponent = <T extends PieChartData>({
return Math.max(minChartSize, size);
}, [effectiveWidth, effectiveHeight, isRowLayout]);
- const chartSizeStyle = useMemo(() => ({ width: chartSize, height: chartSize }), [chartSize]);
+ const isSemiCircular = appearance === "semiCircular";
+ const chartViewportHeight = useMemo(
+ () => (isSemiCircular ? Math.max(1, Math.ceil(chartSize / 2)) : chartSize),
+ [chartSize, isSemiCircular],
+ );
+ const chartSizeStyle = useMemo(
+ () => ({ width: chartSize, height: chartViewportHeight }),
+ [chartSize, chartViewportHeight],
+ );
const rechartsProps = useMemo(
() => ({
width: "100%",
@@ -263,8 +272,11 @@ const PieChartComponent = <T extends PieChartData>({
if (variant === "donut") {
return calculateTwoLevelChartDimensions(chartSize);
}
+ if (isSemiCircular) {
+ return { ...calculateChartDimensions(chartSize, variant), middleRadius: 0 };
+ }
return { outerRadius: "90%", innerRadius: 0, middleRadius: 0 };
- }, [variant, chartSize]);
+ }, [variant, chartSize, isSemiCircular]);
const startAngle = useMemo(() => (appearance === "semiCircular" ? 180 : 0), [appearance]);
const endAngle = useMemo(() => (appearance === "semiCircular" ? 0 : 360), [appearance]);
@@ -281,6 +293,8 @@ const PieChartComponent = <T extends PieChartData>({
...sectorStyle,
startAngle,
endAngle,
+ cx: "50%",
+ cy: isSemiCircular ? chartViewportHeight : "50%",
onMouseEnter: handleChartMouseEnter,
onMouseLeave: handleChartMouseLeave,
}),
@@ -293,6 +307,8 @@ const PieChartComponent = <T extends PieChartData>({
sectorStyle,
startAngle,
endAngle,
+ isSemiCircular,
+ chartViewportHeight,
handleChartMouseEnter,
handleChartMouseLeave,
],
diff --git a/packages/react-ui/src/components/ThemeProvider/defaultTheme.ts b/packages/react-ui/src/components/ThemeProvider/defaultTheme.ts
index 47ed06188..a9a71b936 100644
--- a/packages/react-ui/src/components/ThemeProvider/defaultTheme.ts
+++ b/packages/react-ui/src/components/ThemeProvider/defaultTheme.ts
@@ -245,12 +245,12 @@ const createColorTheme = ({
interactiveDestructiveAccentDisabled: withAlpha(swatch(dangerSwatch, 600), 0.4),
// Chat
- chatUserResponseBg: brandSolid,
- chatUserResponseText: accentText,
+ chatUserResponseBg: withAlpha(brandSolid, 0.08),
+ chatUserResponseText: neutralPrimary,
// Border
- borderDefault: withAlpha(overlayBase, isDark ? 0.12 : 0.06),
- borderInteractive: withAlpha(overlayBase, isDark ? 0.2 : 0.12),
+ borderDefault: withAlpha(overlayBase, isDark ? 0.06 : 0.06),
+ borderInteractive: withAlpha(overlayBase, isDark ? 0.12 : 0.12),
borderInteractiveEmphasis: withAlpha(overlayBase, isDark ? 0.4 : 0.3),
borderInteractiveSelected: isDark ? swatch(neutral, 50) : swatch(neutral, 1000),
borderAccent: withAlpha(brandSolid, isDark ? 0.2 : 0.08),
@@ -429,6 +429,14 @@ const typographyTheme: TypographyTheme = {
textNumbersLgLetterSpacing: "0",
textNumbersLgHeavy: `500 18px/1.5 ${FONT_NUMBERS}`,
textNumbersLgHeavyLetterSpacing: "0",
+ textNumbersHeadingSm: `600 18px/1.25 ${FONT_NUMBERS}`,
+ textNumbersHeadingSmLetterSpacing: "0",
+ textNumbersHeadingMd: `600 24px/1.1 ${FONT_NUMBERS}`,
+ textNumbersHeadingMdLetterSpacing: "0",
+ textNumbersHeadingLg: `600 28px/1.1 ${FONT_NUMBERS}`,
+ textNumbersHeadingLgLetterSpacing: "0",
+ textNumbersHeadingXl: `600 32px/1.1 ${FONT_NUMBERS}`,
+ textNumbersHeadingXlLetterSpacing: "0",
// Code
textCodeSm: `400 12px/1.5 ${FONT_CODE}`,
diff --git a/packages/react-ui/src/components/ThemeProvider/types.ts b/packages/react-ui/src/components/ThemeProvider/types.ts
index b64c87805..18a6328e8 100644
--- a/packages/react-ui/src/components/ThemeProvider/types.ts
+++ b/packages/react-ui/src/components/ThemeProvider/types.ts
@@ -280,6 +280,14 @@ export interface TypographyTheme {
textNumbersLgLetterSpacing?: string;
textNumbersLgHeavy?: string;
textNumbersLgHeavyLetterSpacing?: string;
+ textNumbersHeadingSm?: string;
+ textNumbersHeadingSmLetterSpacing?: string;
+ textNumbersHeadingMd?: string;
+ textNumbersHeadingMdLetterSpacing?: string;
+ textNumbersHeadingLg?: string;
+ textNumbersHeadingLgLetterSpacing?: string;
+ textNumbersHeadingXl?: string;
+ textNumbersHeadingXlLetterSpacing?: string;
// Compound typography: code
textCodeSm?: string;
diff --git a/packages/react-ui/src/cssUtils.scss b/packages/react-ui/src/cssUtils.scss
index df517cb2c..eed2417f2 100644
--- a/packages/react-ui/src/cssUtils.scss
+++ b/packages/react-ui/src/cssUtils.scss
@@ -214,6 +214,14 @@ $text-numbers-lg: var(--openui-text-numbers-lg);
$text-numbers-lg-letter-spacing: var(--openui-text-numbers-lg-letter-spacing);
$text-numbers-lg-heavy: var(--openui-text-numbers-lg-heavy);
$text-numbers-lg-heavy-letter-spacing: var(--openui-text-numbers-lg-heavy-letter-spacing);
+$text-numbers-heading-sm: var(--openui-text-numbers-heading-sm);
+$text-numbers-heading-sm-letter-spacing: var(--openui-text-numbers-heading-sm-letter-spacing);
+$text-numbers-heading-md: var(--openui-text-numbers-heading-md);
+$text-numbers-heading-md-letter-spacing: var(--openui-text-numbers-heading-md-letter-spacing);
+$text-numbers-heading-lg: var(--openui-text-numbers-heading-lg);
+$text-numbers-heading-lg-letter-spacing: var(--openui-text-numbers-heading-lg-letter-spacing);
+$text-numbers-heading-xl: var(--openui-text-numbers-heading-xl);
+$text-numbers-heading-xl-letter-spacing: var(--openui-text-numbers-heading-xl-letter-spacing);
$text-code-sm: var(--openui-text-code-sm);
$text-code-sm-letter-spacing: var(--openui-text-code-sm-letter-spacing);
$text-code-sm-heavy: var(--openui-text-code-sm-heavy);
@@ -265,6 +273,7 @@ $typography: (
2-extra-small-heavy: typography(openui-text-label-xs-heavy),
),
heading: (
+ xl: typography(openui-text-heading-xl),
large: typography(openui-text-heading-lg),
medium: typography(openui-text-heading-md),
small: typography(openui-text-heading-sm),
@@ -279,8 +288,11 @@ $typography: (
small-heavy: typography(openui-text-numbers-sm-heavy),
extra-small: typography(openui-text-numbers-xs),
extra-small-heavy: typography(openui-text-numbers-xs-heavy),
- title: typography(openui-text-heading-lg),
- title-medium: typography(openui-text-heading-md),
+ heading: typography(openui-text-numbers-heading-lg),
+ heading-small: typography(openui-text-numbers-heading-sm),
+ heading-medium: typography(openui-text-numbers-heading-md),
+ heading-large: typography(openui-text-numbers-heading-lg),
+ heading-xl: typography(openui-text-numbers-heading-xl),
),
code: (
default: typography(openui-text-code-default),
diff --git a/packages/react-ui/src/openui-defaults.scss b/packages/react-ui/src/openui-defaults.scss
index ae05f31a2..54ea9b90b 100644
--- a/packages/react-ui/src/openui-defaults.scss
+++ b/packages/react-ui/src/openui-defaults.scss
@@ -72,8 +72,8 @@
// Chat Colors
- --openui-chat-user-response-bg: oklch(0.097 0 0 / 1);
- --openui-chat-user-response-text: oklch(0.994 0 89.876 / 1);
+ --openui-chat-user-response-bg: oklch(0.097 0 0 / 0.08);
+ --openui-chat-user-response-text: oklch(0.097 0 0 / 1);
// Border Colors
@@ -214,6 +214,14 @@
--openui-text-numbers-lg-letter-spacing: 0;
--openui-text-numbers-lg-heavy: 500 18px/1.5 "Inter", sans-serif;
--openui-text-numbers-lg-heavy-letter-spacing: 0;
+ --openui-text-numbers-heading-sm: 600 18px/1.25 "Inter", sans-serif;
+ --openui-text-numbers-heading-sm-letter-spacing: 0;
+ --openui-text-numbers-heading-md: 600 24px/1.1 "Inter", sans-serif;
+ --openui-text-numbers-heading-md-letter-spacing: 0;
+ --openui-text-numbers-heading-lg: 600 28px/1.1 "Inter", sans-serif;
+ --openui-text-numbers-heading-lg-letter-spacing: 0;
+ --openui-text-numbers-heading-xl: 700 32px/1.1 "Inter", sans-serif;
+ --openui-text-numbers-heading-xl-letter-spacing: 0;
--openui-text-code-sm: 400 12px/1.5 "SFMono-Regular", Menlo, monospace;
--openui-text-code-sm-letter-spacing: 0;
--openui-text-code-sm-heavy: 700 12px/1.5 "SFMono-Regular", Menlo, monospace;
@@ -308,13 +316,13 @@
// Chat Colors
- --openui-chat-user-response-bg: oklch(0.994 0 89.876 / 1);
- --openui-chat-user-response-text: oklch(0.097 0 0 / 1);
+ --openui-chat-user-response-bg: oklch(0.994 0 89.876 / 0.08);
+ --openui-chat-user-response-text: oklch(0.985 0 89.876 / 1);
// Border Colors
- --openui-border-default: oklch(0.994 0 89.876 / 0.12);
- --openui-border-interactive: oklch(0.994 0 89.876 / 0.2);
+ --openui-border-default: oklch(0.994 0 89.876 / 0.06);
+ --openui-border-interactive: oklch(0.994 0 89.876 / 0.12);
--openui-border-interactive-emphasis: oklch(0.994 0 89.876 / 0.4);
--openui-border-interactive-selected: oklch(0.985 0 89.876 / 1);
--openui-border-accent: oklch(0.994 0 89.876 / 0.2);
@@ -450,6 +458,14 @@
--openui-text-numbers-lg-letter-spacing: 0;
--openui-text-numbers-lg-heavy: 500 18px/1.5 "Inter", sans-serif;
--openui-text-numbers-lg-heavy-letter-spacing: 0;
+ --openui-text-numbers-heading-sm: 600 18px/1.25 "Inter", sans-serif;
+ --openui-text-numbers-heading-sm-letter-spacing: 0;
+ --openui-text-numbers-heading-md: 600 24px/1.1 "Inter", sans-serif;
+ --openui-text-numbers-heading-md-letter-spacing: 0;
+ --openui-text-numbers-heading-lg: 600 28px/1.1 "Inter", sans-serif;
+ --openui-text-numbers-heading-lg-letter-spacing: 0;
+ --openui-text-numbers-heading-xl: 700 32px/1.1 "Inter", sans-serif;
+ --openui-text-numbers-heading-xl-letter-spacing: 0;
--openui-text-code-sm: 400 12px/1.5 "SFMono-Regular", Menlo, monospace;
--openui-text-code-sm-letter-spacing: 0;
--openui-text-code-sm-heavy: 700 12px/1.5 "SFMono-Regular", Menlo, monospace;
diff --git a/packages/react-ui/src/scripts/generate-css-utils.ts b/packages/react-ui/src/scripts/generate-css-utils.ts
index efb4d193e..b4d6d2a1b 100644
--- a/packages/react-ui/src/scripts/generate-css-utils.ts
+++ b/packages/react-ui/src/scripts/generate-css-utils.ts
@@ -76,6 +76,7 @@ $typography: (
2-extra-small-heavy: typography(openui-text-label-xs-heavy),
),
heading: (
+ xl: typography(openui-text-heading-xl),
large: typography(openui-text-heading-lg),
medium: typography(openui-text-heading-md),
small: typography(openui-text-heading-sm),
@@ -90,8 +91,11 @@ $typography: (
small-heavy: typography(openui-text-numbers-sm-heavy),
extra-small: typography(openui-text-numbers-xs),
extra-small-heavy: typography(openui-text-numbers-xs-heavy),
- title: typography(openui-text-heading-lg),
- title-medium: typography(openui-text-heading-md),
+ heading: typography(openui-text-numbers-heading-lg),
+ heading-small: typography(openui-text-numbers-heading-sm),
+ heading-medium: typography(openui-text-numbers-heading-md),
+ heading-large: typography(openui-text-numbers-heading-lg),
+ heading-xl: typography(openui-text-numbers-heading-xl),
),
code: (
default: typography(openui-text-code-default),