Skip to content

The Open Standard for Generative UI

Refactoring Component

i-subham6093acb785cb
diff --git a/frontend-sdk/packages/react-ui/src/components/Accordion/Accordion.tsx b/frontend-sdk/packages/react-ui/src/components/Accordion/Accordion.tsx
index c0256f46d..937e94cd5 100644
--- a/frontend-sdk/packages/react-ui/src/components/Accordion/Accordion.tsx
+++ b/frontend-sdk/packages/react-ui/src/components/Accordion/Accordion.tsx
@@ -58,7 +58,7 @@ export const AccordionTrigger = forwardRef<
{...props}
>
<div className="crayon-accordion-trigger-content">
- {icon}
+ {icon && <span className="crayon-accordion-trigger-content-icon">{icon}</span>}
{text}
</div>
<ChevronDownIcon className="crayon-accordion-trigger-icon" />
diff --git a/frontend-sdk/packages/react-ui/src/components/Accordion/accordion.scss b/frontend-sdk/packages/react-ui/src/components/Accordion/accordion.scss
index f687232c0..b050e85e2 100644
--- a/frontend-sdk/packages/react-ui/src/components/Accordion/accordion.scss
+++ b/frontend-sdk/packages/react-ui/src/components/Accordion/accordion.scss
@@ -6,116 +6,116 @@
border-radius: 6px;
box-shadow: map.get(cssUtils.$shadow, "m");
border: 1px solid map.get(cssUtils.$colors, "strokes", "default");
-}
-.crayon-accordion-item {
- box-sizing: border-box;
- overflow: hidden;
- border-bottom: 1px solid map.get(cssUtils.$colors, "strokes", "default");
+ &-item {
+ box-sizing: border-box;
+ overflow: hidden;
+ border-bottom: 1px solid map.get(cssUtils.$colors, "strokes", "default");
- &-card {
- .crayon-accordion-content {
- &-wrapper {
- padding: map.get(cssUtils.$spacing, "l");
- gap: map.get(cssUtils.$spacing, "l");
+ &-card {
+ .crayon-accordion-content {
+ &-wrapper {
+ padding: map.get(cssUtils.$spacing, "l");
+ gap: map.get(cssUtils.$spacing, "l");
+ }
}
}
- }
- &-sunk {
- .crayon-accordion-trigger {
- background-color: map.get(cssUtils.$colors, "fills", "sunk");
- }
+ &-sunk {
+ .crayon-accordion-trigger {
+ background-color: map.get(cssUtils.$colors, "fills", "sunk");
+ }
- .crayon-accordion-content {
- background-color: map.get(cssUtils.$colors, "fills", "sunk");
+ .crayon-accordion-content {
+ background-color: map.get(cssUtils.$colors, "fills", "sunk");
- &-wrapper {
- padding: map.get(cssUtils.$spacing, "l");
- gap: map.get(cssUtils.$spacing, "l");
+ &-wrapper {
+ padding: map.get(cssUtils.$spacing, "l");
+ gap: map.get(cssUtils.$spacing, "l");
+ }
}
}
+ &:first-child {
+ margin-top: 0;
+ border-top-left-radius: 4px;
+ border-top-right-radius: 4px;
+ }
+ &:last-child {
+ border-bottom-left-radius: 4px;
+ border-bottom-right-radius: 4px;
+ border-bottom: none;
+ }
+ &:focus-within {
+ position: relative;
+ z-index: 1;
+ }
}
- &:first-child {
- margin-top: 0;
- border-top-left-radius: 4px;
- border-top-right-radius: 4px;
- }
- &:last-child {
- border-bottom-left-radius: 4px;
- border-bottom-right-radius: 4px;
- border-bottom: none;
- }
- &:focus-within {
- position: relative;
- z-index: 1;
+ &-header {
+ display: flex;
+ margin-block-start: 0;
+ margin-block-end: 0;
+ margin-inline-start: 0;
+ margin-inline-end: 0;
}
-}
-
-.crayon-accordion-header {
- display: flex;
- margin-block-start: 0;
- margin-block-end: 0;
- margin-inline-start: 0;
- margin-inline-end: 0;
-}
-
-.crayon-accordion-trigger {
- border: none;
- box-sizing: border-box;
- @include cssUtils.typography("body", "default");
- background-color: transparent;
- padding: map.get(cssUtils.$spacing, "s");
- width: 100%;
- flex: 1;
- display: flex;
- align-items: center;
- justify-content: space-between;
- color: map.get(cssUtils.$colors, "text", "primary");
- box-shadow: map.get(cssUtils.$shadow, "m");
-
- &-content {
+ &-trigger {
+ border: none;
+ box-sizing: border-box;
+ @include cssUtils.typography("body", "default");
+ background-color: transparent;
+ padding: map.get(cssUtils.$spacing, "s");
+ width: 100%;
+ flex: 1;
display: flex;
align-items: center;
+ justify-content: space-between;
color: map.get(cssUtils.$colors, "text", "primary");
- gap: map.get(cssUtils.$spacing, "xs");
- svg {
+ box-shadow: map.get(cssUtils.$shadow, "m");
+
+ &-content {
+ display: flex;
+ align-items: center;
+ color: map.get(cssUtils.$colors, "text", "primary");
+ gap: map.get(cssUtils.$spacing, "xs");
+ &-icon {
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ height: 14px;
+ width: 14px;
+ }
+ }
+
+ &-icon {
+ color: map.get(cssUtils.$colors, "text", "primary");
+ @include cssUtils.typography("primary", "default");
height: 14px;
width: 14px;
+ transition: transform 300ms cubic-bezier(0.87, 0, 0.13, 1);
}
- }
-
- &-icon {
- color: map.get(cssUtils.$colors, "text", "primary");
- @include cssUtils.typography("primary", "default");
- height: 14px;
- width: 14px;
- transition: transform 300ms cubic-bezier(0.87, 0, 0.13, 1);
- }
- &[data-state="open"] {
- .crayon-accordion-trigger-icon {
- transform: rotate(180deg);
+ &[data-state="open"] {
+ .crayon-accordion-trigger-icon {
+ transform: rotate(180deg);
+ }
}
}
-}
-
-.crayon-accordion-content {
- overflow: hidden;
- color: map.get(cssUtils.$colors, "fills", "text");
- @include cssUtils.typography("body", "default");
+ &-content {
+ overflow: hidden;
+ color: map.get(cssUtils.$colors, "fills", "text");
+ @include cssUtils.typography("body", "default");
- &[data-state="open"] {
- animation: slideDown 300ms cubic-bezier(0.87, 0, 0.13, 1);
- }
- &[data-state="closed"] {
- animation: slideUp 300ms cubic-bezier(0.87, 0, 0.13, 1);
- }
- &-wrapper {
- box-sizing: border-box;
- display: flex;
- flex-direction: column;
- padding: map.get(cssUtils.$spacing, "l");
- gap: map.get(cssUtils.$spacing, "l");
+ &[data-state="open"] {
+ animation: slideDown 300ms cubic-bezier(0.87, 0, 0.13, 1);
+ }
+ &[data-state="closed"] {
+ animation: slideUp 300ms cubic-bezier(0.87, 0, 0.13, 1);
+ }
+ &-wrapper {
+ box-sizing: border-box;
+ display: flex;
+ flex-direction: column;
+ padding: map.get(cssUtils.$spacing, "l");
+ gap: map.get(cssUtils.$spacing, "l");
+ }
}
}
diff --git a/frontend-sdk/packages/react-ui/src/components/Header/Header.tsx b/frontend-sdk/packages/react-ui/src/components/Header/Header.tsx
index 817ee17ed..661df3ea8 100644
--- a/frontend-sdk/packages/react-ui/src/components/Header/Header.tsx
+++ b/frontend-sdk/packages/react-ui/src/components/Header/Header.tsx
@@ -7,7 +7,7 @@ export interface HeaderProps {
icon?: React.ReactNode;
title?: React.ReactNode;
subtitle?: React.ReactNode;
- actions:
+ actions?:
| React.ReactElement<typeof Button | typeof IconButton>
| React.ReactElement<typeof Button | typeof IconButton>[];
className?: string;
@@ -20,10 +20,14 @@ export const Header = forwardRef<HTMLDivElement, HeaderProps>((props, ref) => {
<div ref={ref} className={clsx("crayon-header", className)} style={styles} {...rest}>
<div className="crayon-header-top">
<div className="crayon-header-top-left">
- {icon}
+ {icon && <span className="crayon-header-top-left-icon">{icon}</span>}
{title}
</div>
- <div className="crayon-header-top-right">{actions}</div>
+ <div className="crayon-header-top-right">
+ {Array.isArray(actions)
+ ? actions.map((action, index) => React.cloneElement(action, { key: index }))
+ : actions}
+ </div>
</div>
<div className="crayon-header-bottom">{subtitle}</div>
</div>
diff --git a/frontend-sdk/packages/react-ui/src/components/Header/header.scss b/frontend-sdk/packages/react-ui/src/components/Header/header.scss
index 8f7e5771c..7e509686a 100644
--- a/frontend-sdk/packages/react-ui/src/components/Header/header.scss
+++ b/frontend-sdk/packages/react-ui/src/components/Header/header.scss
@@ -6,28 +6,40 @@
flex-direction: column;
gap: map.get(cssUtils.$spacing, "2xs");
overflow-wrap: break-word;
-}
-.crayon-header-top {
- display: flex;
- flex-direction: row;
- justify-content: space-between;
- align-items: center;
-}
-.crayon-header-top-left {
- display: flex;
- flex-direction: row;
- align-items: center;
- gap: map.get(cssUtils.$spacing, "s");
- color: map.get(cssUtils.$colors, "text", "primary");
- @include cssUtils.typography(title, default);
-}
-.crayon-header-top-right {
- display: flex;
- flex-direction: row;
- align-items: center;
- gap: map.get(cssUtils.$spacing, "2xs");
-}
-.crayon-header-bottom {
- color: map.get(cssUtils.$colors, "text", "secondary");
- @include cssUtils.typography(body, default);
+
+ &-top {
+ display: flex;
+ flex-direction: row;
+ justify-content: space-between;
+ align-items: center;
+
+ &-left {
+ display: flex;
+ flex-direction: row;
+ align-items: center;
+ gap: map.get(cssUtils.$spacing, "s");
+ color: map.get(cssUtils.$colors, "text", "primary");
+ @include cssUtils.typography(title, default);
+
+ &-icon {
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ height: 16px;
+ width: 16px;
+ }
+ }
+
+ &-right {
+ display: flex;
+ flex-direction: row;
+ align-items: center;
+ gap: map.get(cssUtils.$spacing, "2xs");
+ }
+ }
+
+ &-bottom {
+ color: map.get(cssUtils.$colors, "text", "secondary");
+ @include cssUtils.typography(body, default);
+ }
}
diff --git a/frontend-sdk/packages/react-ui/src/components/Header/stories/header.stories.tsx b/frontend-sdk/packages/react-ui/src/components/Header/stories/header.stories.tsx
index 2f35dc538..ffa579eff 100644
--- a/frontend-sdk/packages/react-ui/src/components/Header/stories/header.stories.tsx
+++ b/frontend-sdk/packages/react-ui/src/components/Header/stories/header.stories.tsx
@@ -43,7 +43,7 @@ export const CardStory: Story = {
],
},
render: (args) => (
- <div style={{ width: "500px", backgroundColor: "gray" }}>
+ <div style={{ width: "500px" }}>
<Header {...args} />
</div>
),
diff --git a/frontend-sdk/packages/react-ui/src/components/IconButton/IconButton.tsx b/frontend-sdk/packages/react-ui/src/components/IconButton/IconButton.tsx
index cb16f892c..56c59a971 100644
--- a/frontend-sdk/packages/react-ui/src/components/IconButton/IconButton.tsx
+++ b/frontend-sdk/packages/react-ui/src/components/IconButton/IconButton.tsx
@@ -38,7 +38,7 @@ export const IconButton = React.forwardRef<HTMLButtonElement, IconButtonProps>((
style={style}
{...rest}
>
- {icon}
+ {icon && <span className="crayon-icon-button-icon">{icon}</span>}
</button>
);
});
diff --git a/frontend-sdk/packages/react-ui/src/components/IconButton/iconButton.scss b/frontend-sdk/packages/react-ui/src/components/IconButton/iconButton.scss
index fdb3c7915..0332242ba 100644
--- a/frontend-sdk/packages/react-ui/src/components/IconButton/iconButton.scss
+++ b/frontend-sdk/packages/react-ui/src/components/IconButton/iconButton.scss
@@ -10,12 +10,20 @@
gap: map.get(cssUtils.$spacing, "xs");
cursor: pointer;
transition: all 0.2s ease;
+ padding: 0;
&:disabled {
opacity: 0.5;
cursor: not-allowed;
}
+ //icon
+ &-icon {
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ }
+
// variants
&-primary {
background-color: map.get(cssUtils.$colors, "fills", "brand-el");
@@ -40,7 +48,7 @@
width: 20px;
height: 20px;
box-shadow: map.get(cssUtils.$shadow, "s");
- & svg {
+ & .crayon-icon-button-icon {
height: 14px;
width: 14px;
}
@@ -50,7 +58,7 @@
width: 28px;
height: 28px;
box-shadow: map.get(cssUtils.$shadow, "s");
- & svg {
+ & .crayon-icon-button-icon {
height: 14px;
width: 14px;
}
@@ -60,7 +68,7 @@
width: 32px;
height: 32px;
box-shadow: map.get(cssUtils.$shadow, "m");
- & svg {
+ & .crayon-icon-button-icon {
height: 16px;
width: 16px;
}
@@ -73,7 +81,7 @@
min-height: 36px;
font-size: 16px;
box-shadow: map.get(cssUtils.$shadow, "l");
- & svg {
+ & .crayon-icon-button-icon {
height: 16px;
width: 16px;
}
diff --git a/frontend-sdk/packages/react-ui/src/components/Input/input.scss b/frontend-sdk/packages/react-ui/src/components/Input/input.scss
index f1f95ccf4..8b493dcd0 100644
--- a/frontend-sdk/packages/react-ui/src/components/Input/input.scss
+++ b/frontend-sdk/packages/react-ui/src/components/Input/input.scss
@@ -23,8 +23,7 @@
&:focus {
outline: none;
- // border-color: map.get(cssUtils.$colors, "strokes", "interactive-el-hover");
- border-color: rgb(72, 0, 255);
+ border-color: map.get(cssUtils.$colors, "strokes", "interactive-el-hover");
}
&:disabled {
diff --git a/frontend-sdk/packages/react-ui/src/components/ListItem/listItem.scss b/frontend-sdk/packages/react-ui/src/components/ListItem/listItem.scss
index 0bdc53c3e..c7a1411d9 100644
--- a/frontend-sdk/packages/react-ui/src/components/ListItem/listItem.scss
+++ b/frontend-sdk/packages/react-ui/src/components/ListItem/listItem.scss
@@ -6,7 +6,6 @@
display: flex;
align-items: center;
justify-content: space-between;
- gap: map.get(cssUtils.$spacing, "2xs");
border-bottom: 1px solid map.get(cssUtils.$colors, "strokes", "default");
padding: map.get(cssUtils.$spacing, "s");
cursor: pointer;
@@ -26,6 +25,7 @@
flex-direction: column;
align-items: flex-start;
width: 100%;
+ gap: map.get(cssUtils.$spacing, "2xs");
}
.crayon-list-item-title {