Skip to content

The Open Standard for Generative UI

Code cleanup and refactoring

i-subham91b84fbcdec0
diff --git a/frontend-sdk/packages/react-ui/src/components/Tabs/stories/tabs.stories.tsx b/frontend-sdk/packages/react-ui/src/components/Tabs/stories/tabs.stories.tsx
index 7138c007c..546dda820 100644
--- a/frontend-sdk/packages/react-ui/src/components/Tabs/stories/tabs.stories.tsx
+++ b/frontend-sdk/packages/react-ui/src/components/Tabs/stories/tabs.stories.tsx
@@ -89,19 +89,22 @@ export const CustomStyling: Story = {
export const Clear: Story = {
render: () => (
<Tabs defaultValue="tab1" variant="clear">
- <TabsList className="custom-tabs-list">
- <TabsTrigger value="tab1" className="custom-trigger">
- Tab 1
- </TabsTrigger>
- <TabsTrigger value="tab2" className="custom-trigger">
- Tab 2
- </TabsTrigger>
+ <TabsList>
+ <TabsTrigger value="tab1">Account</TabsTrigger>
+ <TabsTrigger value="tab2">Password</TabsTrigger>
+ <TabsTrigger value="tab3">Settings</TabsTrigger>
</TabsList>
- <TabsContent value="tab1" className="custom-content">
- <p>Content with custom styling.</p>
+ <TabsContent value="tab1">
+ <h3>Account Settings</h3>
+ <p>Manage your account preferences here.</p>
</TabsContent>
- <TabsContent value="tab2" className="custom-content">
- <p>More content with custom styling.</p>
+ <TabsContent value="tab2">
+ <h3>Password Settings</h3>
+ <p>Change your password and security settings.</p>
+ </TabsContent>
+ <TabsContent value="tab3">
+ <h3>General Settings</h3>
+ <p>Configure your application settings.</p>
</TabsContent>
</Tabs>
),
@@ -109,20 +112,23 @@ export const Clear: Story = {
export const Card: Story = {
render: () => (
- <Tabs defaultValue="tab1" variant="card">
- <TabsList className="custom-tabs-list">
- <TabsTrigger value="tab1" className="custom-trigger">
- Tab 1
- </TabsTrigger>
- <TabsTrigger value="tab2" className="custom-trigger">
- Tab 2
- </TabsTrigger>
+ <Tabs defaultValue="tab2" variant="card">
+ <TabsList>
+ <TabsTrigger value="tab1">Account</TabsTrigger>
+ <TabsTrigger value="tab2">Password</TabsTrigger>
+ <TabsTrigger value="tab3">Settings</TabsTrigger>
</TabsList>
- <TabsContent value="tab1" className="custom-content">
- <p>Content with custom styling.</p>
+ <TabsContent value="tab1">
+ <h3>Account Settings</h3>
+ <p>Manage your account preferences here.</p>
</TabsContent>
- <TabsContent value="tab2" className="custom-content">
- <p>More content with custom styling.</p>
+ <TabsContent value="tab2">
+ <h3>Password Settings</h3>
+ <p>Change your password and security settings.</p>
+ </TabsContent>
+ <TabsContent value="tab3">
+ <h3>General Settings</h3>
+ <p>Configure your application settings.</p>
</TabsContent>
</Tabs>
),
@@ -130,20 +136,23 @@ export const Card: Story = {
export const Sunk: Story = {
render: () => (
- <Tabs defaultValue="tab1" variant="sunk">
- <TabsList className="custom-tabs-list">
- <TabsTrigger value="tab1" className="custom-trigger">
- Tab 1
- </TabsTrigger>
- <TabsTrigger value="tab2" className="custom-trigger">
- Tab 2
- </TabsTrigger>
+ <Tabs defaultValue="tab3" variant="sunk">
+ <TabsList>
+ <TabsTrigger value="tab1">Account</TabsTrigger>
+ <TabsTrigger value="tab2">Password</TabsTrigger>
+ <TabsTrigger value="tab3">Settings</TabsTrigger>
</TabsList>
- <TabsContent value="tab1" className="custom-content">
- <p>Content with custom styling.</p>
+ <TabsContent value="tab1">
+ <h3>Account Settings</h3>
+ <p>Manage your account preferences here.</p>
</TabsContent>
- <TabsContent value="tab2" className="custom-content">
- <p>More content with custom styling.</p>
+ <TabsContent value="tab2">
+ <h3>Password Settings</h3>
+ <p>Change your password and security settings.</p>
+ </TabsContent>
+ <TabsContent value="tab3">
+ <h3>General Settings</h3>
+ <p>Configure your application settings.</p>
</TabsContent>
</Tabs>
),
diff --git a/frontend-sdk/packages/react-ui/src/components/Tabs/tabs.scss b/frontend-sdk/packages/react-ui/src/components/Tabs/tabs.scss
index fe03ab97a..cdb067213 100644
--- a/frontend-sdk/packages/react-ui/src/components/Tabs/tabs.scss
+++ b/frontend-sdk/packages/react-ui/src/components/Tabs/tabs.scss
@@ -1,13 +1,8 @@
@use "sass:map";
@use "../../cssUtils" as cssUtils;
-* {
- box-sizing: border-box;
- margin: 0;
- padding: 0;
-}
-
.crayon-tabs {
+ box-sizing: border-box;
display: flex;
flex-direction: column;
gap: map.get(cssUtils.$spacing, "2xs");
@@ -39,6 +34,7 @@
}
.crayon-tabs-list {
+ box-sizing: border-box;
display: flex;
flex-direction: row;
gap: map.get(cssUtils.$spacing, "s");
@@ -49,6 +45,7 @@
}
.crayon-tabs-trigger {
+ box-sizing: border-box;
padding: map.get(cssUtils.$spacing, "2xs");
border: 1px solid transparent;
border-radius: map.get(cssUtils.$radius, "s");
@@ -61,6 +58,7 @@
}
.crayon-tabs-content {
+ box-sizing: border-box;
padding: map.get(cssUtils.$spacing, "l");
border: 1px solid map.get(cssUtils.$colors, "strokes", "default");
background-color: map.get(cssUtils.$colors, "fills", "background");