Skip to content

The Open Standard for Generative UI

Refactor Crayon component

i-subham9d095dd19ed4
diff --git a/js/packages/react-ui/src/components/CardFooter/CardFooter.tsx b/js/packages/react-ui/src/components/Buttons/Buttons.tsx
similarity index 54%
rename from js/packages/react-ui/src/components/CardFooter/CardFooter.tsx
rename to js/packages/react-ui/src/components/Buttons/Buttons.tsx
index 3b02802b7..6c7fd4baf 100644
--- a/js/packages/react-ui/src/components/CardFooter/CardFooter.tsx
+++ b/js/packages/react-ui/src/components/Buttons/Buttons.tsx
@@ -3,10 +3,10 @@ import { CSSProperties, forwardRef, HTMLAttributes, ReactElement } from "react";
import { ButtonProps } from "../Button";
import { IconButtonProps } from "../IconButton";
-type FooterVariant = "vertical" | "horizontal";
+type ButtonsVariant = "vertical" | "horizontal";
-export interface CardFooterProps extends HTMLAttributes<HTMLDivElement> {
- variant?: FooterVariant;
+export interface ButtonsProps extends HTMLAttributes<HTMLDivElement> {
+ variant?: ButtonsVariant;
children:
| ReactElement<ButtonProps | IconButtonProps>
| ReactElement<ButtonProps | IconButtonProps>[];
@@ -14,17 +14,17 @@ export interface CardFooterProps extends HTMLAttributes<HTMLDivElement> {
style?: CSSProperties;
}
-const variantMap: Record<FooterVariant, string> = {
- vertical: "crayon-footer-vertical",
- horizontal: "crayon-footer-horizontal",
+const variantMap: Record<ButtonsVariant, string> = {
+ vertical: "crayon-buttons-vertical",
+ horizontal: "crayon-buttons-horizontal",
};
-export const CardFooter = forwardRef<HTMLDivElement, CardFooterProps>((props, ref) => {
+export const Buttons = forwardRef<HTMLDivElement, ButtonsProps>((props, ref) => {
const { className, style, variant = "horizontal", children, ...rest } = props;
return (
<div
ref={ref}
- className={clsx("crayon-footer", variantMap[variant], className)}
+ className={clsx("crayon-buttons", variantMap[variant], className)}
style={style}
{...rest}
>
@@ -33,4 +33,4 @@ export const CardFooter = forwardRef<HTMLDivElement, CardFooterProps>((props, re
);
});
-CardFooter.displayName = "CardFooter";
+Buttons.displayName = "Buttons";
diff --git a/js/packages/react-ui/src/components/CardFooter/cardFooter.scss b/js/packages/react-ui/src/components/Buttons/buttons.scss
similarity index 93%
rename from js/packages/react-ui/src/components/CardFooter/cardFooter.scss
rename to js/packages/react-ui/src/components/Buttons/buttons.scss
index 45148d1f7..43154a0ac 100644
--- a/js/packages/react-ui/src/components/CardFooter/cardFooter.scss
+++ b/js/packages/react-ui/src/components/Buttons/buttons.scss
@@ -1,7 +1,7 @@
@use "sass:map";
@use "../../cssUtils" as cssUtils;
-.crayon-footer {
+.crayon-buttons {
display: flex;
width: 100%;
gap: map.get(cssUtils.$spacing, "m");
diff --git a/js/packages/react-ui/src/components/Buttons/dependencies.ts b/js/packages/react-ui/src/components/Buttons/dependencies.ts
new file mode 100644
index 000000000..4577dc0f9
--- /dev/null
+++ b/js/packages/react-ui/src/components/Buttons/dependencies.ts
@@ -0,0 +1,2 @@
+const dependencies = ["Buttons"];
+export default dependencies;
diff --git a/js/packages/react-ui/src/components/Buttons/index.ts b/js/packages/react-ui/src/components/Buttons/index.ts
new file mode 100644
index 000000000..cadeaf156
--- /dev/null
+++ b/js/packages/react-ui/src/components/Buttons/index.ts
@@ -0,0 +1 @@
+export * from "./Buttons";
diff --git a/js/packages/react-ui/src/components/CardFooter/stories/cardFooter.stories.tsx b/js/packages/react-ui/src/components/Buttons/stories/buttons.stories.tsx
similarity index 82%
rename from js/packages/react-ui/src/components/CardFooter/stories/cardFooter.stories.tsx
rename to js/packages/react-ui/src/components/Buttons/stories/buttons.stories.tsx
index c7dd744fe..d4818a47f 100644
--- a/js/packages/react-ui/src/components/CardFooter/stories/cardFooter.stories.tsx
+++ b/js/packages/react-ui/src/components/Buttons/stories/buttons.stories.tsx
@@ -2,16 +2,16 @@ import type { Meta, StoryObj } from "@storybook/react";
import { ArrowLeft } from "lucide-react";
import { Button } from "../../Button";
import { IconButton } from "../../IconButton";
-import { CardFooter } from "../CardFooter";
+import { Buttons } from "../Buttons";
-const meta: Meta<typeof CardFooter> = {
- title: "Components/CardFooter",
- component: CardFooter,
+const meta: Meta<typeof Buttons> = {
+ title: "Components/Buttons",
+ component: Buttons,
parameters: {
layout: "centered",
docs: {
description: {
- component: "```tsx\nimport { CardFooter } from '@crayon-ui/react-ui';\n```",
+ component: "```tsx\nimport { Buttons } from '@crayon-ui/react-ui';\n```",
},
},
},
@@ -64,18 +64,18 @@ const meta: Meta<typeof CardFooter> = {
};
export default meta;
-type Story = StoryObj<typeof CardFooter>;
+type Story = StoryObj<typeof Buttons>;
// Basic footer stories
-export const FooterStory: Story = {
+export const ButtonsStory: Story = {
args: {
variant: "horizontal",
},
render: (args) => (
- <CardFooter variant={args.variant}>
+ <Buttons variant={args.variant}>
<Button>Cancel</Button>
<Button>Save</Button>
<IconButton icon={<ArrowLeft size={16} />} />
- </CardFooter>
+ </Buttons>
),
};
diff --git a/js/packages/react-ui/src/components/CardFooter/dependencies.ts b/js/packages/react-ui/src/components/CardFooter/dependencies.ts
deleted file mode 100644
index 2b8444632..000000000
--- a/js/packages/react-ui/src/components/CardFooter/dependencies.ts
+++ /dev/null
@@ -1,2 +0,0 @@
-const dependencies = ["CardFooter"];
-export default dependencies;
diff --git a/js/packages/react-ui/src/components/CardFooter/index.ts b/js/packages/react-ui/src/components/CardFooter/index.ts
deleted file mode 100644
index 06b640859..000000000
--- a/js/packages/react-ui/src/components/CardFooter/index.ts
+++ /dev/null
@@ -1 +0,0 @@
-export * from "./CardFooter";
diff --git a/js/packages/react-ui/src/components/Charts/AreaChart/stories/areaChart.stories.tsx b/js/packages/react-ui/src/components/Charts/AreaChart/stories/areaChart.stories.tsx
index 49ae23815..f70e68015 100644
--- a/js/packages/react-ui/src/components/Charts/AreaChart/stories/areaChart.stories.tsx
+++ b/js/packages/react-ui/src/components/Charts/AreaChart/stories/areaChart.stories.tsx
@@ -53,6 +53,7 @@ const meta: Meta<AreaChartProps<typeof areaChartData>> = {
description: "The width of the chart area in pixels. This excludes margins and padding.",
control: false,
table: {
+ disable: true,
type: { summary: "number" },
defaultValue: { summary: "800" },
category: "Dimensions",
@@ -62,6 +63,7 @@ const meta: Meta<AreaChartProps<typeof areaChartData>> = {
description: "The height of the chart area in pixels. This excludes margins and padding.",
control: false,
table: {
+ disable: true,
type: { summary: "number" },
defaultValue: { summary: "400" },
category: "Dimensions",
diff --git a/js/packages/react-ui/src/components/Charts/BarChart/stories/barChart.stories.tsx b/js/packages/react-ui/src/components/Charts/BarChart/stories/barChart.stories.tsx
index 935a94a31..95d118e63 100644
--- a/js/packages/react-ui/src/components/Charts/BarChart/stories/barChart.stories.tsx
+++ b/js/packages/react-ui/src/components/Charts/BarChart/stories/barChart.stories.tsx
@@ -53,6 +53,7 @@ const meta: Meta<BarChartProps<typeof barChartData>> = {
description: "The width of the chart area in pixels. This excludes margins and padding.",
control: false,
table: {
+ disable: true,
type: { summary: "number" },
defaultValue: { summary: "800" },
category: "Dimensions",
@@ -62,6 +63,7 @@ const meta: Meta<BarChartProps<typeof barChartData>> = {
description: "The height of the chart area in pixels. This excludes margins and padding.",
control: false,
table: {
+ disable: true,
type: { summary: "number" },
defaultValue: { summary: "400" },
category: "Dimensions",
diff --git a/js/packages/react-ui/src/components/Charts/LineChart/stories/lineChart.stories.tsx b/js/packages/react-ui/src/components/Charts/LineChart/stories/lineChart.stories.tsx
index ab2b62423..77ef4aeba 100644
--- a/js/packages/react-ui/src/components/Charts/LineChart/stories/lineChart.stories.tsx
+++ b/js/packages/react-ui/src/components/Charts/LineChart/stories/lineChart.stories.tsx
@@ -54,6 +54,7 @@ const meta: Meta<LineChartProps<typeof lineChartData>> = {
description: "The width of the chart area in pixels. This excludes margins and padding.",
control: false,
table: {
+ disable: true,
type: { summary: "number" },
defaultValue: { summary: "800" },
category: "Dimensions",
@@ -63,6 +64,7 @@ const meta: Meta<LineChartProps<typeof lineChartData>> = {
description: "The height of the chart area in pixels. This excludes margins and padding.",
control: false,
table: {
+ disable: true,
type: { summary: "number" },
defaultValue: { summary: "400" },
category: "Dimensions",
diff --git a/js/packages/react-ui/src/components/Charts/PieChart/stories/pieChart.stories.tsx b/js/packages/react-ui/src/components/Charts/PieChart/stories/pieChart.stories.tsx
index 9817d88c2..880fe2dac 100644
--- a/js/packages/react-ui/src/components/Charts/PieChart/stories/pieChart.stories.tsx
+++ b/js/packages/react-ui/src/components/Charts/PieChart/stories/pieChart.stories.tsx
@@ -58,6 +58,7 @@ const meta: Meta<PieChartProps<typeof pieChartData>> = {
description: "The width of the chart area in pixels. This excludes margins and padding.",
control: false,
table: {
+ disable: true,
type: { summary: "number" },
defaultValue: { summary: "800" },
category: "Dimensions",
@@ -67,6 +68,7 @@ const meta: Meta<PieChartProps<typeof pieChartData>> = {
description: "The height of the chart area in pixels. This excludes margins and padding.",
control: false,
table: {
+ disable: true,
type: { summary: "number" },
defaultValue: { summary: "400" },
category: "Dimensions",
diff --git a/js/packages/react-ui/src/components/Charts/RadarChart/RadarChart.tsx b/js/packages/react-ui/src/components/Charts/RadarChart/RadarChart.tsx
index a1e66a886..15d105aac 100644
--- a/js/packages/react-ui/src/components/Charts/RadarChart/RadarChart.tsx
+++ b/js/packages/react-ui/src/components/Charts/RadarChart/RadarChart.tsx
@@ -70,7 +70,7 @@ export const RadarChart = <T extends RadarChartData>({
{grid && <PolarGrid className="crayon-chart-polar-grid" stroke="currentColor" />}
<PolarAngleAxis dataKey={categoryKey as string} />
- <ChartTooltip cursor={false} content={<ChartTooltipContent indicator="line" />} />
+ <ChartTooltip cursor={false} content={<ChartTooltipContent indicator="dot" />} />
{dataKeys.map((key) => {
const transformedKey = keyTransform(key);
const color = `var(--color-${transformedKey})`;
diff --git a/js/packages/react-ui/src/components/Charts/RadarChart/stories/raderChart.stories.tsx b/js/packages/react-ui/src/components/Charts/RadarChart/stories/raderChart.stories.tsx
index 2a2991a91..be87ac340 100644
--- a/js/packages/react-ui/src/components/Charts/RadarChart/stories/raderChart.stories.tsx
+++ b/js/packages/react-ui/src/components/Charts/RadarChart/stories/raderChart.stories.tsx
@@ -55,6 +55,7 @@ const meta: Meta<RadarChartProps<typeof radarChartData>> = {
description: "The width of the chart area in pixels. This excludes margins and padding.",
control: false,
table: {
+ disable: true,
type: { summary: "number" },
defaultValue: { summary: "800" },
category: "Dimensions",
@@ -64,6 +65,7 @@ const meta: Meta<RadarChartProps<typeof radarChartData>> = {
description: "The height of the chart area in pixels. This excludes margins and padding.",
control: false,
table: {
+ disable: true,
type: { summary: "number" },
defaultValue: { summary: "400" },
category: "Dimensions",
diff --git a/js/packages/react-ui/src/components/Charts/RadialChart/stories/radialChart.stories.tsx b/js/packages/react-ui/src/components/Charts/RadialChart/stories/radialChart.stories.tsx
index 0f77dee09..c1372b842 100644
--- a/js/packages/react-ui/src/components/Charts/RadialChart/stories/radialChart.stories.tsx
+++ b/js/packages/react-ui/src/components/Charts/RadialChart/stories/radialChart.stories.tsx
@@ -59,6 +59,7 @@ const meta: Meta<RadialChartProps<typeof radialChartData>> = {
description: "The width of the chart area in pixels. This excludes margins and padding.",
control: false,
table: {
+ disable: true,
type: { summary: "number" },
defaultValue: { summary: "800" },
category: "Dimensions",
@@ -68,6 +69,7 @@ const meta: Meta<RadialChartProps<typeof radialChartData>> = {
description: "The height of the chart area in pixels. This excludes margins and padding.",
control: false,
table: {
+ disable: true,
type: { summary: "number" },
defaultValue: { summary: "400" },
category: "Dimensions",
diff --git a/js/packages/react-ui/src/components/DatePicker/DatePicker.tsx b/js/packages/react-ui/src/components/DatePicker/DatePicker.tsx
index ce63d666e..e6518fdf8 100644
--- a/js/packages/react-ui/src/components/DatePicker/DatePicker.tsx
+++ b/js/packages/react-ui/src/components/DatePicker/DatePicker.tsx
@@ -7,7 +7,7 @@ import { DatePickerProvider } from "./helpers/context/DatePickerContext";
export interface DatePickerProps {
mode?: "single" | "range";
- variant?: "docked" | "floating";
+ variant?: "docked" | "popover";
selectedSingleDate?: Date;
selectedRangeDates?: DateRange;
setSelectedSingleDate?: (date?: Date) => void;
diff --git a/js/packages/react-ui/src/components/DatePicker/stories/DatePicker.stories.tsx b/js/packages/react-ui/src/components/DatePicker/stories/DatePicker.stories.tsx
index 0c2ac0452..fd3dc5232 100644
--- a/js/packages/react-ui/src/components/DatePicker/stories/DatePicker.stories.tsx
+++ b/js/packages/react-ui/src/components/DatePicker/stories/DatePicker.stories.tsx
@@ -40,12 +40,12 @@ const meta: Meta<typeof DatePicker> = {
},
variant: {
control: "radio",
- options: ["docked", "floating"],
+ options: ["docked", "popover"],
description: "The visual presentation style of the date picker",
table: {
category: "Appearance",
type: {
- summary: "'docked' | 'floating'",
+ summary: "'docked' | 'popover'",
},
defaultValue: { summary: "docked" },
},
@@ -150,7 +150,7 @@ export const FloatingPicker: Story = {
render: (args) => <DatePicker {...args} style={{ width: "350px" }} />,
args: {
mode: "single",
- variant: "floating",
+ variant: "popover",
},
};
diff --git a/js/packages/react-ui/src/components/index.scss b/js/packages/react-ui/src/components/index.scss
index 08949c8e9..f96f5a198 100644
--- a/js/packages/react-ui/src/components/index.scss
+++ b/js/packages/react-ui/src/components/index.scss
@@ -1,7 +1,7 @@
@forward "./Accordion/accordion.scss";
@forward "./Button/button.scss";
@forward "./Card/card.scss";
-@forward "./CardFooter/cardFooter.scss";
+@forward "./Buttons/buttons.scss";
@forward "./CardHeader/cardHeader.scss";
@forward "./Carousel/carousel.scss";
@forward "./Charts/charts.scss";
diff --git a/js/packages/react-ui/src/index.ts b/js/packages/react-ui/src/index.ts
index 2d2fc07ef..c32209cc8 100644
--- a/js/packages/react-ui/src/index.ts
+++ b/js/packages/react-ui/src/index.ts
@@ -1,7 +1,7 @@
export * from "./components/Accordion";
export * from "./components/Button";
+export * from "./components/Buttons";
export * from "./components/Card";
-export * from "./components/CardFooter";
export * from "./components/CardHeader";
export * from "./components/Carousel";
export * from "./components/Charts";