Skip to content

The Open Standard for Generative UI

Refactor Accordion and Code clean up

i-subhamdacac92f959f
diff --git a/frontend-sdk/packages/react-ui/src/components/Accordion/accordion.scss b/frontend-sdk/packages/react-ui/src/components/Accordion/accordion.scss
index 19c2d9740..10cc3b72e 100644
--- a/frontend-sdk/packages/react-ui/src/components/Accordion/accordion.scss
+++ b/frontend-sdk/packages/react-ui/src/components/Accordion/accordion.scss
@@ -1,37 +1,20 @@
@use "sass:map";
@use "../../cssUtils" as cssUtils;
-/* reset */
-button,
-h3 {
- all: unset;
-}
-
.crayon-accordion {
box-sizing: border-box;
border-radius: 6px;
- background-color: map.get(cssUtils.$colors, "fills", "background");
box-shadow: map.get(cssUtils.$shadow, "m");
- border: 1px solid map.get(cssUtils.$colors, "fills", "border");
+ border: 1px solid map.get(cssUtils.$colors, "strokes", "default");
}
.crayon-accordion-item {
box-sizing: border-box;
overflow: hidden;
- border-bottom: 1px solid map.get(cssUtils.$colors, "fills", "border");
+ border-bottom: 1px solid map.get(cssUtils.$colors, "strokes", "default");
&-card {
- .crayon-accordion-trigger {
- background-color: map.get(cssUtils.$colors, "fills", "background");
-
- &:hover {
- background-color: map.get(cssUtils.$colors, "fills", "background-hover");
- }
- }
-
.crayon-accordion-content {
- background-color: map.get(cssUtils.$colors, "fills", "background");
-
&-wrapper {
padding: map.get(cssUtils.$spacing, "l");
gap: map.get(cssUtils.$spacing, "l");
@@ -42,10 +25,6 @@ h3 {
&-sunk {
.crayon-accordion-trigger {
background-color: map.get(cssUtils.$colors, "fills", "sunk");
-
- &:hover {
- background-color: map.get(cssUtils.$colors, "fills", "background-hover");
- }
}
.crayon-accordion-content {
@@ -75,9 +54,14 @@ h3 {
.crayon-accordion-header {
display: flex;
+ margin-block-start: 0;
+ margin-block-end: 0;
+ margin-inline-start: 0;
+ margin-inline-end: 0;
}
.crayon-accordion-trigger {
+ border: none;
box-sizing: border-box;
@include cssUtils.typography("body", "default");
background-color: transparent;
@@ -87,9 +71,8 @@ h3 {
display: flex;
align-items: center;
justify-content: space-between;
- color: map.get(cssUtils.$colors, "fills", "text");
- box-shadow: 0 1px 0 map.get(cssUtils.$colors, "fills", "border");
- background-color: map.get(cssUtils.$colors, "fills", "background");
+ color: map.get(cssUtils.$colors, "text", "primary");
+ box-shadow: map.get(cssUtils.$shadow, "m");
&-content {
display: flex;
@@ -102,9 +85,6 @@ h3 {
}
}
- &:hover {
- background-color: map.get(cssUtils.$colors, "fills", "background-hover");
- }
&-icon {
color: map.get(cssUtils.$colors, "text", "primary");
@include cssUtils.typography("primary", "default");
@@ -122,7 +102,7 @@ h3 {
.crayon-accordion-content {
overflow: hidden;
color: map.get(cssUtils.$colors, "fills", "text");
- background-color: map.get(cssUtils.$colors, "fills", "background");
+ @include cssUtils.typography("body", "default");
&[data-state="open"] {
animation: slideDown 300ms cubic-bezier(0.87, 0, 0.13, 1);
diff --git a/frontend-sdk/packages/react-ui/src/components/Accordion/stories/accordion.stories.tsx b/frontend-sdk/packages/react-ui/src/components/Accordion/stories/accordion.stories.tsx
index 2be75df2e..a3cd4a212 100644
--- a/frontend-sdk/packages/react-ui/src/components/Accordion/stories/accordion.stories.tsx
+++ b/frontend-sdk/packages/react-ui/src/components/Accordion/stories/accordion.stories.tsx
@@ -1,5 +1,11 @@
import type { Meta, StoryObj } from "@storybook/react";
-import { Download } from "lucide-react";
+import { Bell, Download } from "lucide-react";
+import { Header } from "../../Header";
+import "../../Header/header.scss";
+import { IconButton } from "../../IconButton";
+import "../../IconButton/iconButton.scss";
+import { Image } from "../../Image";
+import "../../Image/image.scss";
import { Accordion, AccordionContent, AccordionItem, AccordionTrigger } from "../Accordion";
import "../accordion.scss";
@@ -17,16 +23,37 @@ export const Default: Story = {
render: () => (
<Accordion type="single" collapsible>
<AccordionItem value="item-1">
- <AccordionTrigger text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 1" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/200/300" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
<AccordionItem value="item-2">
- <AccordionTrigger text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 2" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/300/400" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
<AccordionItem value="item-3">
- <AccordionTrigger text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 3" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/400/500" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
</Accordion>
),
@@ -36,16 +63,37 @@ export const SingleOpen: Story = {
render: () => (
<Accordion type="single" collapsible defaultValue="item-1">
<AccordionItem value="item-1">
- <AccordionTrigger text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 1" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/200/300" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
<AccordionItem value="item-2">
- <AccordionTrigger text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 2" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/300/400" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
<AccordionItem value="item-3">
- <AccordionTrigger text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 3" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/400/500" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
</Accordion>
),
@@ -55,16 +103,37 @@ export const Multiple: Story = {
render: () => (
<Accordion type="multiple">
<AccordionItem value="item-1">
- <AccordionTrigger text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 1" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/200/300" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
<AccordionItem value="item-2">
- <AccordionTrigger text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 2" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/300/400" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
<AccordionItem value="item-3">
- <AccordionTrigger text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 3" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/400/500" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
</Accordion>
),
@@ -74,16 +143,37 @@ export const MultipleOpen: Story = {
render: () => (
<Accordion type="multiple" defaultValue={["item-1", "item-2"]}>
<AccordionItem value="item-1">
- <AccordionTrigger text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 1" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/200/300" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
<AccordionItem value="item-2">
- <AccordionTrigger text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 2" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/300/400" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
<AccordionItem value="item-3">
- <AccordionTrigger text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 3" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/400/500" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
</Accordion>
),
@@ -93,16 +183,37 @@ export const withIcon: Story = {
render: () => (
<Accordion type="single" collapsible>
<AccordionItem value="item-1">
- <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 1" icon={<Download />} />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/200/300" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
<AccordionItem value="item-2">
- <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 2" icon={<Download />} />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/300/400" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
<AccordionItem value="item-3">
- <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 3" icon={<Download />} />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/400/500" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
</Accordion>
),
@@ -112,16 +223,37 @@ export const CardVariant: Story = {
render: () => (
<Accordion type="single" collapsible>
<AccordionItem value="item-1" variant="card">
- <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 1" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/200/300" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
<AccordionItem value="item-2" variant="card">
- <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 2" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/300/400" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
<AccordionItem value="item-3" variant="card">
- <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 3" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/400/500" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
</Accordion>
),
@@ -131,16 +263,37 @@ export const SunkVariant: Story = {
render: () => (
<Accordion type="single" collapsible>
<AccordionItem value="item-1" variant="sunk">
- <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 1" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/200/300" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
<AccordionItem value="item-2" variant="sunk">
- <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 2" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/300/400" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
<AccordionItem value="item-3" variant="sunk">
- <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
- <AccordionContent>Accordion Content</AccordionContent>
+ <AccordionTrigger text="Accordion 3" />
+ <AccordionContent>
+ <Header
+ title="Title"
+ subtitle="Subtitle"
+ actions={[<IconButton variant="tertiary" size="small" icon={<Bell />} />]}
+ />
+ <Image src="https://picsum.photos/400/500" alt="Image" scale="fill" />
+ </AccordionContent>
</AccordionItem>
</Accordion>
),