Skip to content

The Open Standard for Generative UI

fix: barchart xaxis hover didn't change the active category (#152)

abhithesysedf96b7951cc
diff --git a/js/eslint.config.cjs b/js/eslint.config.cjs
index 0df857619..bc6f579ff 100644
--- a/js/eslint.config.cjs
+++ b/js/eslint.config.cjs
@@ -51,6 +51,18 @@ module.exports = [
allow: ["error", "warn", "info"],
},
],
+ "no-restricted-imports": [
+ "error",
+ {
+ paths: [
+ {
+ name: "react",
+ importNames: ["useId"],
+ message: "import of useId is allowed only using polyfills",
+ },
+ ],
+ },
+ ],
...eslintPluginPrettier.configs.recommended.rules,
},
},
diff --git a/js/packages/react-ui/package.json b/js/packages/react-ui/package.json
index 1b893d457..6ed42e5a6 100644
--- a/js/packages/react-ui/package.json
+++ b/js/packages/react-ui/package.json
@@ -2,7 +2,7 @@
"type": "module",
"name": "@crayonai/react-ui",
"license": "MIT",
- "version": "0.8.5",
+ "version": "0.8.6",
"description": "Component library for Generative UI SDK",
"main": "dist/index.js",
"types": "dist/index.d.ts",
diff --git a/js/packages/react-ui/src/components/Charts/BarChart/BarChart.tsx b/js/packages/react-ui/src/components/Charts/BarChart/BarChart.tsx
index cb981f953..290b8f307 100644
--- a/js/packages/react-ui/src/components/Charts/BarChart/BarChart.tsx
+++ b/js/packages/react-ui/src/components/Charts/BarChart/BarChart.tsx
@@ -12,6 +12,7 @@ import {
DefaultLegend,
SideBarTooltip,
XAxisTick,
+ XAxisTickProps,
YAxisTick,
} from "../shared";
@@ -307,6 +308,16 @@ const BarChartComponent = <T extends BarChartData>({
setHoveredCategory(null);
}, []);
+ const handleXAxisTickMouseEnter = useCallback((tickProps: XAxisTickProps) => {
+ if (typeof tickProps.payload?.value === "string") {
+ setHoveredCategory(tickProps.payload.value);
+ }
+ }, []);
+
+ const handleXAxisTickMouseLeave = useCallback(() => {
+ setHoveredCategory(null);
+ }, []);
+
const { mode } = useTheme();
const barInternalLineColor = useMemo(() => {
@@ -387,6 +398,8 @@ const BarChartComponent = <T extends BarChartData>({
variant={tickVariant}
widthOfGroup={widthOfGroup}
labelHeight={maxLabelHeight}
+ onMouseEnter={handleXAxisTickMouseEnter}
+ onMouseLeave={handleXAxisTickMouseLeave}
/>
}
orientation="bottom"
diff --git a/js/packages/react-ui/src/components/Charts/shared/XAxisTick/XAxisTick.tsx b/js/packages/react-ui/src/components/Charts/shared/XAxisTick/XAxisTick.tsx
index 67e9d698d..34e9998ac 100644
--- a/js/packages/react-ui/src/components/Charts/shared/XAxisTick/XAxisTick.tsx
+++ b/js/packages/react-ui/src/components/Charts/shared/XAxisTick/XAxisTick.tsx
@@ -27,6 +27,8 @@ interface XAxisTickProps {
variant?: XAxisTickVariant;
widthOfGroup?: number;
labelHeight?: number;
+ onMouseEnter?: (tickProps: XAxisTickProps) => void;
+ onMouseLeave?: (tickProps: XAxisTickProps) => void;
}
const XAxisTick = React.forwardRef<SVGGElement, XAxisTickProps>((props, ref) => {
@@ -39,6 +41,8 @@ const XAxisTick = React.forwardRef<SVGGElement, XAxisTickProps>((props, ref) =>
variant = "multiLine",
widthOfGroup = 70,
labelHeight = 20,
+ onMouseEnter,
+ onMouseLeave,
} = props;
const value = String(payload?.value || "");
@@ -82,6 +86,8 @@ const XAxisTick = React.forwardRef<SVGGElement, XAxisTickProps>((props, ref) =>
height: "100%",
boxSizing: "border-box",
}}
+ onMouseEnter={() => onMouseEnter?.(props)}
+ onMouseLeave={() => onMouseLeave?.(props)}
>
<LabelTooltip content={value} side="top" disabled={!isMultiLineTruncated}>
<span
@@ -108,7 +114,15 @@ const XAxisTick = React.forwardRef<SVGGElement, XAxisTickProps>((props, ref) =>
return (
<g ref={ref} transform={`translate(${x},${y})`} className={className}>
<LabelTooltip content={value} side="top" disabled={!isTruncated}>
- <text x={0} y={0} dy={12} textAnchor={"middle"} className="crayon-chart-x-axis-tick">
+ <text
+ x={0}
+ y={0}
+ dy={12}
+ textAnchor={"middle"}
+ className="crayon-chart-x-axis-tick"
+ onMouseEnter={() => onMouseEnter?.(props)}
+ onMouseLeave={() => onMouseLeave?.(props)}
+ >
{displayValue}
</text>
</LabelTooltip>
diff --git a/js/packages/react-ui/src/components/Table/Table.tsx b/js/packages/react-ui/src/components/Table/Table.tsx
index 230949bfa..e16cb3ccd 100644
--- a/js/packages/react-ui/src/components/Table/Table.tsx
+++ b/js/packages/react-ui/src/components/Table/Table.tsx
@@ -1,5 +1,5 @@
import clsx from "clsx";
-import * as React from "react";
+import React from "react";
const Table = React.forwardRef<HTMLTableElement, React.HTMLAttributes<HTMLTableElement>>(
({ className, ...props }, ref) => (