Skip to content

The Open Standard for Generative UI

fix(a11y): use aria-labelledby instead of aria-label on Modal dialog (#479)

Olabode Felix Akinyemif0261409652f
diff --git a/packages/react-ui/src/components/Modal/Modal.tsx b/packages/react-ui/src/components/Modal/Modal.tsx
index 2f8df2916..6961817e7 100644
--- a/packages/react-ui/src/components/Modal/Modal.tsx
+++ b/packages/react-ui/src/components/Modal/Modal.tsx
@@ -59,11 +59,13 @@ export const Modal: React.FC<ModalProps> = ({
className={clsx("openui-modal-content", sizeClass[size])}
role="dialog"
aria-modal="true"
- aria-label={title}
+ aria-labelledby="openui-modal-title"
tabIndex={-1}
>
<div className="openui-modal-header">
- <h2 className="openui-modal-title">{title}</h2>
+ <h2 id="openui-modal-title" className="openui-modal-title">
+ {title}
+ </h2>
<button className="openui-modal-close" aria-label="Close" onClick={handleClose}>
<X size={18} />
</button>