Skip to content

The Open Standard for Generative UI

Refactor componnts

i-subhamf41bb061c16a
diff --git a/frontend-sdk/packages/react-ui/src/components/Accordion/Accordion.tsx b/frontend-sdk/packages/react-ui/src/components/Accordion/Accordion.tsx
index c121ef26f..c0256f46d 100644
--- a/frontend-sdk/packages/react-ui/src/components/Accordion/Accordion.tsx
+++ b/frontend-sdk/packages/react-ui/src/components/Accordion/Accordion.tsx
@@ -44,12 +44,12 @@ export interface AccordionTriggerProps
className?: string;
style?: React.CSSProperties;
icon?: React.ReactNode;
- children?: React.ReactNode;
+ text: React.ReactNode;
}
export const AccordionTrigger = forwardRef<
React.ComponentRef<typeof AccordionPrimitive.Trigger>,
AccordionTriggerProps
->(({ className, style, children, icon, ...props }, ref) => (
+>(({ className, style, text, icon, ...props }, ref) => (
<AccordionPrimitive.Header className={clsx("crayon-accordion-header")}>
<AccordionPrimitive.Trigger
ref={ref}
@@ -59,7 +59,7 @@ export const AccordionTrigger = forwardRef<
>
<div className="crayon-accordion-trigger-content">
{icon}
- {children}
+ {text}
</div>
<ChevronDownIcon className="crayon-accordion-trigger-icon" />
</AccordionPrimitive.Trigger>
diff --git a/frontend-sdk/packages/react-ui/src/components/Accordion/stories/accordion.stories.tsx b/frontend-sdk/packages/react-ui/src/components/Accordion/stories/accordion.stories.tsx
index 61f9373b9..2be75df2e 100644
--- a/frontend-sdk/packages/react-ui/src/components/Accordion/stories/accordion.stories.tsx
+++ b/frontend-sdk/packages/react-ui/src/components/Accordion/stories/accordion.stories.tsx
@@ -17,15 +17,15 @@ export const Default: Story = {
render: () => (
<Accordion type="single" collapsible>
<AccordionItem value="item-1">
- <AccordionTrigger>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
<AccordionItem value="item-2">
- <AccordionTrigger>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
<AccordionItem value="item-3">
- <AccordionTrigger>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
</Accordion>
@@ -36,15 +36,15 @@ export const SingleOpen: Story = {
render: () => (
<Accordion type="single" collapsible defaultValue="item-1">
<AccordionItem value="item-1">
- <AccordionTrigger>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
<AccordionItem value="item-2">
- <AccordionTrigger>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
<AccordionItem value="item-3">
- <AccordionTrigger>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
</Accordion>
@@ -55,15 +55,15 @@ export const Multiple: Story = {
render: () => (
<Accordion type="multiple">
<AccordionItem value="item-1">
- <AccordionTrigger>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
<AccordionItem value="item-2">
- <AccordionTrigger>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
<AccordionItem value="item-3">
- <AccordionTrigger>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
</Accordion>
@@ -74,15 +74,15 @@ export const MultipleOpen: Story = {
render: () => (
<Accordion type="multiple" defaultValue={["item-1", "item-2"]}>
<AccordionItem value="item-1">
- <AccordionTrigger>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
<AccordionItem value="item-2">
- <AccordionTrigger>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
<AccordionItem value="item-3">
- <AccordionTrigger>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
</Accordion>
@@ -93,15 +93,15 @@ export const withIcon: Story = {
render: () => (
<Accordion type="single" collapsible>
<AccordionItem value="item-1">
- <AccordionTrigger icon={<Download />}>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
<AccordionItem value="item-2">
- <AccordionTrigger icon={<Download />}>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
<AccordionItem value="item-3">
- <AccordionTrigger icon={<Download />}>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
</Accordion>
@@ -112,15 +112,15 @@ export const CardVariant: Story = {
render: () => (
<Accordion type="single" collapsible>
<AccordionItem value="item-1" variant="card">
- <AccordionTrigger icon={<Download />}>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
<AccordionItem value="item-2" variant="card">
- <AccordionTrigger icon={<Download />}>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
<AccordionItem value="item-3" variant="card">
- <AccordionTrigger icon={<Download />}>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
</Accordion>
@@ -131,15 +131,15 @@ export const SunkVariant: Story = {
render: () => (
<Accordion type="single" collapsible>
<AccordionItem value="item-1" variant="sunk">
- <AccordionTrigger icon={<Download />}>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
<AccordionItem value="item-2" variant="sunk">
- <AccordionTrigger icon={<Download />}>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
<AccordionItem value="item-3" variant="sunk">
- <AccordionTrigger icon={<Download />}>Accordion Trigger</AccordionTrigger>
+ <AccordionTrigger icon={<Download />} text="Accordion Trigger" />
<AccordionContent>Accordion Content</AccordionContent>
</AccordionItem>
</Accordion>
diff --git a/frontend-sdk/packages/react-ui/src/components/Button/button.scss b/frontend-sdk/packages/react-ui/src/components/Button/button.scss
index 73a068c5a..9c3c06cf2 100644
--- a/frontend-sdk/packages/react-ui/src/components/Button/button.scss
+++ b/frontend-sdk/packages/react-ui/src/components/Button/button.scss
@@ -2,6 +2,7 @@
@use "../../cssUtils" as cssUtils;
.crayon-button-base {
+ box-sizing: border-box;
@include cssUtils.typography(body, default);
padding: map.get(cssUtils.$spacing, "m");
border-radius: map.get(cssUtils.$radius, "m");
diff --git a/frontend-sdk/packages/react-ui/src/components/FollowUpBlock/followUpBlock.scss b/frontend-sdk/packages/react-ui/src/components/FollowUpBlock/followUpBlock.scss
index 57abec4ec..b5768edb3 100644
--- a/frontend-sdk/packages/react-ui/src/components/FollowUpBlock/followUpBlock.scss
+++ b/frontend-sdk/packages/react-ui/src/components/FollowUpBlock/followUpBlock.scss
@@ -2,6 +2,7 @@
@use "../../cssUtils" as cssUtils;
.crayon-follow-up-block {
+ box-sizing: border-box;
display: flex;
flex-direction: column;
gap: map.get(cssUtils.$spacing, "3xs");
diff --git a/frontend-sdk/packages/react-ui/src/components/FollowUpItem/followUpItem.scss b/frontend-sdk/packages/react-ui/src/components/FollowUpItem/followUpItem.scss
index 4b88aa59b..2c5263b63 100644
--- a/frontend-sdk/packages/react-ui/src/components/FollowUpItem/followUpItem.scss
+++ b/frontend-sdk/packages/react-ui/src/components/FollowUpItem/followUpItem.scss
@@ -2,6 +2,7 @@
@use "../../cssUtils" as cssUtils;
.crayon-follow-up-item {
+ box-sizing: border-box;
@include cssUtils.typography(primary, default);
padding: map.get(cssUtils.$spacing, "xs") map.get(cssUtils.$spacing, "s");
border-bottom: 1px solid map.get(cssUtils.$colors, "strokes", "default");
diff --git a/frontend-sdk/packages/react-ui/src/components/Footer/footer.scss b/frontend-sdk/packages/react-ui/src/components/Footer/footer.scss
index be1ecece3..45148d1f7 100644
--- a/frontend-sdk/packages/react-ui/src/components/Footer/footer.scss
+++ b/frontend-sdk/packages/react-ui/src/components/Footer/footer.scss
@@ -5,6 +5,7 @@
display: flex;
width: 100%;
gap: map.get(cssUtils.$spacing, "m");
+ box-sizing: border-box;
&-horizontal {
flex-direction: row;
diff --git a/frontend-sdk/packages/react-ui/src/components/FormControl/Hint/hint.scss b/frontend-sdk/packages/react-ui/src/components/FormControl/Hint/hint.scss
index e7be77a15..bf0772f33 100644
--- a/frontend-sdk/packages/react-ui/src/components/FormControl/Hint/hint.scss
+++ b/frontend-sdk/packages/react-ui/src/components/FormControl/Hint/hint.scss
@@ -2,6 +2,7 @@
@use "sass:map";
.crayon-hint {
+ box-sizing: border-box;
@include cssUtils.typography(label, default);
color: map.get(cssUtils.$colors, "text", "secondary");
}
diff --git a/frontend-sdk/packages/react-ui/src/components/FormControl/Label/label.scss b/frontend-sdk/packages/react-ui/src/components/FormControl/Label/label.scss
index 7596c724f..7827f32f6 100644
--- a/frontend-sdk/packages/react-ui/src/components/FormControl/Label/label.scss
+++ b/frontend-sdk/packages/react-ui/src/components/FormControl/Label/label.scss
@@ -2,6 +2,7 @@
@use "../../../cssUtils.scss" as cssUtils;
.crayon-label {
+ box-sizing: border-box;
@include cssUtils.typography(label, default);
color: map.get(cssUtils.$colors, "text", "primary");
}
diff --git a/frontend-sdk/packages/react-ui/src/components/FormControl/formControl.scss b/frontend-sdk/packages/react-ui/src/components/FormControl/formControl.scss
index da5e2f147..083e16f1a 100644
--- a/frontend-sdk/packages/react-ui/src/components/FormControl/formControl.scss
+++ b/frontend-sdk/packages/react-ui/src/components/FormControl/formControl.scss
@@ -2,6 +2,7 @@
@use "../../cssUtils.scss" as cssUtils;
.crayon-form-control {
+ box-sizing: border-box;
display: flex;
flex-direction: column;
gap: map.get(cssUtils.$spacing, "xs");
diff --git a/frontend-sdk/packages/react-ui/src/components/IconButton/iconButton.scss b/frontend-sdk/packages/react-ui/src/components/IconButton/iconButton.scss
index 04f6ea1cd..72f9a0527 100644
--- a/frontend-sdk/packages/react-ui/src/components/IconButton/iconButton.scss
+++ b/frontend-sdk/packages/react-ui/src/components/IconButton/iconButton.scss
@@ -2,6 +2,7 @@
@use "../../cssUtils" as cssUtils;
.crayon-icon-button {
+ box-sizing: border-box;
display: flex;
align-items: center;
justify-content: center;
@@ -38,35 +39,41 @@
&-extra-small {
width: 20px;
height: 20px;
- font-size: 12px;
- padding: map.get(cssUtils.$spacing, "3xs");
box-shadow: map.get(cssUtils.$shadow, "s");
+ & svg {
+ height: 14px;
+ width: 14px;
+ }
}
&-small {
width: 28px;
height: 28px;
- font-size: 14px;
- padding: map.get(cssUtils.$spacing, "xs");
box-shadow: map.get(cssUtils.$shadow, "s");
+ & svg {
+ height: 14px;
+ width: 14px;
+ }
}
&-medium {
width: 32px;
height: 32px;
- padding: map.get(cssUtils.$spacing, "s");
box-shadow: map.get(cssUtils.$shadow, "m");
- &-size {
- font-size: 16px;
+ & svg {
+ height: 16px;
+ width: 16px;
}
}
&-large {
width: 36px;
height: 36px;
- font-size: 16px;
- padding: map.get(cssUtils.$spacing, "m");
box-shadow: map.get(cssUtils.$shadow, "l");
+ & svg {
+ height: 16px;
+ width: 16px;
+ }
}
// shapes
diff --git a/frontend-sdk/packages/react-ui/src/components/ListItem/listItem.scss b/frontend-sdk/packages/react-ui/src/components/ListItem/listItem.scss
index 3763e1dc7..0bdc53c3e 100644
--- a/frontend-sdk/packages/react-ui/src/components/ListItem/listItem.scss
+++ b/frontend-sdk/packages/react-ui/src/components/ListItem/listItem.scss
@@ -2,6 +2,7 @@
@use "../../cssUtils.scss" as cssUtils;
.crayon-list-item {
+ box-sizing: border-box;
display: flex;
align-items: center;
justify-content: space-between;
@@ -19,6 +20,7 @@
}
.crayon-list-item-content {
+ box-sizing: border-box;
flex: 1;
display: flex;
flex-direction: column;
diff --git a/frontend-sdk/packages/react-ui/src/components/Select/select.scss b/frontend-sdk/packages/react-ui/src/components/Select/select.scss
index 806b8645d..b8b547423 100644
--- a/frontend-sdk/packages/react-ui/src/components/Select/select.scss
+++ b/frontend-sdk/packages/react-ui/src/components/Select/select.scss
@@ -2,6 +2,7 @@
@use "../../cssUtils" as cssUtils;
.crayon-select-trigger {
+ box-sizing: border-box;
background-color: map.get(cssUtils.$colors, "fills", "background");
color: map.get(cssUtils.$colors, "text", "primary");
@include cssUtils.typography(label, default);
@@ -51,6 +52,7 @@
}
.crayon-select-content {
+ box-sizing: border-box;
position: relative;
z-index: 50;
max-height: 380px;
@@ -62,6 +64,7 @@
}
.crayon-select-viewport {
+ box-sizing: border-box;
padding: 4px;
&[data-position="popper"] {
@@ -70,11 +73,13 @@
}
.crayon-select-label {
+ box-sizing: border-box;
padding: map.get(cssUtils.$spacing, "xs") map.get(cssUtils.$spacing, "s");
@include cssUtils.typography(primary, default);
}
.crayon-select-item {
+ box-sizing: border-box;
position: relative;
display: flex;
cursor: default;
@@ -149,6 +154,7 @@
}
.crayon-select-separator {
+ box-sizing: border-box;
margin: 4px -4px;
height: 1px;
border-top: 1px solid map.get(cssUtils.$colors, "strokes", "primary-el");
diff --git a/frontend-sdk/packages/react-ui/src/components/TagBlock/tagBlock.scss b/frontend-sdk/packages/react-ui/src/components/TagBlock/tagBlock.scss
index 475f6fa1f..7c453be03 100644
--- a/frontend-sdk/packages/react-ui/src/components/TagBlock/tagBlock.scss
+++ b/frontend-sdk/packages/react-ui/src/components/TagBlock/tagBlock.scss
@@ -2,6 +2,7 @@
@use "../../cssUtils" as cssUtils;
.crayon-tag-block {
+ box-sizing: border-box;
display: flex;
flex-wrap: wrap;
gap: map.get(cssUtils.$spacing, "xs");