Skip to content

Create professional demos and 3D mockups in seconds, directly in your browser

fix: update audio detection logic and improve video upload button accessibility

CristianOlivera1dd5f9c2cdedc
diff --git a/app/[locale]/(editor)/editor/page.tsx b/app/[locale]/(editor)/editor/page.tsx
index a13d1bc..7bc4611 100644
--- a/app/[locale]/(editor)/editor/page.tsx
+++ b/app/[locale]/(editor)/editor/page.tsx
@@ -28,7 +28,7 @@ import type { CameraConfig } from "@/types/camera.types";
import type { Preview3DConfig, ImageMaskConfig } from "@/types/photo.types";
import { DEFAULT_MASK_CONFIG, PREVIEW_CONFIGS } from "@/types/photo.types";
import { MOCKUPS } from "@/lib/mockup-data";
-import { gradientToCss, generateDefaultZoomFragments, createZoomFragment, detectVideoHasAudio, ASPECT_RATIO_DIMENSIONS } from "@/types";
+import { gradientToCss, generateDefaultZoomFragments, createZoomFragment, ASPECT_RATIO_DIMENSIONS } from "@/types";
import { ToolsSidebar } from "@/app/components/ui/editor/ToolsSidebar";
import { MobileToolsMenu } from "@/app/components/ui/editor/MobileToolsMenu";
import { MobileControlPanel } from "@/app/components/ui/editor/MobileControlPanel";
@@ -1371,6 +1371,7 @@ export default function Editor() {
masterVolume,
videoClips: videoClips.length > 0 ? videoClips : undefined,
videoClipBlobs: videoClips.length > 1 ? videoBlobsRef.current : undefined,
+ clipAudioStates: Object.fromEntries(clipAudioStateRef.current),
}).finally(() => {
});
};
@@ -1405,13 +1406,12 @@ export default function Editor() {
activeClipIdRef.current = null;
activeClipDataRef.current = null;
setVideoBlob(file);
- detectVideoHasAudio(file).then(hasAudio => {
- setVideoHasAudioTrack(hasAudio);
- if (!hasAudio) setMuteOriginalAudio(true);
- if (libraryVideo) {
- clipAudioStateRef.current.set(libraryVideo.id, hasAudio);
- }
- });
+ if (libraryVideo) {
+ const originalHasAudio = libraryVideo.originalHasAudio !== false;
+ setVideoHasAudioTrack(originalHasAudio);
+ if (!originalHasAudio) setMuteOriginalAudio(true);
+ clipAudioStateRef.current.set(libraryVideo.id, libraryVideo.hasAudio !== false);
+ }
try {
await clearAllThumbnailCache();
@@ -1513,10 +1513,6 @@ export default function Editor() {
setVideoUrl(url);
setVideoId(videoId);
- detectVideoHasAudio(blob).then(hasAudio => {
- clipAudioStateRef.current.set(videoId, hasAudio);
- });
-
const video = document.createElement('video');
video.preload = 'metadata';
const metadataUrl = URL.createObjectURL(blob);
@@ -1645,13 +1641,11 @@ export default function Editor() {
const handleVideoAudioToggle = useCallback((videoId: string, hasAudio: boolean) => {
clipAudioStateRef.current.set(videoId, hasAudio);
- if (muteOriginalAudio) return;
-
const activeClip = activeClipDataRef.current;
if (activeClip && activeClip.libraryVideoId === videoId && videoRef.current) {
- videoRef.current.muted = !hasAudio;
+ videoRef.current.muted = muteOriginalAudioRef.current || !hasAudio;
}
- }, [muteOriginalAudio]);
+ }, []);
// Handler para quitar video del track (toggle) - solo remueve el clip, no la librería
const handleRemoveVideoFromTrack = useCallback((libraryVideoId: string) => {
@@ -1799,10 +1793,10 @@ export default function Editor() {
videoBlobsRef.current.set(libraryVideo.id, videoBlob);
videoUrlsRef.current.set(libraryVideo.id, videoToLoad.url);
- const hasAudio = libraryVideo.hasAudio !== false;
- clipAudioStateRef.current.set(libraryVideo.id, hasAudio);
- setVideoHasAudioTrack(hasAudio);
- if (!hasAudio) setMuteOriginalAudio(true);
+ const originalHasAudio = libraryVideo.originalHasAudio !== false;
+ clipAudioStateRef.current.set(libraryVideo.id, libraryVideo.hasAudio !== false);
+ setVideoHasAudioTrack(originalHasAudio);
+ if (!originalHasAudio) setMuteOriginalAudio(true);
const newClip: VideoTrackClip = {
id: crypto.randomUUID(),
diff --git a/app/components/ui/editor/VideosMenu.tsx b/app/components/ui/editor/VideosMenu.tsx
index f673c26..5fb3a3f 100644
--- a/app/components/ui/editor/VideosMenu.tsx
+++ b/app/components/ui/editor/VideosMenu.tsx
@@ -187,7 +187,7 @@ export function VideosMenu({
className="group bg-[#09090B] border border-dashed border-white/10 hover:border-white/30 hover:bg-white/3 squircle-element p-8 text-center cursor-pointer transition-colors"
role="button"
tabIndex={0}
- aria-label={t("empty.uploadButton")}
+ aria-label={t("emptyState.title")}
onKeyDown={(e) => { if (e.key === 'Enter' || e.key === ' ') { e.preventDefault(); triggerFileUpload(); } }}
>
<div className="w-12 h-12 rounded-full bg-white/5 border border-white/10 flex items-center justify-center mx-auto mb-4 group-hover:scale-105 transition-transform">