Skip to content

Voice-to-text dictation app with local (Nvidia Parakeet/Whisper) and cloud models (BYOK). Privacy-first and available cross-platform.

fix(notes): gap above the action chips and no destination tags in All actions (#2664) (#2674)

Joshua03cedd4f1c72
diff --git a/src/components/notes/ActionChips.tsx b/src/components/notes/ActionChips.tsx
index 8d96afb54..c9772e821 100644
--- a/src/components/notes/ActionChips.tsx
+++ b/src/components/notes/ActionChips.tsx
@@ -75,7 +75,8 @@ export default function ActionChips({
<DropdownMenuContent
align={docked ? "start" : "end"}
side="top"
- sideOffset={8}
+ // Docked, the tray reaches 7px above the chips; the menu clears its edge by 8px.
+ sideOffset={docked ? 15 : 8}
// The docked chat sits 24px in from the window's edge; the menu stays inside that too.
collisionPadding={docked ? 24 : undefined}
className="min-w-48"
diff --git a/src/components/notes/ActionMenuItems.tsx b/src/components/notes/ActionMenuItems.tsx
index f24ad7865..d46823bb0 100644
--- a/src/components/notes/ActionMenuItems.tsx
+++ b/src/components/notes/ActionMenuItems.tsx
@@ -13,19 +13,7 @@ export interface ActionMenuItemsProps {
onManageActions: () => void;
}
-/** Where an action's output goes: the note's chat or its AI summary. */
-export function ActionOutputBadge({ action }: { action: ActionItem }) {
- const { t } = useTranslation();
- return (
- <span className="text-[10px] font-medium px-1 py-px rounded bg-foreground/5 dark:bg-white/6 text-muted-foreground/70 shrink-0">
- {t(
- action.output === "summary" ? "notes.actions.output.summary" : "notes.actions.output.chat"
- )}
- </span>
- );
-}
-
-/** Every action with where its output goes, then Manage Actions, as a dropdown's items. */
+/** Every action, then Manage Actions, as a dropdown's items. */
export default function ActionMenuItems({
actions,
canRun,
@@ -47,11 +35,8 @@ export default function ActionMenuItems({
>
<Icon size={14} className="shrink-0 text-primary" />
<div className="flex-1 min-w-0">
- <div className="flex items-center gap-1.5">
- <span dir="auto" className="font-medium truncate">
- {getActionName(action, t)}
- </span>
- <ActionOutputBadge action={action} />
+ <div className="font-medium truncate">
+ <span dir="auto">{getActionName(action, t)}</span>
</div>
<div className="text-xs text-muted-foreground/70 truncate">
{getActionDescription(action, t)}
diff --git a/test/components/noteActionChips.test.js b/test/components/noteActionChips.test.js
index 0e0760321..37aca4e42 100644
--- a/test/components/noteActionChips.test.js
+++ b/test/components/noteActionChips.test.js
@@ -264,6 +264,38 @@ test("the action menu lists every action, then Manage Actions", async (t) => {
assert.deepEqual(ran, ["Create outline", "manage"]);
});
+test("the action menu shows each action's name and description, without a destination tag", async (t) => {
+ installBrowserGlobals(t);
+ const vite = await createRendererServer(t, {
+ cachePrefix: "openwhispr-note-action-menu-items-",
+ mockModules: {
+ "/ui/dropdown-menu": `
+ import React from "react";
+ export const DropdownMenuItem = ({ children }) => React.createElement("li", null, children);
+ export const DropdownMenuSeparator = () => React.createElement("hr");
+ `,
+ },
+ });
+ const ActionMenuItems = (await vite.ssrLoadModule("/components/notes/ActionMenuItems.tsx"))
+ .default;
+ const markup = renderToStaticMarkup(
+ React.createElement(ActionMenuItems, {
+ actions: [
+ action({ id: 4, name: "Create to-dos", description: "List every to-do" }),
+ action({ id: 8, name: "Trim", description: "Shorten the summary", output: "summary" }),
+ ],
+ canRun: () => true,
+ onRunAction: () => {},
+ onManageActions: () => {},
+ })
+ );
+
+ for (const text of ["Create to-dos", "List every to-do", "Trim", "Shorten the summary"]) {
+ assert.ok(markup.includes(text), `shows "${text}"`);
+ }
+ assert.doesNotMatch(markup, /notes\.actions\.output\./, "no Chat / AI summary tag");
+});
+
test("the collapsed ask bar's picker runs the first action until one is picked, and remembers the pick", async (t) => {
const ActionPicker = await load(t, "/components/notes/ActionPicker.tsx");
const ran = [];