Skip to content

Voice-to-text dictation app with local (Nvidia Parakeet/Whisper) and cloud models (BYOK). Privacy-first and available cross-platform.

fix(participants): guard non-positive, non-integer, and non-finite expected speaker counts (#1522)

Henry Su1cb44be28c01
diff --git a/src/utils/participants.ts b/src/utils/participants.ts
index 07e8c9a75..8e3921691 100644
--- a/src/utils/participants.ts
+++ b/src/utils/participants.ts
@@ -42,7 +42,13 @@ export const resolveExpectedSpeakerCount = (note?: {
expected_speaker_count?: number | null;
participants?: string | null;
}): number | null => {
- if (note?.expected_speaker_count != null) return note.expected_speaker_count;
+ if (
+ typeof note?.expected_speaker_count === "number" &&
+ Number.isInteger(note.expected_speaker_count) &&
+ note.expected_speaker_count > 0
+ ) {
+ return note.expected_speaker_count;
+ }
if (!note?.participants) return null;
let attendees: CalendarAttendee[];
diff --git a/test/utils/participants.test.js b/test/utils/participants.test.js
new file mode 100644
index 000000000..014b7276e
--- /dev/null
+++ b/test/utils/participants.test.js
@@ -0,0 +1,55 @@
+const test = require("node:test");
+const assert = require("node:assert/strict");
+
+const load = () => import("../../src/utils/participants.ts");
+
+test("returns positive integer expected_speaker_count verbatim", async () => {
+ const { resolveExpectedSpeakerCount } = await load();
+ assert.equal(resolveExpectedSpeakerCount({ expected_speaker_count: 3 }), 3);
+ assert.equal(resolveExpectedSpeakerCount({ expected_speaker_count: 1 }), 1);
+});
+
+test("ignores non-positive expected_speaker_count and falls back to participants", async () => {
+ const { resolveExpectedSpeakerCount } = await load();
+ const note = {
+ expected_speaker_count: 0,
+ participants: JSON.stringify([{ name: "Alice" }, { name: "Bob", self: true }]),
+ };
+ assert.equal(resolveExpectedSpeakerCount(note), 2);
+
+ assert.equal(resolveExpectedSpeakerCount({ expected_speaker_count: 0 }), null);
+ assert.equal(resolveExpectedSpeakerCount({ expected_speaker_count: -1 }), null);
+ assert.equal(resolveExpectedSpeakerCount({ expected_speaker_count: -10 }), null);
+});
+
+test("ignores non-integer and non-finite expected_speaker_count", async () => {
+ const { resolveExpectedSpeakerCount } = await load();
+ assert.equal(resolveExpectedSpeakerCount({ expected_speaker_count: 1.5 }), null);
+ assert.equal(resolveExpectedSpeakerCount({ expected_speaker_count: NaN }), null);
+ assert.equal(resolveExpectedSpeakerCount({ expected_speaker_count: Infinity }), null);
+ assert.equal(resolveExpectedSpeakerCount({ expected_speaker_count: -Infinity }), null);
+});
+
+test("derives speaker count from calendar participants when expected_speaker_count is nullish", async () => {
+ const { resolveExpectedSpeakerCount } = await load();
+ const participants = JSON.stringify([
+ { name: "Alice" },
+ { name: "Charlie" },
+ { name: "Bob", self: true },
+ ]);
+
+ assert.equal(resolveExpectedSpeakerCount({ expected_speaker_count: null, participants }), 3);
+ assert.equal(resolveExpectedSpeakerCount({ participants }), 3);
+});
+
+test("returns null when participants has no non-self attendees or is malformed", async () => {
+ const { resolveExpectedSpeakerCount } = await load();
+ assert.equal(
+ resolveExpectedSpeakerCount({ participants: JSON.stringify([{ name: "Bob", self: true }]) }),
+ null
+ );
+ assert.equal(resolveExpectedSpeakerCount({ participants: "invalid json" }), null);
+ assert.equal(resolveExpectedSpeakerCount({ participants: "" }), null);
+ assert.equal(resolveExpectedSpeakerCount({}), null);
+ assert.equal(resolveExpectedSpeakerCount(), null);
+});