Voice-to-text dictation app with local (Nvidia Parakeet/Whisper) and cloud models (BYOK). Privacy-first and available cross-platform.
JavaScript aianthropiccross-platformgeminigroqlinuxmacosnvidiaopen-sourceopenaiparakeetspeech-to-texttranscribewhisperwindows
fix(sidecars): tolerate unreadable PID entries (#1374)
Henry Su375a2c8605b4
diff --git a/src/helpers/sidecarPidFile.js b/src/helpers/sidecarPidFile.jsindex e801ef437..b5eab290c 100644--- a/src/helpers/sidecarPidFile.js+++ b/src/helpers/sidecarPidFile.js@@ -32,15 +32,25 @@ function clear(name) {function readAll() {const dir = pidDir();- if (!fs.existsSync(dir)) return [];+ let files;+ try {+ files = fs.readdirSync(dir);+ } catch {+ return [];+ }+const entries = [];- for (const file of fs.readdirSync(dir)) {+ for (const file of files) {if (!file.endsWith(".pid")) continue;- const name = path.basename(file, ".pid");- const raw = fs.readFileSync(path.join(dir, file), "utf-8").trim();- const pid = Number(raw);- if (!Number.isInteger(pid) || pid <= 0) continue;- entries.push({ name, pid });+ try {+ const name = path.basename(file, ".pid");+ const raw = fs.readFileSync(path.join(dir, file), "utf-8").trim();+ const pid = Number(raw);+ if (!Number.isInteger(pid) || pid <= 0) continue;+ entries.push({ name, pid });+ } catch {+ // Best-effort recovery metadata; skip entries that vanished or cannot be read.+ }}return entries;}diff --git a/test/helpers/sidecarPidFile.test.js b/test/helpers/sidecarPidFile.test.jsnew file mode 100644index 000000000..0ac69190f--- /dev/null+++ b/test/helpers/sidecarPidFile.test.js@@ -0,0 +1,63 @@+const test = require("node:test");+const assert = require("node:assert/strict");+const fs = require("fs");+const os = require("os");+const path = require("path");++let userDataDir;+const electronPath = require.resolve("electron");+require.cache[electronPath] = {+ exports: {+ app: {+ getPath: () => userDataDir,+ },+ },+};++const { write, clear, readAll } = require("../../src/helpers/sidecarPidFile");++function createUserDataDir(t) {+ const dir = fs.mkdtempSync(path.join(os.tmpdir(), "ow-sidecar-pids-"));+ userDataDir = dir;+ t.after(() => fs.rmSync(dir, { recursive: true, force: true }));+ return path.join(dir, "sidecar-pids");+}++test("an unreadable PID entry does not hide valid sidecar entries", (t) => {+ const pidDir = createUserDataDir(t);+ fs.mkdirSync(pidDir);+ fs.writeFileSync(path.join(pidDir, "qdrant.pid"), "1234");+ fs.mkdirSync(path.join(pidDir, "broken.pid"));++ assert.deepEqual(readAll(), [{ name: "qdrant", pid: 1234 }]);+});++test("an unreadable PID registry is treated as empty", (t) => {+ const pidDir = createUserDataDir(t);+ fs.writeFileSync(pidDir, "not a directory");++ assert.deepEqual(readAll(), []);+});++test("missing, malformed, and unrelated entries are ignored", (t) => {+ const pidDir = createUserDataDir(t);+ assert.deepEqual(readAll(), []);++ fs.mkdirSync(pidDir);+ fs.writeFileSync(path.join(pidDir, "zero.pid"), "0");+ fs.writeFileSync(path.join(pidDir, "fraction.pid"), "12.5");+ fs.writeFileSync(path.join(pidDir, "text.pid"), "not-a-pid");+ fs.writeFileSync(path.join(pidDir, "notes.txt"), "5678");++ assert.deepEqual(readAll(), []);+});++test("valid PID entries still round-trip through write, read, and clear", (t) => {+ createUserDataDir(t);++ write("whisper", 4321);+ assert.deepEqual(readAll(), [{ name: "whisper", pid: 4321 }]);++ clear("whisper");+ assert.deepEqual(readAll(), []);+});