Skip to content

Voice-to-text dictation app with local (Nvidia Parakeet/Whisper) and cloud models (BYOK). Privacy-first and available cross-platform.

fix(desktop): fall back to JS extraction when system unzip is unavailable (#775)

Alcahest38e832d23dbd
diff --git a/src/helpers/downloadUtils.js b/src/helpers/downloadUtils.js
index 0916da299..6166aefa4 100644
--- a/src/helpers/downloadUtils.js
+++ b/src/helpers/downloadUtils.js
@@ -451,7 +451,15 @@ function extractArchive(archivePath, destDir) {
return new Promise((resolve, reject) => {
execFile("unzip", ["-o", archivePath, "-d", destDir], (err) => {
- err ? reject(new Error(`Extraction failed: ${err.message}`)) : resolve();
+ if (!err) return resolve();
+ debugLogger.info("system unzip failed, using JS extraction", { error: err.message });
+ const unzipper = require("unzipper");
+ fs.createReadStream(archivePath)
+ .pipe(unzipper.Extract({ path: destDir }))
+ .on("close", resolve)
+ .on("error", (extractErr) =>
+ reject(new Error(`Zip extraction failed: ${extractErr.message}`))
+ );
});
});
}
diff --git a/test/helpers/extractArchive.test.js b/test/helpers/extractArchive.test.js
new file mode 100644
index 000000000..74185680c
--- /dev/null
+++ b/test/helpers/extractArchive.test.js
@@ -0,0 +1,100 @@
+const test = require("node:test");
+const assert = require("node:assert/strict");
+const fs = require("fs");
+const path = require("path");
+const os = require("os");
+const cp = require("child_process");
+
+// Minimal valid zip: single file "test-file.txt" containing "hello from test\n"
+const ZIP_FIXTURE_B64 =
+ "UEsDBAoAAAAAAEwFr1xBZFoiEAAAABAAAAANABwAdGVzdC1maWxlLnR4dFVUCQADz08G" +
+ "as9PBmp1eAsAAQToAwAABOgDAABoZWxsbyBmcm9tIHRlc3QKUEsBAh4DCgAAAAAATAWv" +
+ "XEFkWiIQAAAAEAAAAA0AGAAAAAAAAQAAAKSBAAAAAHRlc3QtZmlsZS50eHRVVAUAA89P" +
+ "Bmp1eAsAAQToAwAABOgDAABQSwUGAAAAAAEAAQBTAAAAVwAAAAAA";
+
+function makeTmpDir() {
+ return fs.mkdtempSync(path.join(os.tmpdir(), "extractArchive-test-"));
+}
+
+function writeZip(dir, name, buf) {
+ const p = path.join(dir, name);
+ fs.writeFileSync(p, buf);
+ return p;
+}
+
+function freshRequire() {
+ delete require.cache[require.resolve("../../src/helpers/downloadUtils.js")];
+ return require("../../src/helpers/downloadUtils.js");
+}
+
+test("extractArchive extracts a zip file on Linux", async () => {
+ const tmp = makeTmpDir();
+ try {
+ const zipPath = writeZip(tmp, "test.zip", Buffer.from(ZIP_FIXTURE_B64, "base64"));
+ const dest = path.join(tmp, "out");
+ fs.mkdirSync(dest);
+
+ const { extractArchive } = freshRequire();
+ await extractArchive(zipPath, dest);
+
+ const content = fs.readFileSync(path.join(dest, "test-file.txt"), "utf8");
+ assert.equal(content.trim(), "hello from test");
+ } finally {
+ fs.rmSync(tmp, { recursive: true, force: true });
+ }
+});
+
+test("extractArchive falls back to unzipper when system unzip is unavailable", async () => {
+ const origExecFile = cp.execFile;
+ cp.execFile = function (cmd, _args, cb) {
+ if (cmd === "unzip") {
+ const err = new Error("spawn unzip ENOENT");
+ err.code = "ENOENT";
+ return cb(err);
+ }
+ return origExecFile.apply(this, arguments);
+ };
+
+ const tmp = makeTmpDir();
+ try {
+ const zipPath = writeZip(tmp, "test.zip", Buffer.from(ZIP_FIXTURE_B64, "base64"));
+ const dest = path.join(tmp, "out");
+ fs.mkdirSync(dest);
+
+ const { extractArchive } = freshRequire();
+ await extractArchive(zipPath, dest);
+
+ const content = fs.readFileSync(path.join(dest, "test-file.txt"), "utf8");
+ assert.equal(content.trim(), "hello from test");
+ } finally {
+ cp.execFile = origExecFile;
+ freshRequire();
+ fs.rmSync(tmp, { recursive: true, force: true });
+ }
+});
+
+test("extractArchive rejects on corrupt zip when both extraction methods fail", async () => {
+ const origExecFile = cp.execFile;
+ cp.execFile = function (cmd, _args, cb) {
+ if (cmd === "unzip") {
+ return cb(new Error("spawn unzip ENOENT"));
+ }
+ return origExecFile.apply(this, arguments);
+ };
+
+ const tmp = makeTmpDir();
+ try {
+ const zipPath = writeZip(tmp, "corrupt.zip", Buffer.from("not a zip file"));
+ const dest = path.join(tmp, "out");
+ fs.mkdirSync(dest);
+
+ const { extractArchive } = freshRequire();
+ await assert.rejects(() => extractArchive(zipPath, dest), {
+ message: /[Zz]ip extraction failed/,
+ });
+ } finally {
+ cp.execFile = origExecFile;
+ freshRequire();
+ fs.rmSync(tmp, { recursive: true, force: true });
+ }
+});