Skip to content

Voice-to-text dictation app with local (Nvidia Parakeet/Whisper) and cloud models (BYOK). Privacy-first and available cross-platform.

fix(ci): stop the two tests jobs from sharing a name and disagreeing (#1745)

Aditya Painuli43b30fbe0ff5
diff --git a/.github/workflows/build-and-notarize.yml b/.github/workflows/build-and-notarize.yml
index ea5ec23f0..2623ba16f 100644
--- a/.github/workflows/build-and-notarize.yml
+++ b/.github/workflows/build-and-notarize.yml
@@ -16,7 +16,7 @@ on:
workflow_dispatch:
jobs:
- tests:
+ quality:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
@@ -34,8 +34,15 @@ jobs:
- name: Build better-sqlite3 for the runner's node
# --ignore-scripts skips the native build; DB-backed tests silently
# skip without it. This job is the only test gate on push to main.
+ # Guarded like the test step below, or the rebuild is skipped and the
+ # suite then fails REQUIRE_DB_TESTS on a missing binding instead.
+ if: ${{ !cancelled() }}
run: npm rebuild better-sqlite3
- name: Run tests
+ # The gates above fail on drift that has nothing to do with the suite —
+ # a stray format nit, a missing locale key, a fresh advisory. Without
+ # this, main goes untested for as long as the drift stands (#1735).
+ if: ${{ !cancelled() }}
run: npm test
env:
# keeps require("electron") from throwing when postinstall was skipped
@@ -44,7 +51,7 @@ jobs:
REQUIRE_DB_TESTS: "1"
build-linux:
- needs: tests
+ needs: quality
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
@@ -135,7 +142,7 @@ jobs:
retention-days: 7
build-windows:
- needs: tests
+ needs: quality
runs-on: windows-latest
steps:
- uses: actions/checkout@v4
@@ -251,7 +258,7 @@ jobs:
retention-days: 7
build-macos:
- needs: tests
+ needs: quality
runs-on: macos-latest
strategy:
fail-fast: false
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 26befd5ef..63de7a633 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -4,7 +4,7 @@ on:
pull_request:
jobs:
- tests:
+ pr-quality:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
@@ -17,9 +17,19 @@ jobs:
# --ignore-scripts skips the native build, so every DB-backed test
# (snippetsDatabase, noteCloudUpsertGuard, …) silently skips without this.
run: npm rebuild better-sqlite3
- - name: Typecheck
- run: npm run typecheck
+ - name: Quality checks
+ # format:check + typecheck — the same gate build-and-notarize runs, so
+ # the two workflows can't disagree about whether a PR passed (#1735).
+ run: npm run quality-check
+ - name: Check translations
+ run: npm run i18n:check
+ - name: Audit dependencies
+ run: npm audit
- name: Run tests
+ # The gates above fail on drift that has nothing to do with the suite —
+ # a stray format nit, a missing locale key, a fresh advisory. Without
+ # this the job stops there and the PR reports no test result at all.
+ if: ${{ !cancelled() }}
run: npm test
env:
# keeps require("electron") from throwing when postinstall was skipped