Skip to content

Voice-to-text dictation app with local (Nvidia Parakeet/Whisper) and cloud models (BYOK). Privacy-first and available cross-platform.

fix(streaming): reject premature AssemblyAI closes (#1240)

Henry Su5ae167a75ce4
diff --git a/src/helpers/assemblyAiStreaming.js b/src/helpers/assemblyAiStreaming.js
index b6702c264..0bae9b1d3 100644
--- a/src/helpers/assemblyAiStreaming.js
+++ b/src/helpers/assemblyAiStreaming.js
@@ -132,7 +132,10 @@ class AssemblyAiStreaming {
debugLogger.debug("AssemblyAI warming up connection");
return new Promise((resolve, reject) => {
+ let settled = false;
const warmupTimeout = setTimeout(() => {
+ if (settled) return;
+ settled = true;
this.cleanupWarmConnection();
reject(new Error("AssemblyAI warmup connection timeout"));
}, WEBSOCKET_TIMEOUT_MS);
@@ -146,7 +149,8 @@ class AssemblyAiStreaming {
this.warmConnection.on("message", (data) => {
try {
const message = JSON.parse(data.toString());
- if (message.type === "Begin") {
+ if (message.type === "Begin" && !settled) {
+ settled = true;
clearTimeout(warmupTimeout);
this.warmConnectionReady = true;
this.warmSessionId = message.id || null;
@@ -163,7 +167,10 @@ class AssemblyAiStreaming {
clearTimeout(warmupTimeout);
debugLogger.error("AssemblyAI warmup connection error", { error: error.message });
this.cleanupWarmConnection();
- reject(error);
+ if (!settled) {
+ settled = true;
+ reject(error);
+ }
});
this.warmConnection.on("close", (code, reason) => {
@@ -177,6 +184,11 @@ class AssemblyAiStreaming {
reason: reason?.toString(),
});
this.cleanupWarmConnection();
+ if (!settled) {
+ settled = true;
+ reject(new Error(`AssemblyAI warmup connection closed before ready (code: ${code})`));
+ return;
+ }
if (wasReady && savedOptions) {
this.warmConnectionOptions = savedOptions;
this.scheduleRewarm();
@@ -355,6 +367,11 @@ class AssemblyAiStreaming {
reason: reason?.toString(),
wasActive,
});
+ if (this.pendingReject) {
+ this.pendingReject(new Error(`AssemblyAI WebSocket closed before ready (code: ${code})`));
+ this.pendingReject = null;
+ this.pendingResolve = null;
+ }
this.cleanup();
if (wasActive && !this.isDisconnecting) {
this.onError?.(new Error(`Connection lost (code: ${code})`));
diff --git a/test/helpers/assemblyAiStreaming.test.js b/test/helpers/assemblyAiStreaming.test.js
new file mode 100644
index 000000000..f681fc473
--- /dev/null
+++ b/test/helpers/assemblyAiStreaming.test.js
@@ -0,0 +1,91 @@
+const test = require("node:test");
+const assert = require("node:assert/strict");
+const { WebSocketServer } = require("ws");
+
+const AssemblyAiStreaming = require("../../src/helpers/assemblyAiStreaming");
+
+async function withPrematureCloseServer(run) {
+ const server = new WebSocketServer({ host: "127.0.0.1", port: 0 });
+ await new Promise((resolve) => server.once("listening", resolve));
+ server.on("connection", (socket) => {
+ socket.close(1008, "rejected before Begin");
+ });
+
+ try {
+ await run(`ws://127.0.0.1:${server.address().port}`);
+ } finally {
+ await new Promise((resolve) => server.close(resolve));
+ }
+}
+
+async function withBeginServer(run) {
+ const server = new WebSocketServer({ host: "127.0.0.1", port: 0 });
+ await new Promise((resolve) => server.once("listening", resolve));
+ server.on("connection", (socket) => {
+ socket.send(JSON.stringify({ type: "Begin", id: "test-session" }));
+ });
+
+ try {
+ await run(`ws://127.0.0.1:${server.address().port}`);
+ } finally {
+ await new Promise((resolve) => server.close(resolve));
+ }
+}
+
+test("warmup rejects when the socket closes before Begin", async () => {
+ await withPrematureCloseServer(async (url) => {
+ const streaming = new AssemblyAiStreaming();
+ streaming.buildWebSocketUrl = () => url;
+
+ try {
+ await assert.rejects(() => streaming.warmup({ token: "test-token" }), /closed.*1008/i);
+ } finally {
+ streaming.cleanupAll();
+ }
+ });
+});
+
+test("connect rejects when the socket closes before Begin", async () => {
+ await withPrematureCloseServer(async (url) => {
+ const streaming = new AssemblyAiStreaming();
+ streaming.buildWebSocketUrl = () => url;
+
+ try {
+ await assert.rejects(() => streaming.connect({ token: "test-token" }), /closed.*1008/i);
+ } finally {
+ streaming.cleanupAll();
+ }
+ });
+});
+
+test("warmup resolves when the server sends Begin", async () => {
+ await withBeginServer(async (url) => {
+ const streaming = new AssemblyAiStreaming();
+ streaming.buildWebSocketUrl = () => url;
+
+ try {
+ await streaming.warmup({ token: "test-token" });
+
+ assert.equal(streaming.hasWarmConnection(), true);
+ assert.equal(streaming.warmSessionId, "test-session");
+ } finally {
+ streaming.cleanupAll();
+ }
+ });
+});
+
+test("connect resolves when the server sends Begin", async () => {
+ await withBeginServer(async (url) => {
+ const streaming = new AssemblyAiStreaming();
+ streaming.buildWebSocketUrl = () => url;
+
+ try {
+ await streaming.connect({ token: "test-token" });
+
+ assert.equal(streaming.isConnected, true);
+ assert.equal(streaming.sessionId, "test-session");
+ } finally {
+ streaming.cleanupAll();
+ }
+ });
+});