Skip to content

Voice-to-text dictation app with local (Nvidia Parakeet/Whisper) and cloud models (BYOK). Privacy-first and available cross-platform.

fix(notes): route Generate Notes through Note Formatting scope (#788)

St John Grimbly69940a2bea9e
diff --git a/src/components/notes/PersonalNotesView.tsx b/src/components/notes/PersonalNotesView.tsx
index c448ec538..dc9ad5b8a 100644
--- a/src/components/notes/PersonalNotesView.tsx
+++ b/src/components/notes/PersonalNotesView.tsx
@@ -46,7 +46,11 @@ import ActionPicker from "./ActionPicker";
import ActionManagerDialog from "./ActionManagerDialog";
import AddNotesToFolderDialog from "./AddNotesToFolderDialog";
import { useActionProcessing } from "../../hooks/useActionProcessing";
-import { useSettingsStore, selectIsCloudCleanupMode } from "../../stores/settingsStore";
+import {
+ useSettingsStore,
+ selectIsCloudNoteFormattingMode,
+ selectResolvedNoteFormatting,
+} from "../../stores/settingsStore";
import { useFolderManagement } from "../../hooks/useFolderManagement";
import { useNoteDragAndDrop } from "../../hooks/useNoteDragAndDrop";
import { cn } from "../lib/utils";
@@ -135,8 +139,8 @@ export default function PersonalNotesView({
setSyncedNoteIdState(id);
};
const { toast } = useToast();
- const isCloudMode = useSettingsStore(selectIsCloudCleanupMode);
- const effectiveModelId = useSettingsStore((s) => s.cleanupModel);
+ const isCloudMode = useSettingsStore(selectIsCloudNoteFormattingMode);
+ const effectiveModelId = useSettingsStore((s) => selectResolvedNoteFormatting(s).model);
const noteFilesEnabled = useSettingsStore((s) => s.noteFilesEnabled);
const fileManagerName = navigator.platform.startsWith("Mac")
? "Finder"
diff --git a/src/stores/actionProcessingStore.ts b/src/stores/actionProcessingStore.ts
index f590d6023..df28b656d 100644
--- a/src/stores/actionProcessingStore.ts
+++ b/src/stores/actionProcessingStore.ts
@@ -1,6 +1,6 @@
import { create } from "zustand";
import reasoningService from "../services/ReasoningService";
-import { getEffectiveCleanupModel, getSettings } from "./settingsStore";
+import { getSettings } from "./settingsStore";
import { appendDictionarySuffix } from "../config/prompts";
import { generateNoteTitle } from "../utils/generateTitle";
import type { ActionItem } from "../types/electron";
@@ -109,7 +109,7 @@ export function runBackgroundAction(
): void {
if (processingFlags.get(noteId)) return;
- const modelId = getEffectiveCleanupModel() || options.modelId;
+ const modelId = options.modelId;
if (!modelId && !options.isCloudMode) {
pushErrorEvent({ noteId, message: labels.noModel });
return;
diff --git a/src/stores/settingsStore.ts b/src/stores/settingsStore.ts
index 6e7d0076e..403780a1b 100644
--- a/src/stores/settingsStore.ts
+++ b/src/stores/settingsStore.ts
@@ -1455,6 +1455,11 @@ export const selectIsCloudChatAgentMode = (state: SettingsState) =>
state.chatAgentMode === "openwhispr" &&
state.chatAgentCloudMode === "openwhispr";
+export const selectIsCloudNoteFormattingMode = (state: SettingsState) => {
+ const cfg = selectResolvedNoteFormatting(state);
+ return state.isSignedIn && cfg.mode === "openwhispr" && cfg.cloudMode === "openwhispr";
+};
+
export interface ResolvedMeetingTranscription {
useLocalWhisper: boolean;
whisperModel: string;