Skip to content

Voice-to-text dictation app with local (Nvidia Parakeet/Whisper) and cloud models (BYOK). Privacy-first and available cross-platform.

fix(workspaces): confirm destructive actions across teams/members/keys/invitations

Gabriel Stein783aec308ed4
diff --git a/src/components/settings/WorkspaceDeveloperTab.tsx b/src/components/settings/WorkspaceDeveloperTab.tsx
index 385a6dba5..e393b936c 100644
--- a/src/components/settings/WorkspaceDeveloperTab.tsx
+++ b/src/components/settings/WorkspaceDeveloperTab.tsx
@@ -6,6 +6,7 @@ import { Input } from "../ui/input";
import { Label } from "../ui/label";
import { useToast } from "../ui/useToast";
import {
+ ConfirmDialog,
Dialog,
DialogContent,
DialogHeader,
@@ -13,6 +14,7 @@ import {
DialogDescription,
DialogFooter,
} from "../ui/dialog";
+import { useDialogs } from "../../hooks/useDialogs";
import { WorkspaceApiKeysService } from "../../services/WorkspaceApiKeysService";
import type { Workspace, WorkspaceApiKey, NewWorkspaceApiKey } from "../../types/electron";
import { cn } from "../lib/utils";
@@ -21,45 +23,46 @@ interface Props {
workspace: Workspace;
}
-const SCOPE_GROUPS: { title: string; scopes: { id: string; label: string }[] }[] = [
+const SCOPE_GROUPS_DEF: { groupKey: string; scopes: { id: string; labelKey: string }[] }[] = [
{
- title: "Notes",
+ groupKey: "notes",
scopes: [
- { id: "workspace:notes:read", label: "Read notes" },
- { id: "workspace:notes:write", label: "Write notes" },
+ { id: "workspace:notes:read", labelKey: "read" },
+ { id: "workspace:notes:write", labelKey: "write" },
],
},
{
- title: "Folders",
+ groupKey: "folders",
scopes: [
- { id: "workspace:folders:read", label: "Read folders" },
- { id: "workspace:folders:write", label: "Write folders" },
+ { id: "workspace:folders:read", labelKey: "read" },
+ { id: "workspace:folders:write", labelKey: "write" },
],
},
{
- title: "Transcriptions",
- scopes: [{ id: "workspace:transcriptions:read", label: "Read transcriptions" }],
+ groupKey: "transcriptions",
+ scopes: [{ id: "workspace:transcriptions:read", labelKey: "read" }],
},
{
- title: "Members",
+ groupKey: "members",
scopes: [
- { id: "workspace:members:read", label: "Read members" },
- { id: "workspace:members:write", label: "Manage members" },
+ { id: "workspace:members:read", labelKey: "read" },
+ { id: "workspace:members:write", labelKey: "write" },
],
},
{
- title: "Billing",
- scopes: [{ id: "workspace:billing:read", label: "Read billing" }],
+ groupKey: "billing",
+ scopes: [{ id: "workspace:billing:read", labelKey: "read" }],
},
{
- title: "Full access",
- scopes: [{ id: "workspace:*", label: "Workspace admin" }],
+ groupKey: "full",
+ scopes: [{ id: "workspace:*", labelKey: "admin" }],
},
];
export default function WorkspaceDeveloperTab({ workspace }: Props) {
const { t } = useTranslation();
const { toast } = useToast();
+ const { confirmDialog, showConfirmDialog, hideConfirmDialog } = useDialogs();
const [keys, setKeys] = useState<WorkspaceApiKey[]>([]);
const [createOpen, setCreateOpen] = useState(false);
const [newKey, setNewKey] = useState<NewWorkspaceApiKey | null>(null);
@@ -116,17 +119,27 @@ export default function WorkspaceDeveloperTab({ workspace }: Props) {
}
}
- async function handleRevoke(keyId: string) {
- try {
- await WorkspaceApiKeysService.revoke(workspace.id, keyId);
- await refresh();
- } catch (error) {
- toast({
- title: t("common.error"),
- description: error instanceof Error ? error.message : t("common.unknownError"),
- variant: "destructive",
- });
- }
+ function confirmRevoke(key: WorkspaceApiKey) {
+ showConfirmDialog({
+ title: t("settingsPage.workspace.developer.revokeConfirm.title"),
+ description: t("settingsPage.workspace.developer.revokeConfirm.description", {
+ name: key.name,
+ }),
+ confirmText: t("settingsPage.workspace.developer.revoke"),
+ variant: "destructive",
+ onConfirm: async () => {
+ try {
+ await WorkspaceApiKeysService.revoke(workspace.id, key.id);
+ await refresh();
+ } catch (error) {
+ toast({
+ title: t("common.error"),
+ description: error instanceof Error ? error.message : t("common.unknownError"),
+ variant: "destructive",
+ });
+ }
+ },
+ });
}
async function handleCopy() {
@@ -182,7 +195,7 @@ export default function WorkspaceDeveloperTab({ workspace }: Props) {
{canManage && (
<button
type="button"
- onClick={() => handleRevoke(k.id)}
+ onClick={() => confirmRevoke(k)}
aria-label={t("settingsPage.workspace.developer.revoke")}
className="p-1 rounded-md text-muted-foreground hover:text-destructive hover:bg-destructive/8 outline-none focus-visible:ring-1 focus-visible:ring-primary/30"
>
@@ -216,10 +229,10 @@ export default function WorkspaceDeveloperTab({ workspace }: Props) {
/>
</div>
<div className="space-y-2 max-h-72 overflow-y-auto">
- {SCOPE_GROUPS.map((group) => (
- <div key={group.title} className="space-y-1.5">
+ {SCOPE_GROUPS_DEF.map((group) => (
+ <div key={group.groupKey} className="space-y-1.5">
<p className="text-[10px] uppercase tracking-wide text-muted-foreground font-medium">
- {group.title}
+ {t(`settingsPage.workspace.developer.scopes.${group.groupKey}.title`)}
</p>
<div className="flex flex-wrap gap-1.5">
{group.scopes.map((s) => {
@@ -237,7 +250,9 @@ export default function WorkspaceDeveloperTab({ workspace }: Props) {
: "border-border/60 text-muted-foreground hover:bg-foreground/4 hover:text-foreground"
)}
>
- {s.label}
+ {t(
+ `settingsPage.workspace.developer.scopes.${group.groupKey}.${s.labelKey}`
+ )}
</button>
);
})}
@@ -265,6 +280,17 @@ export default function WorkspaceDeveloperTab({ workspace }: Props) {
</DialogContent>
</Dialog>
+ <ConfirmDialog
+ open={confirmDialog.open}
+ onOpenChange={(open) => !open && hideConfirmDialog()}
+ title={confirmDialog.title}
+ description={confirmDialog.description}
+ confirmText={confirmDialog.confirmText}
+ cancelText={confirmDialog.cancelText}
+ onConfirm={confirmDialog.onConfirm}
+ variant={confirmDialog.variant}
+ />
+
<Dialog open={!!newKey} onOpenChange={(open) => !open && setNewKey(null)}>
<DialogContent className="max-w-lg">
<DialogHeader>
diff --git a/src/components/settings/WorkspaceMembersTab.tsx b/src/components/settings/WorkspaceMembersTab.tsx
index 0debf7b5e..f8664ecd8 100644
--- a/src/components/settings/WorkspaceMembersTab.tsx
+++ b/src/components/settings/WorkspaceMembersTab.tsx
@@ -4,9 +4,11 @@ import { Trash2, MoreVertical, Mail, X } from "lucide-react";
import { useWorkspaceStore } from "../../stores/workspaceStore";
import { WorkspacesService } from "../../services/WorkspacesService";
import { InvitationsService } from "../../services/InvitationsService";
+import { useDialogs } from "../../hooks/useDialogs";
import { Button } from "../ui/button";
+import { ConfirmDialog } from "../ui/dialog";
import { useToast } from "../ui/useToast";
-import type { Workspace, WorkspaceInvitation } from "../../types/electron";
+import type { Workspace, WorkspaceInvitation, WorkspaceMember } from "../../types/electron";
import InviteTeammateDialog from "../InviteTeammateDialog";
import {
DropdownMenu,
@@ -23,6 +25,7 @@ interface Props {
export default function WorkspaceMembersTab({ workspace }: Props) {
const { t } = useTranslation();
const { toast } = useToast();
+ const { confirmDialog, showConfirmDialog, hideConfirmDialog } = useDialogs();
const members = useWorkspaceStore((s) => s.members);
const refreshMembers = useWorkspaceStore((s) => s.refreshMembers);
const [invitations, setInvitations] = useState<WorkspaceInvitation[]>([]);
@@ -60,26 +63,51 @@ export default function WorkspaceMembersTab({ workspace }: Props) {
}
}
- async function handleRemove(userId: string) {
- try {
- await WorkspacesService.removeMember(workspace.id, userId);
- await refreshMembers(workspace.id);
- } catch (error) {
- toast({
- title: t("common.error"),
- description: error instanceof Error ? error.message : t("common.unknownError"),
- variant: "destructive",
- });
- }
+ function confirmRemoveMember(member: WorkspaceMember) {
+ showConfirmDialog({
+ title: t("settingsPage.workspace.members.removeConfirm.title"),
+ description: t("settingsPage.workspace.members.removeConfirm.description", {
+ name: member.name || member.email,
+ workspace: workspace.name,
+ }),
+ confirmText: t("settingsPage.workspace.members.remove"),
+ variant: "destructive",
+ onConfirm: async () => {
+ try {
+ await WorkspacesService.removeMember(workspace.id, member.user_id);
+ await refreshMembers(workspace.id);
+ } catch (error) {
+ toast({
+ title: t("common.error"),
+ description: error instanceof Error ? error.message : t("common.unknownError"),
+ variant: "destructive",
+ });
+ }
+ },
+ });
}
- async function handleRevoke(inviteId: string) {
- try {
- await InvitationsService.revoke(workspace.id, inviteId);
- await refreshInvitations();
- } catch {
- // toast handled inline
- }
+ function confirmRevokeInvitation(inv: WorkspaceInvitation) {
+ showConfirmDialog({
+ title: t("settingsPage.workspace.invites.revokeConfirm.title"),
+ description: t("settingsPage.workspace.invites.revokeConfirm.description", {
+ email: inv.email,
+ }),
+ confirmText: t("settingsPage.workspace.invites.revoke"),
+ variant: "destructive",
+ onConfirm: async () => {
+ try {
+ await InvitationsService.revoke(workspace.id, inv.id);
+ await refreshInvitations();
+ } catch (error) {
+ toast({
+ title: t("settingsPage.workspace.invites.revokeFailed"),
+ description: error instanceof Error ? error.message : t("common.unknownError"),
+ variant: "destructive",
+ });
+ }
+ },
+ });
}
async function handleResend(inviteId: string) {
@@ -175,7 +203,7 @@ export default function WorkspaceMembersTab({ workspace }: Props) {
)}
<DropdownMenuItem
className="text-destructive"
- onSelect={() => handleRemove(member.user_id)}
+ onSelect={() => confirmRemoveMember(member)}
>
<Trash2 className="mr-1.5 h-3.5 w-3.5" />
{t("settingsPage.workspace.members.remove")}
@@ -217,7 +245,7 @@ export default function WorkspaceMembersTab({ workspace }: Props) {
</Button>
<button
type="button"
- onClick={() => handleRevoke(inv.id)}
+ onClick={() => confirmRevokeInvitation(inv)}
aria-label={t("settingsPage.workspace.invites.revoke")}
className="p-1 rounded-md text-muted-foreground hover:text-destructive hover:bg-destructive/8 transition-colors outline-none focus-visible:ring-1 focus-visible:ring-primary/30"
>
@@ -236,6 +264,17 @@ export default function WorkspaceMembersTab({ workspace }: Props) {
workspaceName={workspace.name}
onInvited={refreshInvitations}
/>
+
+ <ConfirmDialog
+ open={confirmDialog.open}
+ onOpenChange={(open) => !open && hideConfirmDialog()}
+ title={confirmDialog.title}
+ description={confirmDialog.description}
+ confirmText={confirmDialog.confirmText}
+ cancelText={confirmDialog.cancelText}
+ onConfirm={confirmDialog.onConfirm}
+ variant={confirmDialog.variant}
+ />
</div>
);
}
diff --git a/src/components/settings/WorkspaceTeamsTab.tsx b/src/components/settings/WorkspaceTeamsTab.tsx
index cd5b18c09..da20b012f 100644
--- a/src/components/settings/WorkspaceTeamsTab.tsx
+++ b/src/components/settings/WorkspaceTeamsTab.tsx
@@ -3,11 +3,19 @@ import { useTranslation } from "react-i18next";
import { Plus, Users, Trash2 } from "lucide-react";
import { useWorkspaceStore } from "../../stores/workspaceStore";
import { TeamsService } from "../../services/TeamsService";
+import { useDialogs } from "../../hooks/useDialogs";
import { Button } from "../ui/button";
import { Input } from "../ui/input";
import { Label } from "../ui/label";
import { useToast } from "../ui/useToast";
-import { Dialog, DialogContent, DialogHeader, DialogTitle, DialogFooter } from "../ui/dialog";
+import {
+ ConfirmDialog,
+ Dialog,
+ DialogContent,
+ DialogHeader,
+ DialogTitle,
+ DialogFooter,
+} from "../ui/dialog";
import type { Workspace, Team } from "../../types/electron";
interface Props {
@@ -17,6 +25,7 @@ interface Props {
export default function WorkspaceTeamsTab({ workspace }: Props) {
const { t } = useTranslation();
const { toast } = useToast();
+ const { confirmDialog, showConfirmDialog, hideConfirmDialog } = useDialogs();
const teams = useWorkspaceStore((s) => s.teams);
const refreshTeams = useWorkspaceStore((s) => s.refreshTeams);
const [createOpen, setCreateOpen] = useState(false);
@@ -54,17 +63,25 @@ export default function WorkspaceTeamsTab({ workspace }: Props) {
}
}
- async function handleDelete(team: Team) {
- try {
- await TeamsService.remove(team.id);
- await refreshTeams(workspace.id);
- } catch (error) {
- toast({
- title: t("common.error"),
- description: error instanceof Error ? error.message : t("common.unknownError"),
- variant: "destructive",
- });
- }
+ function confirmDelete(team: Team) {
+ showConfirmDialog({
+ title: t("settingsPage.workspace.teams.deleteConfirm.title"),
+ description: t("settingsPage.workspace.teams.deleteConfirm.description", { name: team.name }),
+ confirmText: t("common.delete"),
+ variant: "destructive",
+ onConfirm: async () => {
+ try {
+ await TeamsService.remove(team.id);
+ await refreshTeams(workspace.id);
+ } catch (error) {
+ toast({
+ title: t("common.error"),
+ description: error instanceof Error ? error.message : t("common.unknownError"),
+ variant: "destructive",
+ });
+ }
+ },
+ });
}
return (
@@ -114,7 +131,7 @@ export default function WorkspaceTeamsTab({ workspace }: Props) {
{canManage && (
<button
type="button"
- onClick={() => handleDelete(team)}
+ onClick={() => confirmDelete(team)}
aria-label={t("common.delete")}
className="p-1 rounded-md text-muted-foreground hover:text-destructive hover:bg-destructive/8 transition-colors outline-none focus-visible:ring-1 focus-visible:ring-primary/30"
>
@@ -125,6 +142,17 @@ export default function WorkspaceTeamsTab({ workspace }: Props) {
))}
</div>
+ <ConfirmDialog
+ open={confirmDialog.open}
+ onOpenChange={(open) => !open && hideConfirmDialog()}
+ title={confirmDialog.title}
+ description={confirmDialog.description}
+ confirmText={confirmDialog.confirmText}
+ cancelText={confirmDialog.cancelText}
+ onConfirm={confirmDialog.onConfirm}
+ variant={confirmDialog.variant}
+ />
+
<Dialog open={createOpen} onOpenChange={setCreateOpen}>
<DialogContent className="max-w-md">
<DialogHeader>