Skip to content

Voice-to-text dictation app with local (Nvidia Parakeet/Whisper) and cloud models (BYOK). Privacy-first and available cross-platform.

ci: Consolidate PR checks and cancel superseded runs (#2219)

Chad Piha834a0771fea1
diff --git a/.github/workflows/build-and-notarize.yml b/.github/workflows/build-and-notarize.yml
index 5607e485e..3d6935d5a 100644
--- a/.github/workflows/build-and-notarize.yml
+++ b/.github/workflows/build-and-notarize.yml
@@ -8,21 +8,39 @@ on:
- "LICENSE"
- ".github/ISSUE_TEMPLATE/**"
pull_request:
- branches: [main]
- paths-ignore:
- - "**.md"
- - "LICENSE"
- - ".github/ISSUE_TEMPLATE/**"
workflow_dispatch:
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
+ cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
jobs:
quality:
runs-on: ubuntu-latest
+ outputs:
+ build: ${{ github.event_name != 'pull_request' || (github.base_ref == 'main' && steps.changes.outputs.build == 'true') }}
steps:
- uses: actions/checkout@v4
+ with:
+ fetch-depth: 2
+ # Quality checks cover every PR; packaging keeps its existing main/code-only scope.
+ - name: Check for desktop build changes
+ id: changes
+ if: github.event_name == 'pull_request' && github.base_ref == 'main'
+ shell: bash
+ run: |
+ # GitHub checks out the PR merge commit; its first parent is the target branch.
+ changed_files=$(git diff --no-renames --name-only HEAD^1 HEAD -- . \
+ ':(glob,exclude)**/*.md' \
+ ':(exclude)LICENSE' \
+ ':(exclude).github/ISSUE_TEMPLATE')
+ if [[ -n "$changed_files" ]]; then
+ echo "build=true" >> "$GITHUB_OUTPUT"
+ fi
- uses: actions/setup-node@v4
with:
node-version-file: .nvmrc
+ cache: "npm"
- name: Install dependencies
run: npm ci --ignore-scripts
- name: Run quality checks
@@ -52,6 +70,7 @@ jobs:
build-linux:
needs: quality
+ if: needs.quality.outputs.build == 'true'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
@@ -137,6 +156,7 @@ jobs:
VITE_OPENWHISPR_OAUTH_CALLBACK_URL: ${{ vars.VITE_OPENWHISPR_OAUTH_CALLBACK_URL }}
- name: Upload Artifacts
+ if: github.event_name != 'pull_request'
uses: actions/upload-artifact@v4
with:
name: linux-build
@@ -145,6 +165,7 @@ jobs:
build-windows:
needs: quality
+ if: needs.quality.outputs.build == 'true'
runs-on: windows-latest
steps:
- uses: actions/checkout@v4
@@ -253,6 +274,7 @@ jobs:
AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
- name: Upload Artifacts
+ if: github.event_name != 'pull_request'
uses: actions/upload-artifact@v4
with:
name: windows-build
@@ -261,6 +283,7 @@ jobs:
build-macos:
needs: quality
+ if: needs.quality.outputs.build == 'true'
runs-on: macos-latest
strategy:
fail-fast: false
@@ -398,6 +421,7 @@ jobs:
node scripts/verify-macos-parakeet.js "$APP_PATH"
- name: Upload Artifacts
+ if: github.event_name != 'pull_request'
uses: actions/upload-artifact@v4
with:
name: macos-${{ matrix.arch }}-build
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
index 047b78a42..c8462f95c 100644
--- a/.github/workflows/codeql.yml
+++ b/.github/workflows/codeql.yml
@@ -8,6 +8,10 @@ on:
schedule:
- cron: "0 6 * * 1"
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
+ cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
jobs:
analyze:
name: Analyze
diff --git a/.github/workflows/lockfile-lint.yml b/.github/workflows/lockfile-lint.yml
index 28872c191..c4b7f63aa 100644
--- a/.github/workflows/lockfile-lint.yml
+++ b/.github/workflows/lockfile-lint.yml
@@ -2,6 +2,14 @@ name: Lockfile Lint
on:
pull_request:
+ paths:
+ - "package.json"
+ - "package-lock.json"
+ - ".github/workflows/lockfile-lint.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
+ cancel-in-progress: ${{ github.event_name == 'pull_request' }}
jobs:
lockfile-lint:
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
deleted file mode 100644
index 14a3a1361..000000000
--- a/.github/workflows/tests.yml
+++ /dev/null
@@ -1,38 +0,0 @@
-name: Tests
-
-on:
- pull_request:
-
-jobs:
- pr-quality:
- runs-on: ubuntu-latest
- steps:
- - uses: actions/checkout@v4
- - uses: actions/setup-node@v4
- with:
- node-version-file: .nvmrc
- - name: Install dependencies
- run: npm ci --ignore-scripts
- - name: Build better-sqlite3 for the runner's node
- # --ignore-scripts skips the native build, so every DB-backed test
- # (snippetsDatabase, noteCloudUpsertGuard, …) silently skips without this.
- run: npm rebuild better-sqlite3
- - name: Quality checks
- # format:check + typecheck — the same gate build-and-notarize runs, so
- # the two workflows can't disagree about whether a PR passed (#1735).
- run: npm run quality-check
- - name: Check translations
- run: npm run i18n:check
- - name: Audit dependencies
- run: npm audit --audit-level=high
- - name: Run tests
- # The gates above fail on drift that has nothing to do with the suite —
- # a stray format nit, a missing locale key, a fresh advisory. Without
- # this the job stops there and the PR reports no test result at all.
- if: ${{ !cancelled() }}
- run: npm test
- env:
- # keeps require("electron") from throwing when postinstall was skipped
- ELECTRON_OVERRIDE_DIST_PATH: /tmp
- # a skipped DB test here means the rebuild step above is gone: fail instead
- REQUIRE_DB_TESTS: "1"