Skip to content

Voice-to-text dictation app with local (Nvidia Parakeet/Whisper) and cloud models (BYOK). Privacy-first and available cross-platform.

fix: click should be the delibrate action to select model for STT models

Idris Gadi90cfe0330759
diff --git a/src/components/OnboardingFlow.tsx b/src/components/OnboardingFlow.tsx
index 02a77630b..08d25bed2 100644
--- a/src/components/OnboardingFlow.tsx
+++ b/src/components/OnboardingFlow.tsx
@@ -630,8 +630,8 @@ export default function OnboardingFlow({ onComplete }: OnboardingFlowProps) {
selectedLocalModel={
localTranscriptionProvider === "nvidia" ? parakeetModel : whisperModel
}
- onLocalModelSelect={(modelId) => {
- if (localTranscriptionProvider === "nvidia") {
+ onLocalModelSelect={(modelId, providerId) => {
+ if (providerId === "nvidia" || (!providerId && localTranscriptionProvider === "nvidia")) {
updateTranscriptionSettings({ parakeetModel: modelId });
} else {
updateTranscriptionSettings({ whisperModel: modelId });
diff --git a/src/components/SettingsPage.tsx b/src/components/SettingsPage.tsx
index e1174a80e..cfe90eb2f 100644
--- a/src/components/SettingsPage.tsx
+++ b/src/components/SettingsPage.tsx
@@ -352,8 +352,8 @@ function TranscriptionSection({
};
const handleLocalModelSelect = useCallback(
- (modelId: string) => {
- if (localTranscriptionProvider === "nvidia") {
+ (modelId: string, providerId?: string) => {
+ if (providerId === "nvidia" || (!providerId && localTranscriptionProvider === "nvidia")) {
setParakeetModel(modelId);
} else {
setWhisperModel(modelId);
diff --git a/src/components/TranscriptionModelPicker.tsx b/src/components/TranscriptionModelPicker.tsx
index 03d64483d..ca24f75dc 100644
--- a/src/components/TranscriptionModelPicker.tsx
+++ b/src/components/TranscriptionModelPicker.tsx
@@ -202,7 +202,7 @@ interface TranscriptionModelPickerProps {
selectedCloudModel: string;
onCloudModelSelect: (modelId: string) => void;
selectedLocalModel: string;
- onLocalModelSelect: (modelId: string) => void;
+ onLocalModelSelect: (modelId: string, providerId?: string) => void;
selectedLocalProvider?: string;
onLocalProviderSelect?: (providerId: string) => void;
useLocalWhisper: boolean;
@@ -380,6 +380,7 @@ export default function TranscriptionModelPicker({
const effectiveLocal = mode === "local" ? true : mode === "cloud" ? false : useLocalWhisper;
const [localModels, setLocalModels] = useState<LocalModel[]>([]);
const [parakeetModels, setParakeetModels] = useState<LocalModel[]>([]);
+ const [browsedCloudProvider, setBrowsedCloudProvider] = useState<string | null>(null);
const [internalLocalProvider, setInternalLocalProvider] = useState(selectedLocalProvider);
const hasLoadedRef = useRef(false);
const hasLoadedParakeetRef = useRef(false);
@@ -446,7 +447,6 @@ export default function TranscriptionModelPicker({
useEffect(() => {
onLocalModelSelectRef.current = onLocalModelSelect;
}, [onLocalModelSelect]);
-
const validateAndSelectModel = useCallback((loadedModels: LocalModel[]) => {
const current = selectedLocalModelRef.current;
if (!current) return;
@@ -513,7 +513,7 @@ export default function TranscriptionModelPicker({
);
return (
reconcileCloudProviderSelection({
- selectedProvider: selectedCloudProvider,
+ selectedProvider: browsedCloudProvider ?? selectedCloudProvider,
selectedModel: selectedCloudModel,
allowedProviders: cloudProviders,
customAllowed: !streamingOnly && providerAllowed("custom"),
@@ -524,6 +524,7 @@ export default function TranscriptionModelPicker({
availableCloudProviders,
cloudProviders,
cloudTranscriptionBaseUrl,
+ browsedCloudProvider,
selectedCloudProvider,
selectedCloudModel,
providerAllowed,
@@ -535,6 +536,7 @@ export default function TranscriptionModelPicker({
useEffect(() => {
if (
effectiveLocal ||
+ browsedCloudProvider ||
!shouldPersistProviderFallback(policyState, isSignedIn) ||
(effectiveCloudSelection.provider === selectedCloudProvider &&
effectiveCloudSelection.model === selectedCloudModel)
@@ -550,6 +552,7 @@ export default function TranscriptionModelPicker({
}, [
effectiveCloudSelection,
effectiveLocal,
+ browsedCloudProvider,
isSignedIn,
onCloudModelSelect,
onCloudProviderSelect,
@@ -751,16 +754,12 @@ export default function TranscriptionModelPicker({
[onModeChange]
);
- // switchCloudTranscriptionProvider writes both the provider and the model for
- // this scope: it remembers the outgoing provider's model and restores the
- // incoming one. It never touches cloudTranscriptionBaseUrl — that key is the
- // Custom tab's only storage, and writing it here destroyed the URL (#1459).
const handleCloudProviderChange = useCallback(
(providerId: string) => {
if (!providerAllowed(providerId)) return;
- switchCloudTranscriptionProvider(transcriptionContext, providerId);
+ setBrowsedCloudProvider(providerId);
},
- [providerAllowed, switchCloudTranscriptionProvider, transcriptionContext]
+ [providerAllowed]
);
const handleLocalProviderChange = useCallback(
@@ -768,25 +767,41 @@ export default function TranscriptionModelPicker({
const tab = LOCAL_PROVIDER_TABS.find((t) => t.id === providerId);
if (tab?.disabled) return;
setInternalLocalProvider(providerId);
- onLocalProviderSelect?.(providerId);
},
- [onLocalProviderSelect]
+ []
+ );
+
+ const handleCloudModelSelect = useCallback(
+ (modelId: string) => {
+ if (displayedCloudProvider !== selectedCloudProvider) {
+ switchCloudTranscriptionProvider(transcriptionContext, displayedCloudProvider);
+ }
+ onCloudModelSelect(modelId);
+ setBrowsedCloudProvider(null);
+ },
+ [
+ displayedCloudProvider,
+ onCloudModelSelect,
+ selectedCloudProvider,
+ switchCloudTranscriptionProvider,
+ transcriptionContext,
+ ]
);
const handleWhisperModelSelect = useCallback(
(modelId: string) => {
- onLocalProviderSelect?.("whisper");
setInternalLocalProvider("whisper");
- onLocalModelSelect(modelId);
+ onLocalProviderSelect?.("whisper");
+ onLocalModelSelect(modelId, "whisper");
},
[onLocalModelSelect, onLocalProviderSelect]
);
const handleParakeetModelSelect = useCallback(
(modelId: string) => {
- onLocalProviderSelect?.("nvidia");
setInternalLocalProvider("nvidia");
- onLocalModelSelect(modelId);
+ onLocalProviderSelect?.("nvidia");
+ onLocalModelSelect(modelId, "nvidia");
},
[onLocalModelSelect, onLocalProviderSelect]
);
@@ -1096,8 +1111,10 @@ export default function TranscriptionModelPicker({
{t("common.model")}
</label>
<Input
- value={displayedCloudModel}
- onChange={(e) => onCloudModelSelect(e.target.value)}
+ value={
+ selectedCloudProvider === displayedCloudProvider ? displayedCloudModel : ""
+ }
+ onChange={(e) => handleCloudModelSelect(e.target.value)}
placeholder="whisper-1"
className="h-8 text-sm"
/>
@@ -1163,8 +1180,10 @@ export default function TranscriptionModelPicker({
</label>
<ModelCardList
models={cloudModelOptions}
- selectedModel={displayedCloudModel}
- onModelSelect={onCloudModelSelect}
+ selectedModel={
+ selectedCloudProvider === displayedCloudProvider ? displayedCloudModel : ""
+ }
+ onModelSelect={handleCloudModelSelect}
colorScheme="purple"
/>
{displayedCloudProvider === "tinfoil" && (
diff --git a/src/components/settings/MeetingSettings.tsx b/src/components/settings/MeetingSettings.tsx
index 364f6cdad..2dac5340e 100644
--- a/src/components/settings/MeetingSettings.tsx
+++ b/src/components/settings/MeetingSettings.tsx
@@ -108,8 +108,8 @@ export function MeetingTranscriptionPanel() {
};
const handleLocalTranscriptionModelSelect = useCallback(
- (modelId: string) => {
- if (meetingLocalTranscriptionProvider === "nvidia") {
+ (modelId: string, providerId?: string) => {
+ if (providerId === "nvidia" || (!providerId && meetingLocalTranscriptionProvider === "nvidia")) {
setMeetingParakeetModel(modelId);
} else {
setMeetingWhisperModel(modelId);
diff --git a/src/components/settings/UploadSettings.tsx b/src/components/settings/UploadSettings.tsx
index c02ff090a..2f007f110 100644
--- a/src/components/settings/UploadSettings.tsx
+++ b/src/components/settings/UploadSettings.tsx
@@ -87,8 +87,8 @@ export function UploadTranscriptionPanel() {
};
const handleLocalTranscriptionModelSelect = useCallback(
- (modelId: string) => {
- if (uploadLocalTranscriptionProvider === "nvidia") {
+ (modelId: string, providerId?: string) => {
+ if (providerId === "nvidia" || (!providerId && uploadLocalTranscriptionProvider === "nvidia")) {
setUploadParakeetModel(modelId);
} else {
setUploadWhisperModel(modelId);