Voice-to-text dictation app with local (Nvidia Parakeet/Whisper) and cloud models (BYOK). Privacy-first and available cross-platform.
JavaScript aianthropiccross-platformgeminigroqlinuxmacosnvidiaopen-sourceopenaiparakeetspeech-to-texttranscribewhisperwindows
fix(notes): parse share-dialog email domains without leftover whitespace (#1683)
Henry Suaad659f2da14
diff --git a/src/utils/personalEmailDomains.ts b/src/utils/personalEmailDomains.tsindex daeb30ad3..67ff81ec4 100644--- a/src/utils/personalEmailDomains.ts+++ b/src/utils/personalEmailDomains.ts@@ -36,10 +36,19 @@ const PERSONAL_EMAIL_DOMAINS = new Set<string>([]);export function emailDomain(email: string): string {- const at = email.indexOf("@");- return at === -1 ? "" : email.slice(at + 1).toLowerCase();+ if (typeof email !== "string") return "";+ const trimmed = email.trim();+ const angle = /<([^<>]+)>/.exec(trimmed);+ const addr = (angle ? angle[1] : trimmed).trim();+ const at = addr.lastIndexOf("@");+ if (at === -1) return "";+ return addr+ .slice(at + 1)+ .trim()+ .toLowerCase();}export function isPersonalEmailDomain(domain: string): boolean {+ if (typeof domain !== "string") return false;return PERSONAL_EMAIL_DOMAINS.has(domain.toLowerCase());}diff --git a/test/helpers/personalEmailDomains.test.js b/test/helpers/personalEmailDomains.test.jsnew file mode 100644index 000000000..89cea142f--- /dev/null+++ b/test/helpers/personalEmailDomains.test.js@@ -0,0 +1,25 @@+const test = require("node:test");+const assert = require("node:assert/strict");++// Requires Node's native TypeScript type-stripping (Node >= 22.6 with+// --experimental-strip-types, on by default in Node 23.6+/24). CI runs Node 24.++const load = () => import("../../src/utils/personalEmailDomains.ts");++test("strips surrounding whitespace before taking the domain", async () => {+ const { emailDomain, isPersonalEmailDomain } = await load();+ assert.equal(emailDomain(" [email protected] "), "gmail.com");+ assert.equal(isPersonalEmailDomain(emailDomain(" [email protected] ")), true);+});++test("reads the mailbox inside display-name angle brackets", async () => {+ const { emailDomain, isPersonalEmailDomain } = await load();+ assert.equal(emailDomain("Jane <[email protected]>"), "acme.com");+ assert.equal(isPersonalEmailDomain(emailDomain("Jane <[email protected]>")), false);+});++test("does not throw on non-string input", async () => {+ const { emailDomain, isPersonalEmailDomain } = await load();+ assert.equal(emailDomain(null), "");+ assert.equal(isPersonalEmailDomain(null), false);+});