Skip to content

Voice-to-text dictation app with local (Nvidia Parakeet/Whisper) and cloud models (BYOK). Privacy-first and available cross-platform.

fix: unify screen recording permission UX across all touchpoints

Gabriel Steinb0257bceb8d8
diff --git a/src/components/OnboardingFlow.tsx b/src/components/OnboardingFlow.tsx
index 1f041fd52..fbe0abf85 100644
--- a/src/components/OnboardingFlow.tsx
+++ b/src/components/OnboardingFlow.tsx
@@ -26,6 +26,7 @@ import { useLocalStorage } from "../hooks/useLocalStorage";
import { useDialogs } from "../hooks/useDialogs";
import { usePermissions } from "../hooks/usePermissions";
import { useClipboard } from "../hooks/useClipboard";
+import { useScreenRecordingPermission } from "../hooks/useScreenRecordingPermission";
import { useSettings } from "../hooks/useSettings";
import LanguageSelector from "./ui/LanguageSelector";
import AuthenticationStep from "./AuthenticationStep";
@@ -125,17 +126,7 @@ export default function OnboardingFlow({ onComplete }: OnboardingFlowProps) {
const permissionsHook = usePermissions(showAlertDialog);
useClipboard(showAlertDialog); // Initialize clipboard hook for permission checks
- const [screenRecordingGranted, setScreenRecordingGranted] = useState(false);
-
- const requestScreenRecording = useCallback(async () => {
- try {
- const stream = await navigator.mediaDevices.getDisplayMedia({ audio: true, video: true });
- stream.getTracks().forEach((t) => t.stop());
- setScreenRecordingGranted(true);
- } catch {
- // User denied or dismissed — not blocking since this is optional
- }
- }, []);
+ const screenRecording = useScreenRecordingPermission();
// For signed-in users, merge setup and permissions into one step
const steps =
@@ -411,9 +402,10 @@ export default function OnboardingFlow({ onComplete }: OnboardingFlowProps) {
icon={Monitor}
title={t("onboarding.permissions.screenRecordingTitle")}
description={t("onboarding.permissions.screenRecordingDescription")}
- granted={screenRecordingGranted}
- onRequest={requestScreenRecording}
+ granted={screenRecording.granted}
+ onRequest={screenRecording.request}
buttonText={t("onboarding.permissions.grant")}
+ onOpenSettings={screenRecording.openSettings}
badge={t("onboarding.permissions.optional")}
/>
</>
@@ -565,9 +557,10 @@ export default function OnboardingFlow({ onComplete }: OnboardingFlowProps) {
icon={Monitor}
title={t("onboarding.permissions.screenRecordingTitle")}
description={t("onboarding.permissions.screenRecordingDescription")}
- granted={screenRecordingGranted}
- onRequest={requestScreenRecording}
+ granted={screenRecording.granted}
+ onRequest={screenRecording.request}
buttonText={t("onboarding.permissions.grant")}
+ onOpenSettings={screenRecording.openSettings}
badge={t("onboarding.permissions.optional")}
/>
</>
diff --git a/src/components/SettingsPage.tsx b/src/components/SettingsPage.tsx
index 19f8a3b71..fb1fcf741 100644
--- a/src/components/SettingsPage.tsx
+++ b/src/components/SettingsPage.tsx
@@ -38,6 +38,7 @@ import { useDialogs } from "../hooks/useDialogs";
import { useAgentName } from "../utils/agentName";
import { useWhisper } from "../hooks/useWhisper";
import { usePermissions } from "../hooks/usePermissions";
+import { useScreenRecordingPermission } from "../hooks/useScreenRecordingPermission";
import { useClipboard } from "../hooks/useClipboard";
import { useUpdater } from "../hooks/useUpdater";
@@ -725,6 +726,7 @@ export default function SettingsPage({ activeSection = "general" }: SettingsPage
const whisperHook = useWhisper();
const permissionsHook = usePermissions(showAlertDialog);
+ const screenRecording = useScreenRecordingPermission();
useClipboard(showAlertDialog);
const { agentName, setAgentName } = useAgentName();
const [agentNameInput, setAgentNameInput] = useState(agentName);
@@ -2388,15 +2390,27 @@ export default function SettingsPage({ activeSection = "general" }: SettingsPage
/>
{platform === "darwin" && (
- <PermissionCard
- icon={Shield}
- title={t("settingsPage.permissions.accessibilityTitle")}
- description={t("settingsPage.permissions.accessibilityDescription")}
- granted={permissionsHook.accessibilityPermissionGranted}
- onRequest={permissionsHook.testAccessibilityPermission}
- buttonText={t("settingsPage.permissions.testAndGrant")}
- onOpenSettings={permissionsHook.openAccessibilitySettings}
- />
+ <>
+ <PermissionCard
+ icon={Shield}
+ title={t("settingsPage.permissions.accessibilityTitle")}
+ description={t("settingsPage.permissions.accessibilityDescription")}
+ granted={permissionsHook.accessibilityPermissionGranted}
+ onRequest={permissionsHook.testAccessibilityPermission}
+ buttonText={t("settingsPage.permissions.testAndGrant")}
+ onOpenSettings={permissionsHook.openAccessibilitySettings}
+ />
+ <PermissionCard
+ icon={Monitor}
+ title={t("settingsPage.permissions.screenRecordingTitle")}
+ description={t("settingsPage.permissions.screenRecordingDescription")}
+ granted={screenRecording.granted}
+ onRequest={screenRecording.request}
+ buttonText={t("settingsPage.permissions.test")}
+ onOpenSettings={screenRecording.openSettings}
+ badge={t("settingsPage.permissions.optional")}
+ />
+ </>
)}
</div>
diff --git a/src/locales/en/translation.json b/src/locales/en/translation.json
index 5b75cd0ed..5cf9b295b 100644
--- a/src/locales/en/translation.json
+++ b/src/locales/en/translation.json
@@ -160,7 +160,7 @@
"requiredForApp": "Required for OpenWhispr to work",
"microphoneRequired": "Microphone access required",
"screenRecordingTitle": "Screen Recording",
- "screenRecordingDescription": "Needed to capture meeting audio. You can enable this later in Settings.",
+ "screenRecordingDescription": "Needed to capture meeting audio. You can enable this later in System Settings.",
"optional": "Optional"
},
"transcription": {
@@ -1219,6 +1219,9 @@
"rowDescription": "Fix issues after reinstalling or rebuilding the app by removing and re-adding OpenWhispr in System Settings",
"title": "Reset Accessibility Permissions"
},
+ "optional": "Optional",
+ "screenRecordingTitle": "Screen Recording",
+ "screenRecordingDescription": "Required to capture meeting audio from other apps",
"test": "Test",
"testAndGrant": "Test & Grant",
"title": "Permissions",