Skip to content

Voice-to-text dictation app with local (Nvidia Parakeet/Whisper) and cloud models (BYOK). Privacy-first and available cross-platform.

fix(meeting): handle nullish segments and non-object patches in speakerAssignmentPolicy (#1798)

Henry Suc519e1f74b5f
diff --git a/test/helpers/speakerAssignmentPolicy.test.js b/test/helpers/speakerAssignmentPolicy.test.js
new file mode 100644
index 000000000..afa7fd0df
--- /dev/null
+++ b/test/helpers/speakerAssignmentPolicy.test.js
@@ -0,0 +1,66 @@
+const test = require("node:test");
+const assert = require("node:assert/strict");
+
+const {
+ SPEAKER_STATUS,
+ canonicalizeSpeakerStatus,
+ isSpeakerLocked,
+ canAutoRelabelSpeaker,
+ applyProvisionalSpeaker,
+ applyConfirmedSpeaker,
+ applySuggestedSpeaker,
+} = require("../../src/helpers/speakerAssignmentPolicy");
+
+test("canonicalizeSpeakerStatus maps legacy and current statuses correctly", () => {
+ assert.equal(canonicalizeSpeakerStatus(SPEAKER_STATUS.PROVISIONAL), "provisional");
+ assert.equal(canonicalizeSpeakerStatus(SPEAKER_STATUS.CONFIRMED), "confirmed");
+ assert.equal(canonicalizeSpeakerStatus(SPEAKER_STATUS.SUGGESTED), "suggested");
+ assert.equal(canonicalizeSpeakerStatus(SPEAKER_STATUS.LOCKED), "locked");
+
+ assert.equal(canonicalizeSpeakerStatus("user_locked"), "locked");
+ assert.equal(canonicalizeSpeakerStatus("suggested_profile"), "suggested");
+ assert.equal(canonicalizeSpeakerStatus("uncertain_overlap"), "provisional");
+ assert.equal(canonicalizeSpeakerStatus("unknown_status"), undefined);
+
+ assert.equal(canonicalizeSpeakerStatus("provisional", { speakerLocked: true }), "locked");
+ assert.equal(canonicalizeSpeakerStatus("provisional", { speakerLockSource: "user" }), "locked");
+});
+
+test("isSpeakerLocked and canAutoRelabelSpeaker check lock state accurately", () => {
+ assert.equal(isSpeakerLocked({ speakerStatus: "locked" }), true);
+ assert.equal(isSpeakerLocked({ speakerLocked: true }), true);
+ assert.equal(isSpeakerLocked({ speakerLockSource: "user" }), true);
+ assert.equal(isSpeakerLocked({ speakerStatus: "provisional" }), false);
+ assert.equal(isSpeakerLocked(null), false);
+ assert.equal(isSpeakerLocked(undefined), false);
+
+ assert.equal(canAutoRelabelSpeaker({ speakerStatus: "provisional" }), true);
+ assert.equal(canAutoRelabelSpeaker({ speakerStatus: "locked" }), false);
+ assert.equal(canAutoRelabelSpeaker(null), true);
+});
+
+test("applyProvisionalSpeaker, applyConfirmedSpeaker, and applySuggestedSpeaker update segment fields", () => {
+ const segment = { text: "hello", speaker: "A" };
+ applyProvisionalSpeaker(segment, { speaker: "Speaker 1" });
+ assert.equal(segment.speaker, "Speaker 1");
+ assert.equal(segment.speakerStatus, "provisional");
+
+ applyConfirmedSpeaker(segment, { speaker: "Alice" });
+ assert.equal(segment.speaker, "Alice");
+ assert.equal(segment.speakerStatus, "confirmed");
+
+ applySuggestedSpeaker(segment, { speaker: "Bob" });
+ assert.equal(segment.speaker, "Bob");
+ assert.equal(segment.speakerStatus, "suggested");
+});
+
+test("locked segments preserve lock status on updates", () => {
+ const lockedSegment = { text: "hello", speaker: "Alice", speakerLocked: true };
+ applyProvisionalSpeaker(lockedSegment, { speaker: "Speaker 2" });
+ assert.equal(lockedSegment.speaker, "Alice");
+ assert.equal(lockedSegment.speakerStatus, "locked");
+ assert.equal(lockedSegment.speakerLockSource, "user");
+
+ applySuggestedSpeaker(lockedSegment, { speaker: "Bob" });
+ assert.equal(lockedSegment.speaker, "Alice");
+});