Skip to content

Voice-to-text dictation app with local (Nvidia Parakeet/Whisper) and cloud models (BYOK). Privacy-first and available cross-platform.

fix(meeting): restore live speaker diarization and live lock persistence

Gabriel Steinecf57ad3eb8c
diff --git a/src/components/notes/NoteEditor.tsx b/src/components/notes/NoteEditor.tsx
index 62c8c2a28..7dbe3fc37 100644
--- a/src/components/notes/NoteEditor.tsx
+++ b/src/components/notes/NoteEditor.tsx
@@ -92,6 +92,7 @@ interface NoteEditorProps {
meetingSystemPartialSpeakerId?: string | null;
meetingSystemPartialSpeakerName?: string | null;
onStopMeetingRecording?: () => void;
+ onLiveSpeakerLock?: (speakerId: string, displayName: string) => void;
liveTranscript?: string;
folderName?: string | null;
calendarEventName?: string | null;
@@ -123,6 +124,7 @@ export default function NoteEditor({
meetingSystemPartialSpeakerId,
meetingSystemPartialSpeakerName,
onStopMeetingRecording,
+ onLiveSpeakerLock,
liveTranscript,
folderName,
calendarEventName,
@@ -380,7 +382,8 @@ export default function NoteEditor({
profileId
);
- if (isMeetingRecording) {
+ if (isRecording) {
+ onLiveSpeakerLock?.(speakerId, displayName);
refreshSpeakerProfiles();
return;
}
@@ -404,7 +407,9 @@ export default function NoteEditor({
diarizedSegments,
displaySegments,
isMeetingRecording,
+ isRecording,
note.id,
+ onLiveSpeakerLock,
persistDisplaySegments,
refreshSpeakerProfiles,
]
diff --git a/src/components/notes/PersonalNotesView.tsx b/src/components/notes/PersonalNotesView.tsx
index 0e4ff8c2b..cc8f2beba 100644
--- a/src/components/notes/PersonalNotesView.tsx
+++ b/src/components/notes/PersonalNotesView.tsx
@@ -45,6 +45,7 @@ import { cn } from "../lib/utils";
import { MEETINGS_FOLDER_NAME, findDefaultFolder } from "./shared";
import logger from "../../utils/logger";
import { parseTranscriptSegments } from "../../utils/parseTranscriptSegments";
+import { serializeTranscriptSegments } from "../../utils/transcriptSpeakerState";
import {
useNotes,
useActiveNoteId,
@@ -122,6 +123,7 @@ export default function PersonalNotesView({
prepareTranscription,
startTranscription,
stopTranscription,
+ lockSpeaker,
} = useMeetingTranscription();
const recordingNoteIdRef = useRef<number | null>(null);
@@ -171,8 +173,10 @@ export default function PersonalNotesView({
const startRecording = useCallback(async () => {
isMeetingModeRef.current = false;
recordingNoteIdRef.current = activeNoteRef.current;
- await startTranscription({ allowSystemAudio: true });
- }, [startTranscription]);
+ const note = notes.find((n) => n.id === activeNoteRef.current);
+ const seedSegments = note?.transcript ? parseTranscriptSegments(note.transcript) : [];
+ await startTranscription({ allowSystemAudio: true, seedSegments });
+ }, [notes, startTranscription]);
const stopRecording = useCallback(async () => {
await stopTranscription();
@@ -461,9 +465,17 @@ export default function PersonalNotesView({
if (!meetingRecordingRequest || activeNoteId !== meetingRecordingRequest.noteId) return;
recordingNoteIdRef.current = meetingRecordingRequest.noteId;
isMeetingModeRef.current = true;
- startTranscription({ allowSystemAudio: false });
+ const note = notes.find((n) => n.id === meetingRecordingRequest.noteId);
+ const seedSegments = note?.transcript ? parseTranscriptSegments(note.transcript) : [];
+ startTranscription({ allowSystemAudio: false, seedSegments });
onMeetingRecordingRequestHandled?.();
- }, [meetingRecordingRequest, activeNoteId, startTranscription, onMeetingRecordingRequestHandled]);
+ }, [
+ meetingRecordingRequest,
+ activeNoteId,
+ notes,
+ startTranscription,
+ onMeetingRecordingRequestHandled,
+ ]);
const prevTranscribingRef = useRef(false);
@@ -475,9 +487,7 @@ export default function PersonalNotesView({
) {
const transcript =
realtimeSegments.length > 0
- ? JSON.stringify(
- realtimeSegments.map(({ text, source, timestamp }) => ({ text, source, timestamp }))
- )
+ ? serializeTranscriptSegments(realtimeSegments)
: realtimeTranscript;
const noteId = recordingNoteIdRef.current;
@@ -893,6 +903,7 @@ export default function PersonalNotesView({
isActiveNoteRecording ? systemPartialSpeakerName : undefined
}
onStopMeetingRecording={stopTranscription}
+ onLiveSpeakerLock={lockSpeaker}
liveTranscript={isActiveNoteRecording ? realtimeTranscript : ""}
folderName={activeFolderName}
calendarEventName={calendarEventName}
diff --git a/src/helpers/ipcHandlers.js b/src/helpers/ipcHandlers.js
index 24f22c339..b79919728 100644
--- a/src/helpers/ipcHandlers.js
+++ b/src/helpers/ipcHandlers.js
@@ -3415,6 +3415,7 @@ class IPCHandlers {
}
meetingTranscriptionStartInProgress = true;
+ this.meetingDetectionEngine?.setUserRecording(true);
try {
const systemAudioMode = getMeetingSystemAudioMode();
meetingEchoLeakDetector.reset();
@@ -3473,6 +3474,7 @@ class IPCHandlers {
return { success: true, systemAudioMode };
} catch (error) {
await rollbackMeetingTranscriptionStart();
+ this.meetingDetectionEngine?.setUserRecording(false);
debugLogger.error("Meeting transcription start error", { error: error.message });
return { success: false, error: error.message };
} finally {
@@ -3543,6 +3545,7 @@ class IPCHandlers {
});
ipcMain.handle("meeting-transcription-stop", async () => {
+ this.meetingDetectionEngine?.setUserRecording(false);
try {
if (this.audioTapManager) {
await this.audioTapManager.stop();
diff --git a/src/helpers/liveSpeakerIdentifier.js b/src/helpers/liveSpeakerIdentifier.js
index d0a507cfe..fd3ad6c0a 100644
--- a/src/helpers/liveSpeakerIdentifier.js
+++ b/src/helpers/liveSpeakerIdentifier.js
@@ -15,7 +15,7 @@ const LIVE_IDENTIFICATION_INTERVAL_SAMPLES = Math.round(
);
const SPEECH_THRESHOLD = 0.15;
const SILENCE_THRESHOLD = 0.08;
-const SILENCE_WINDOWS_TO_END = 4;
+const SILENCE_WINDOWS_TO_END = 16;
const MATCH_THRESHOLD = 0.82;
const MATCH_MARGIN = 0.04;
const LIVE_WINDOW_PADDING_SECONDS = 0.75;
diff --git a/src/hooks/useMeetingTranscription.ts b/src/hooks/useMeetingTranscription.ts
index 802f7cf1f..485db02d2 100644
--- a/src/hooks/useMeetingTranscription.ts
+++ b/src/hooks/useMeetingTranscription.ts
@@ -3,6 +3,7 @@ import { getSettings } from "../stores/settingsStore";
import { isBuiltInMicrophone } from "../utils/audioDeviceUtils";
import logger from "../utils/logger";
import {
+ lockTranscriptSpeaker,
normalizeTranscriptSegment,
type TranscriptSpeakerLockSource,
type TranscriptSpeakerStatus,
@@ -49,8 +50,12 @@ interface UseMeetingTranscriptionReturn {
error: string | null;
diarizationSessionId: string | null;
prepareTranscription: () => Promise<void>;
- startTranscription: (_options?: { allowSystemAudio?: boolean }) => Promise<void>;
+ startTranscription: (_options?: {
+ allowSystemAudio?: boolean;
+ seedSegments?: TranscriptSegment[];
+ }) => Promise<void>;
stopTranscription: () => Promise<void>;
+ lockSpeaker: (speakerId: string, displayName: string) => void;
}
const MEETING_AUDIO_BUFFER_SIZE = 800;
@@ -304,6 +309,7 @@ export function useMeetingTranscription(): UseMeetingTranscriptionReturn {
const nextPlaceholderSpeakerIndexRef = useRef(0);
const systemPartialSpeakerIdRef = useRef<string | null>(null);
const recentSystemSpeakerRef = useRef<RecentSystemSpeaker | null>(null);
+ const speakerLocksRef = useRef<Map<string, string>>(new Map());
const setSystemPartialSpeakerIdentity = useCallback(
(speakerId: string | null, speakerName: string | null) => {
@@ -535,22 +541,33 @@ export function useMeetingTranscription(): UseMeetingTranscriptionReturn {
}, []);
const startTranscription = useCallback(
- async (_options?: { allowSystemAudio?: boolean }) => {
+ async (_options?: { allowSystemAudio?: boolean; seedSegments?: TranscriptSegment[] }) => {
if (isRecordingRef.current || isStartingRef.current) return;
isStartingRef.current = true;
logger.info("Meeting transcription starting...", {}, "meeting");
- setTranscript("");
+ const seed = _options?.seedSegments ?? [];
+ const locks = new Map<string, string>();
+ let maxSpeakerIndex = -1;
+ for (const s of seed) {
+ const idx = getSpeakerNumericIndex(s.speaker);
+ if (idx != null && idx > maxSpeakerIndex) maxSpeakerIndex = idx;
+ if (s.speakerLocked && s.speaker && s.speakerName) {
+ locks.set(s.speaker, s.speakerName);
+ }
+ }
+ setTranscript(seed.map((s) => s.text).join(" "));
setPartialTranscript("");
- setSegments([]);
- segmentsRef.current = [];
+ setSegments(seed);
+ segmentsRef.current = seed;
setMicPartial("");
setSystemPartial("");
setSystemPartialSpeakerIdentity(null, null);
setError(null);
speakerIdentificationsRef.current = [];
- nextPlaceholderSpeakerIndexRef.current = 0;
+ nextPlaceholderSpeakerIndexRef.current = maxSpeakerIndex + 1;
recentSystemSpeakerRef.current = null;
+ speakerLocksRef.current = locks;
isRecordingRef.current = true;
setIsRecording(true);
@@ -671,8 +688,19 @@ export function useMeetingTranscription(): UseMeetingTranscriptionReturn {
);
}
- const seg = assignProvisionalSpeaker(rawSegment);
- reserveSpeakerIndex(seg.speaker);
+ const provisional = assignProvisionalSpeaker(rawSegment);
+ reserveSpeakerIndex(provisional.speaker);
+ const lockedName = provisional.speaker
+ ? speakerLocksRef.current.get(provisional.speaker)
+ : undefined;
+ const seg = lockedName
+ ? lockTranscriptSpeaker(provisional, {
+ speakerName: lockedName,
+ speakerIsPlaceholder: false,
+ suggestedName: undefined,
+ suggestedProfileId: undefined,
+ })
+ : provisional;
setSegments((prev) => {
const ts = seg.timestamp ?? Infinity;
let i = prev.length;
@@ -819,6 +847,39 @@ export function useMeetingTranscription(): UseMeetingTranscriptionReturn {
]
);
+ const lockSpeaker = useCallback(
+ (speakerId: string, displayName: string) => {
+ if (!speakerId || !displayName) return;
+ speakerLocksRef.current.set(speakerId, displayName);
+ setSegments((prev) => {
+ const next = prev.map((s) =>
+ s.speaker === speakerId
+ ? lockTranscriptSpeaker(s, {
+ speakerName: displayName,
+ speakerIsPlaceholder: false,
+ suggestedName: undefined,
+ suggestedProfileId: undefined,
+ })
+ : s
+ );
+ segmentsRef.current = next;
+ return next;
+ });
+ const recent = recentSystemSpeakerRef.current;
+ if (recent?.speakerId === speakerId) {
+ recentSystemSpeakerRef.current = {
+ ...recent,
+ speakerName: displayName,
+ speakerIsPlaceholder: false,
+ };
+ }
+ if (systemPartialSpeakerIdRef.current === speakerId) {
+ setSystemPartialSpeakerIdentity(speakerId, displayName);
+ }
+ },
+ [setSystemPartialSpeakerIdentity]
+ );
+
useEffect(() => {
getMeetingWorkletBlobUrl();
}, []);
@@ -851,5 +912,6 @@ export function useMeetingTranscription(): UseMeetingTranscriptionReturn {
prepareTranscription,
startTranscription,
stopTranscription,
+ lockSpeaker,
};
}