Voice-to-text dictation app with local (Nvidia Parakeet/Whisper) and cloud models (BYOK). Privacy-first and available cross-platform.
JavaScript aianthropiccross-platformgeminigroqlinuxmacosnvidiaopen-sourceopenaiparakeetspeech-to-texttranscribewhisperwindows
fix(notes): keep the tab strip in sync when the AI Summary is deleted (#2302)
Joshuaf0dd56c6e715
diff --git a/src/components/notes/NoteEditor.tsx b/src/components/notes/NoteEditor.tsxindex 0341155bb..6890bb040 100644--- a/src/components/notes/NoteEditor.tsx+++ b/src/components/notes/NoteEditor.tsx@@ -252,7 +252,11 @@ export default function NoteEditor({const { t } = useTranslation();const locale = useUiLocale();const defaultViewMode: MeetingViewMode = enhancement ? "enhanced" : "raw";- const [viewMode, setViewMode] = useState<MeetingViewMode>(defaultViewMode);+ const [selectedViewMode, setSelectedViewMode] = useState<MeetingViewMode>(defaultViewMode);+ // Stored as chosen, clamped on read: AI Summary is the only tab that can stop+ // rendering, and a tab that no longer renders can never be the current one.+ const viewMode: MeetingViewMode =+ selectedViewMode === "enhanced" && !enhancement ? "raw" : selectedViewMode;const [chatMode, setChatMode] = useState<EmbeddedChatMode>("hidden");const [folderSearch, setFolderSearch] = useState("");const [isCreatingFolder, setIsCreatingFolder] = useState(false);@@ -466,7 +470,10 @@ export default function NoteEditor({const buttons = container.querySelectorAll<HTMLButtonElement>("[data-segment-button]");const activeBtn = Array.from(buttons).find((btn) => btn.dataset.segmentValue === viewMode);- if (!activeBtn) return;+ if (!activeBtn) {+ setIndicatorStyle((style) => ({ ...style, opacity: 0 }));+ return;+ }const cr = container.getBoundingClientRect();const br = activeBtn.getBoundingClientRect();@@ -493,7 +500,7 @@ export default function NoteEditor({let cancelScheduledUpdate: (() => void) | undefined;if (prevProcessingStateRef.current === "processing" && actionProcessingState === "success") {- cancelScheduledUpdate = scheduleUiUpdate(() => setViewMode("enhanced"));+ cancelScheduledUpdate = scheduleUiUpdate(() => setSelectedViewMode("enhanced"));}prevProcessingStateRef.current = actionProcessingState;@@ -508,7 +515,7 @@ export default function NoteEditor({setDiarizedSegments(null);setIsDiarizing(false);setSpeakerMappings({});- setViewMode(defaultViewMode);+ setSelectedViewMode(defaultViewMode);if (titleRef.current && titleRef.current.textContent !== note.title) {titleRef.current.textContent = note.title || "";}@@ -1030,7 +1037,7 @@ export default function NoteEditor({<buttondata-segment-buttondata-segment-value="transcript"- onClick={() => setViewMode("transcript")}+ onClick={() => setSelectedViewMode("transcript")}className={cn(SEGMENT_BUTTON_CLASS,viewMode === "transcript"@@ -1044,7 +1051,7 @@ export default function NoteEditor({<buttondata-segment-buttondata-segment-value="raw"- onClick={() => setViewMode("raw")}+ onClick={() => setSelectedViewMode("raw")}className={cn(SEGMENT_BUTTON_CLASS,viewMode === "raw"@@ -1059,7 +1066,7 @@ export default function NoteEditor({<buttondata-segment-buttondata-segment-value="enhanced"- onClick={() => setViewMode("enhanced")}+ onClick={() => setSelectedViewMode("enhanced")}className={cn(SEGMENT_BUTTON_CLASS,viewMode === "enhanced"diff --git a/test/components/noteEditorSummaryDeletion.test.js b/test/components/noteEditorSummaryDeletion.test.jsnew file mode 100644index 000000000..b326ba0ab--- /dev/null+++ b/test/components/noteEditorSummaryDeletion.test.js@@ -0,0 +1,284 @@+const assert = require("node:assert/strict");+const test = require("node:test");+const React = require("react");+const { createRoot } = require("react-dom/client");+const {+ createRendererServer,+ installBrowserGlobals,+ installHookDom,+} = require("../lib/rendererTestHarness");++// Visit every element in the tree the component returned.+function walk(node, visit) {+ if (node === null || node === undefined || typeof node !== "object") return;+ if (Array.isArray(node)) {+ for (const child of node) walk(child, visit);+ return;+ }+ if (!node.props) return;+ visit(node);+ walk(node.props.children, visit);+}++// The segmented-control buttons by their data-segment-value.+function collectSegments(tree) {+ const out = new Map();+ walk(tree, (node) => {+ const value = node.props["data-segment-value"];+ if (value) out.set(value, node);+ });+ return out;+}++// Every `value` a rich-text editor in the tree was handed — the body content.+function collectEditorValues(tree) {+ const out = [];+ walk(tree, (node) => {+ if (typeof node.props.value === "string") out.push(node.props.value);+ });+ return out;+}++function activeSegment(segments) {+ // The active tab is the one rendered with the full-strength label colour;+ // the inactive ones get text-foreground/60.+ const active = [];+ for (const [value, node] of segments) {+ const className = String(node.props.className ?? "");+ if (/(^|\s)text-foreground($|\s)/.test(className)) active.push(value);+ }+ return active;+}++// The strip is the element the component measures through its ref; its first+// child is the sliding highlight, positioned through its inline style.+function findSegmentStrip(tree) {+ let strip = null;+ walk(tree, (node) => {+ if (strip) return;+ const children = React.Children.toArray(node.props.children);+ if (children.some((child) => child.props?.["data-segment-button"])) strip = node;+ });+ return strip;+}++function highlightStyle(tree) {+ return React.Children.toArray(findSegmentStrip(tree).props.children)[0].props.style;+}++// The harness DOM has no layout, so the tests hand the component a strip it can+// measure: tabs laid out left to right from the strip's left edge.+const TAB_BOXES = {+ transcript: { left: 2, width: 100, height: 26 },+ raw: { left: 102, width: 90, height: 26 },+ enhanced: { left: 192, width: 110, height: 26 },+};++function measurableStrip(values) {+ const buttons = values.map((value) => ({+ dataset: { segmentValue: value },+ getBoundingClientRect: () => ({ top: 0, ...TAB_BOXES[value] }),+ }));+ return {+ getBoundingClientRect: () => ({ left: 0, top: 0, width: 310, height: 30 }),+ querySelectorAll: () => buttons,+ };+}++const NOTE = {+ id: 1,+ client_note_id: "note-1",+ cloud_id: null,+ title: "Kickoff",+ content: "plain notes body",+ enhanced_content: "AI summary body",+ transcript: "",+ created_at: "2026-09-01T00:00:00.000Z",+ updated_at: "2026-09-01T00:00:00.000Z",+ space_id: null,+ folder_id: null,+};++const ENHANCEMENT = { content: NOTE.enhanced_content, isStale: false, onChange() {} };++function baseProps(enhancement) {+ return {+ note: { ...NOTE, enhanced_content: enhancement ? enhancement.content : null },+ onTitleChange() {},+ onContentChange() {},+ isSaving: false,+ isRecording: false,+ isProcessing: false,+ onStartRecording() {},+ onStopRecording() {},+ enhancement,+ };+}++async function loadNoteEditor(t) {+ installBrowserGlobals(t, {+ window: {+ electronAPI: {+ getSpeakerProfiles: async () => [],+ getSpeakerMappings: async () => [],+ },+ },+ });+ const container = installHookDom(t);+ const resizeCallbacks = [];+ globalThis.ResizeObserver = class {+ constructor(callback) {+ resizeCallbacks.push(callback);+ }+ observe() {}+ unobserve() {}+ disconnect() {}+ };+ t.after(() => {+ delete globalThis.ResizeObserver;+ });++ const vite = await createRendererServer(t, {+ cachePrefix: "openwhispr-note-editor-summary-",+ noExternal: ["react-i18next"],+ mockModules: {+ "react-i18next": `+ const t = (key) => key;+ const i18n = { resolvedLanguage: "en", language: "en" };+ export function useTranslation() { return { t, i18n }; }+ export const initReactI18next = { type: "3rdParty", init() {} };+ `,+ "/ui/RichTextEditor": `+ export function RichTextEditor(props) { return null; }+ `,+ "./MeetingTranscriptChat": `+ export function MeetingTranscriptChat() { return null; }+ export function SelectionBar() { return null; }+ `,+ "/EmbeddedChat": `export default function EmbeddedChat() { return null; }`,+ "/hooks/useAuth": `export function useAuth() { return { isSignedIn: false, user: null }; }`,+ "/hooks/useEmbeddedChat": `+ export function useEmbeddedChat() {+ return {+ messages: [],+ send() {},+ reset() {},+ isStreaming: false,+ containerRef: { current: null },+ };+ }+ `,+ "/services/NoteSharingService": `+ export const NoteSharingService = { fetchAcl: async () => null };+ `,+ "/hooks/useSpaceRoster": `export async function fetchSpaceRoster() { return []; }`,+ },+ });++ const mod = await vite.ssrLoadModule("/components/notes/NoteEditor.tsx");+ const NoteEditor = mod.default;++ const renders = [];+ function Harness({ enhancement }) {+ // Run the real component body + hooks under React's lifecycle without+ // mounting host elements (the harness DOM has no layout), then assert on+ // the tree it returned.+ renders.push(NoteEditor(baseProps(enhancement)));+ return null;+ }++ const root = createRoot(container);+ const render = (enhancement) =>+ React.act(async () => {+ root.render(React.createElement(Harness, { enhancement }));+ });+ const click = (value) =>+ React.act(async () => {+ collectSegments(renders.at(-1)).get(value).props.onClick();+ });+ const latest = () => renders.at(-1);+ const unmount = () => React.act(async () => root.unmount());+ return { render, click, latest, unmount, resizeCallbacks };+}++test("deleting the AI summary moves the selection to Your notes", async (t) => {+ const { render, latest, unmount } = await loadNoteEditor(t);++ await render(ENHANCEMENT);+ const withSummary = collectSegments(latest());+ assert.deepEqual([...withSummary.keys()].sort(), ["enhanced", "raw", "transcript"]);+ assert.deepEqual(activeSegment(withSummary), ["enhanced"], "AI Summary starts selected");++ // The user clears the summary text: RichTextEditor emits "", the draft stores+ // "", and PersonalNotesView stops passing an enhancement at all.+ await render(undefined);+ const afterDelete = collectSegments(latest());+ assert.deepEqual(+ [...afterDelete.keys()].sort(),+ ["raw", "transcript"],+ "the AI Summary button is gone"+ );+ // The body already falls back — only the tab strip disagreed with it.+ assert.ok(+ collectEditorValues(latest()).includes(NOTE.content),+ "the body renders the plain notes content"+ );+ assert.deepEqual(+ activeSegment(afterDelete),+ ["raw"],+ "selection falls back to Your notes instead of pointing at a tab that no longer exists"+ );++ await unmount();+});++test("the highlight slides onto Your notes when the summary is deleted", async (t) => {+ const { render, click, latest, unmount } = await loadNoteEditor(t);++ await render(ENHANCEMENT);+ const strip = findSegmentStrip(latest());+ strip.props.ref.current = measurableStrip(["transcript", "raw", "enhanced"]);+ // Take a real measurement over the AI Summary tab, as the app has by the time+ // the user starts deleting.+ await click("transcript");+ await click("enhanced");+ assert.deepEqual(highlightStyle(latest()), {+ width: 110,+ height: 26,+ transform: "translateX(192px)",+ opacity: 1,+ });++ strip.props.ref.current = measurableStrip(["transcript", "raw"]);+ await render(undefined);+ assert.deepEqual(+ highlightStyle(latest()),+ { width: 90, height: 26, transform: "translateX(102px)", opacity: 1 },+ "the highlight moved onto Your notes instead of freezing over the removed tab"+ );++ await unmount();+});++test("hides the highlight instead of freezing it when no tab matches the selection", async (t) => {+ const { render, click, latest, unmount, resizeCallbacks } = await loadNoteEditor(t);++ await render(undefined);+ const strip = findSegmentStrip(latest());+ strip.props.ref.current = measurableStrip(["transcript", "raw"]);+ await click("transcript");+ await click("raw");+ assert.equal(highlightStyle(latest()).opacity, 1);++ // The strip lost the selected tab's button: the net under the whole bug class,+ // reached through the same resize measurement the app performs.+ strip.props.ref.current = measurableStrip(["transcript"]);+ await React.act(async () => resizeCallbacks.at(-1)());+ assert.deepEqual(+ highlightStyle(latest()),+ { width: 90, height: 26, transform: "translateX(102px)", opacity: 0 },+ "the highlight fades in place rather than staying lit over nothing"+ );++ await unmount();+});