Python
Local model list: say when the server cannot be reached, with Retry
Rohit C Prasad0e0378070956
diff --git a/surfaces/gui/e2e/local-server-help.spec.ts b/surfaces/gui/e2e/local-server-help.spec.tsindex 7b6ec1be..b839633b 100644--- a/surfaces/gui/e2e/local-server-help.spec.ts+++ b/surfaces/gui/e2e/local-server-help.spec.ts@@ -24,3 +24,36 @@ for (const [name, title, says, link] of [await expect(form).not.toContainText("Ollama");});}++// A models request that fails must say so, with Retry, never leave the page blank+// (owner-hit 2026-10-06: the table vanished and an unticked model could not be re-ticked).+test("llama.cpp: a failed model list says so, and Retry brings the table back", async ({ page }) => {+ let fail = true;+ await page.route("**/v1/providers", (route) => route.fulfill({ json: [server("llamacpp", "llama.cpp")] }));+ await page.route("**/v1/providers/llamacpp/models", (route) =>+ fail+ ? route.abort()+ : route.fulfill({+ json: {+ provider: "llamacpp", alive: true,+ models: [{ model: "llamacpp:nemotron-3.5-lightning", name: "nemotron-3.5-lightning", size_bytes: 36e9, tools: true, thinking: true,+ vision: null, remote: false, parameter_size: null, quantization: null, context_max: 1048576, context: 65536,+ context_from: "server", fit: "runs_well", recommendation: "NVIDIA Nemotron 3.5 Lightning" }],+ },+ }),+ );+ await page.goto("/");+ await page.getByTestId("account-row").click();+ await page.getByRole("button", { name: "Settings", exact: true }).click();+ await page.getByRole("button", { name: "Models & Keys" }).click();+ await page.getByTestId("set-provider-llamacpp").click();+ await expect(page.getByTestId("local-models-status")).toContainText("Couldn't reach the server");+ fail = false;+ await page.getByTestId("local-models-retry").click();+ // The model is back, unticked, and ticking it puts it back in the picker.+ const box = page.getByTestId("local-model-nemotron-3.5-lightning").getByRole("checkbox");+ await expect(box).not.toBeChecked();+ const added = page.waitForRequest((r) => r.url().endsWith("/v1/settings/models/add") && r.method() === "POST");+ await box.click();+ expect((await added).postDataJSON()).toEqual({ model: "llamacpp:nemotron-3.5-lightning" });+});diff --git a/surfaces/gui/src/api.ts b/surfaces/gui/src/api.tsindex fbb3fb9d..f95dfc1c 100644--- a/surfaces/gui/src/api.ts+++ b/surfaces/gui/src/api.ts@@ -2601,7 +2601,11 @@ export interface LocalModelRow {export async function getLocalModels(provider: string,): Promise<{ provider: string; models: LocalModelRow[]; alive?: boolean; error?: string }> {- const res = await fetch(`${httpBase()}/v1/providers/${encodeURIComponent(provider)}/models`);+ // A stuck request must end in an error the page can show, never an endless blank.+ const res = await fetch(`${httpBase()}/v1/providers/${encodeURIComponent(provider)}/models`, {+ signal: AbortSignal.timeout(15_000),+ });+ if (!res.ok) throw new Error(`HTTP ${res.status}`);return res.json();}diff --git a/surfaces/gui/src/components/models/LocalModels.tsx b/surfaces/gui/src/components/models/LocalModels.tsxindex b69aa350..2e59e276 100644--- a/surfaces/gui/src/components/models/LocalModels.tsx+++ b/surfaces/gui/src/components/models/LocalModels.tsx@@ -78,18 +78,37 @@ export function LocalModelsTable({const { t } = useTranslation();const [rows, setRows] = useState<LocalModelRow[] | null>(null);const [alive, setAlive] = useState<boolean | undefined>(undefined);- const load = () =>+ const [failed, setFailed] = useState(false);+ const load = () => {+ setFailed(false);+ setRows(null);getLocalModels(provider).then((r) => {setRows(r.models || []);setAlive(r.alive);})- .catch(() => setRows([]));+ .catch(() => setFailed(true));+ };useEffect(() => {load();// eslint-disable-next-line react-hooks/exhaustive-deps}, [provider]);- if (rows === null) return null;+ // Never a blank page: say we are asking, or that the answer did not come, with Retry.+ if (rows === null)+ return (+ <div className="mt-6 text-meta" data-testid="local-models-status">+ {failed ? (+ <span className="text-warnInk">+ {t(provider === "ollama" ? "manage.local_models_failed_ollama" : "manage.local_models_failed")}{" "}+ <button className="text-muted underline underline-offset-2 hover:text-ink" onClick={load} data-testid="local-models-retry">+ {t("manage.retry")}+ </button>+ </span>+ ) : (+ <span className="text-faint">{t("manage.local_models_loading")}</span>+ )}+ </div>+ );const inPicker = (id: string) => curated.includes(id);const toggle = async (row: LocalModelRow) => {if (inPicker(row.model)) {diff --git a/surfaces/gui/src/components/models/PickModelDialog.tsx b/surfaces/gui/src/components/models/PickModelDialog.tsxindex 12dad753..3a9403d2 100644--- a/surfaces/gui/src/components/models/PickModelDialog.tsx+++ b/surfaces/gui/src/components/models/PickModelDialog.tsx@@ -78,6 +78,8 @@ export function PickModelDialog({const connected = providers.filter((p) => providerConnected(p, keylessOk) && kinds.has(providerKind(p)));const isLocal = provider ? providerKind(provider) === "local" : false;+ const [loadFailed, setLoadFailed] = useState(false);+ const [reload, setReload] = useState(0);const fixedContext = provider?.name === "llamacpp" || provider?.name === "vllm";// Step 2: the models the chosen provider offers. Also read when the dialog opens on@@ -86,7 +88,13 @@ export function PickModelDialog({if (!provider || (step !== 2 && !(step === 3 && providerKind(provider) === "local" && rows === null))) return;setRows(null);if (providerKind(provider) === "local") {- getLocalModels(provider.name).then((r) => setRows((r.models || []).filter((m) => m.tools !== false))).catch(() => setRows([]));+ setLoadFailed(false);+ getLocalModels(provider.name)+ .then((r) => setRows((r.models || []).filter((m) => m.tools !== false)))+ .catch(() => {+ setLoadFailed(true);+ setRows([]);+ });} else {setRows(provider.suggested_models.map((bare) => ({model: fullModelId(provider, bare), name: bare, size_bytes: null, tools: true, thinking: null, vision: null, remote: true,@@ -94,7 +102,7 @@ export function PickModelDialog({})));}// eslint-disable-next-line react-hooks/exhaustive-deps- }, [provider, step]);+ }, [provider, step, reload]);// Step 3: the settings in force for the chosen model.useEffect(() => {@@ -287,6 +295,14 @@ export function PickModelDialog({</button>))}{rows === null && <div className="px-3 py-3 text-meta text-faint">{t("manage.loading")}</div>}+ {loadFailed && (+ <div className="px-3 py-3 text-meta text-warnInk" data-testid="pick-models-failed">+ {t("manage.local_models_failed")}{" "}+ <button className="text-muted underline underline-offset-2 hover:text-ink" onClick={() => setReload((n) => n + 1)}>+ {t("manage.retry")}+ </button>+ </div>+ )}</div>{typed.trim() && provider && !isLocal && (<button className="mt-2 text-meta text-accent" onClick={() => { setModel(fullModelId(provider, typed.trim())); setStep(3); }} data-testid="pick-model-typed">diff --git a/surfaces/gui/src/locales/en.json b/surfaces/gui/src/locales/en.jsonindex 6503ffa5..49e6f323 100644--- a/surfaces/gui/src/locales/en.json+++ b/surfaces/gui/src/locales/en.json@@ -1374,7 +1374,11 @@"local_server_not_answering": "Nothing answers at this address.","vllm_tools_off": "This server cannot use tools yet, so coworkers cannot work with it. Start vLLM with tool calling turned on, then check again.","configure_model": "Settings for this model",- "remove_from_picker_btn": "Remove from the picker"+ "remove_from_picker_btn": "Remove from the picker",+ "local_models_loading": "Asking the server which models it has…",+ "local_models_failed": "Couldn't reach the server to list its models.",+ "local_models_failed_ollama": "Couldn't reach Ollama to list its models.",+ "retry": "Retry"},"models": {"add_btn": "Add",diff --git a/surfaces/gui/src/locales/zh.json b/surfaces/gui/src/locales/zh.jsonindex e82fdb39..f8231a3b 100644--- a/surfaces/gui/src/locales/zh.json+++ b/surfaces/gui/src/locales/zh.json@@ -1357,7 +1357,11 @@"local_server_not_answering": "该地址没有响应。","vllm_tools_off": "此服务器尚不能使用工具,因此同事无法使用它。请开启工具调用后重新启动 vLLM,然后再检查。","configure_model": "此模型的设置",- "remove_from_picker_btn": "从选择器中移除"+ "remove_from_picker_btn": "从选择器中移除",+ "local_models_loading": "正在向服务器查询可用模型…",+ "local_models_failed": "无法连接服务器以列出模型。",+ "local_models_failed_ollama": "无法连接 Ollama 以列出模型。",+ "retry": "重试"},"models": {"add_btn": "添加",