Python
Tool-request card: separate the product's facts from the coworker's ask
Rohit C Prasad8e77d61aa141
diff --git a/coworker/engine.py b/coworker/engine.pyindex 1e393199..9b36e43d 100644--- a/coworker/engine.py+++ b/coworker/engine.py@@ -976,6 +976,7 @@ class TurnEngine:"installable": info is not None,"version": (info or {}).get("version", ""),"summary": (info or {}).get("summary", ""),+ "source": (info or {}).get("source", ""),},)self._audit(tool_call, stage="tool_requested", reason=reason)diff --git a/coworker/server/app.py b/coworker/server/app.pyindex 460a0d2c..375037a7 100644--- a/coworker/server/app.py+++ b/coworker/server/app.py@@ -1717,6 +1717,7 @@ def create_app(manager: SessionManager) -> FastAPI:"version": (info or {}).get("version", ""),"summary": (info or {}).get("summary", ""),"url": (info or {}).get("url", ""),+ "source": (info or {}).get("source", ""),},tool_call_id=tool_call_id,)diff --git a/coworker/tools/toolreq.py b/coworker/tools/toolreq.pyindex e611b838..a0ad4040 100644--- a/coworker/tools/toolreq.py+++ b/coworker/tools/toolreq.py@@ -18,8 +18,11 @@ from aisuite.agents import ToolMetadata, tooldef request_tool_tool() -> object:def request_tool(name: str, reason: str) -> dict:"""Ask the user to install a command-line tool you need but can't find on this- machine (e.g. `gitleaks`, `osv-scanner`, `semgrep`). Say in `reason` what check it- unlocks, so the user can judge whether it's worth installing.+ machine (e.g. `gitleaks`, `osv-scanner`, `semgrep`).++ Keep `reason` to ONE sentence: which check needs the tool. The prompt the user+ sees already explains what the install is (pinned version, publisher, checksum)+ and what happens if they decline — don't restate any of that in `reason`.Use this INSTEAD of quietly skipping a check. If the user declines, carry on with afallback (e.g. reading git history yourself instead of running gitleaks) and statediff --git a/surfaces/gui/e2e/fixtures.ts b/surfaces/gui/e2e/fixtures.tsindex f1da713e..0fd085d7 100644--- a/surfaces/gui/e2e/fixtures.ts+++ b/surfaces/gui/e2e/fixtures.ts@@ -628,6 +628,7 @@ export async function mockApi(page: import("@playwright/test").Page) {installable: true,version: "8.30.1",summary: "scans git history and the working tree for committed secrets",+ source: "github.com/gitleaks",});return; // suspended on the tool request}diff --git a/surfaces/gui/e2e/toolreq.spec.ts b/surfaces/gui/e2e/toolreq.spec.tsindex b3a879cf..5e420e5f 100644--- a/surfaces/gui/e2e/toolreq.spec.ts+++ b/surfaces/gui/e2e/toolreq.spec.ts@@ -17,10 +17,14 @@ test("request_tool surfaces a card naming the tool, the reason and the pinned veconst card = page.locator(".dirreq-card");await expect(card).toContainText("gitleaks");await expect(card).toContainText("scan the git history for committed secrets");- await expect(card).toContainText("8.30.1");- await expect(card).toContainText(/checksum-verified/i);- // Declining must read as a normal choice, not a failure.- await expect(card.getByTestId("toolreq-skip")).toBeVisible();+ // The fact strip is the product's voice: version, publisher, checksum — kept apart from+ // the coworker's quoted reason (mixing them is what made the card confusing, 2026-08-14).+ const facts = card.locator(".toolreq-facts");+ await expect(facts).toContainText("8.30.1");+ await expect(facts).toContainText(/checksum-verified/i);+ await expect(facts).toContainText("from github.com/gitleaks");+ // Declining must read as a normal choice that continues the run, not a failure.+ await expect(card.getByTestId("toolreq-skip")).toHaveText("Continue without it");});test("an event without install metadata fails CLOSED — Install disabled, skip offered", async ({diff --git a/surfaces/gui/src/App.tsx b/surfaces/gui/src/App.tsxindex e9ae5662..dd70e707 100644--- a/surfaces/gui/src/App.tsx+++ b/surfaces/gui/src/App.tsx@@ -741,6 +741,7 @@ export function App() {installable: d.installable === true,version: d.version || "",summary: d.summary || "",+ source: d.source || "",},]);break;diff --git a/surfaces/gui/src/components/ToolRequestCard.tsx b/surfaces/gui/src/components/ToolRequestCard.tsxindex 7a8e04d8..9847e59c 100644--- a/surfaces/gui/src/components/ToolRequestCard.tsx+++ b/surfaces/gui/src/components/ToolRequestCard.tsx@@ -22,23 +22,30 @@ export function ToolRequestCard({</span></div>{item.reason && <div className="dirreq-reason">“{item.reason}”</div>}+ {/* The fact strip is the PRODUCT speaking (registry metadata), styled apart from the+ coworker's quoted ask above — mixing the two voices is what made the card confusing. */}{item.installable ? (- <div className="dirreq-reason">- {item.summary ? `${item.summary}. ` : ""}- Installs {item.tool}- {item.version ? ` ${item.version}` : ""} — a pinned build, checksum-verified before- it runs.+ <div className="toolreq-facts">+ <code>+ {item.tool}+ {item.version ? ` ${item.version}` : ""}+ </code>+ {item.summary && <span className="toolreq-fact">{item.summary}</span>}+ <span className="toolreq-fact">pinned & checksum-verified</span>+ {item.source && <span className="toolreq-fact">from {item.source}</span>}</div>) : (- <div className="dirreq-reason">- No verified build is available for this machine — install it yourself if you want- this check, or skip and the coworker will note the gap.+ <div className="toolreq-facts">+ <span className="toolreq-fact">+ No verified build is available for this machine — install it yourself if you want+ this check, or continue and the coworker will note the gap.+ </span></div>)}<div className="dirreq-actions"><span className="spacer" /><button className="btn" data-testid="toolreq-skip" onClick={() => onRespond(false)}>- Skip this check+ Continue without it</button><buttonclassName="btn primary"diff --git a/surfaces/gui/src/styles.css b/surfaces/gui/src/styles.cssindex 3de7841c..24c49792 100644--- a/surfaces/gui/src/styles.css+++ b/surfaces/gui/src/styles.css@@ -794,6 +794,19 @@ button.btn.danger { color: var(--accent); }.dirreq-head { display: flex; align-items: center; gap: 8px; font-weight: 600; font-size: 13.5px; color: var(--ink); }.dirreq-head .ico { color: var(--accent); }.dirreq-reason { font-size: 13px; color: var(--muted); font-style: italic; margin: 6px 0 10px; }+/* request_tool fact strip — the product's own metadata (version, publisher, checksum),+ deliberately NOT italic so it can't be misread as the coworker still talking */+.toolreq-facts {+ display: flex; flex-wrap: wrap; align-items: baseline; gap: 4px 10px;+ font-size: 12.5px; color: var(--muted); font-style: normal;+ background: var(--paper); border: 1px solid var(--line); border-radius: 8px;+ padding: 7px 10px; margin: 2px 0 10px;+}+.toolreq-facts code { color: var(--ink); font-size: 12.5px; }+.toolreq-fact + .toolreq-fact::before,+.toolreq-facts code + .toolreq-fact::before { content: "· "; color: var(--muted); }+/* a disabled Install must LOOK disabled — the whole card exists to not oversell */+.dirreq-actions .btn:disabled { opacity: 0.45; cursor: not-allowed; }.dirreq-pathrow { display: flex; gap: 8px; align-items: center; }.dirreq-path {flex: 1; font: inherit; font-size: 13px; color: var(--ink);diff --git a/surfaces/gui/src/types.ts b/surfaces/gui/src/types.tsindex 5a974eaf..f2680538 100644--- a/surfaces/gui/src/types.ts+++ b/surfaces/gui/src/types.ts@@ -136,6 +136,7 @@ export type Item =installable?: boolean;version?: string;summary?: string;+ source?: string;resolved?: "installed" | "skipped";}| {diff --git a/tests/test_tool_request.py b/tests/test_tool_request.pyindex 8da512c5..de5624b1 100644--- a/tests/test_tool_request.py+++ b/tests/test_tool_request.py@@ -103,6 +103,7 @@ async def test_event_tells_the_truth_about_installability(tmp_path, monkeypatch)assert data["installable"] is Trueassert data["version"] == toolchain.MANAGED["gitleaks"].versionassert data["summary"]+ assert data["source"] == "github.com/gitleaks"events = await _run(_engine(tmp_path, requester, tool="not-a-managed-tool"))data = [e for e in events if e.type is EventType.TOOL_REQUESTED][0].datadiff --git a/tests/test_toolchain.py b/tests/test_toolchain.pyindex e12d98d7..8a1c4804 100644--- a/tests/test_toolchain.py+++ b/tests/test_toolchain.py@@ -87,6 +87,7 @@ def test_describe_surfaces_what_the_user_is_approving(monkeypatch):info = toolchain.describe("gitleaks")assert info and info["version"] and info["sha256"] and info["url"]assert "secret" in info["summary"].lower()+ assert info["source"] == "github.com/gitleaks" # publisher, human-readabledef test_install_refuses_a_tampered_download(tmp_path, monkeypatch):@@ -155,3 +156,7 @@ def test_install_writes_a_verified_binary(tmp_path, monkeypatch):monkeypatch.setenv("PATH", "")monkeypatch.setattr(toolchain, "_KNOWN_DIRS", ())assert toolchain.resolve("osv-scanner") == path+ # And linked under the stable bin dir, so a shell with that dir on PATH picks the+ # tool up by name the moment the install finishes — no respawn, no full paths.+ linked = toolchain.bin_dir() / "osv-scanner"+ assert linked.exists() and open(linked, "rb").read() == payload