Skip to content
Python

Fail closed when the approval owner is unavailable

Rohit C Prasad9beb20415916
diff --git a/coworker/server/manager.py b/coworker/server/manager.py
index 151c08af..f374925c 100644
--- a/coworker/server/manager.py
+++ b/coworker/server/manager.py
@@ -5477,6 +5477,8 @@ class SessionManager:
"""
member = self.teams.for_worker_session(session_id)
if member:
+ if self.session_store.load(member[0].lead_session) is None:
+ raise ValueError("The approval owner session is unavailable")
return self.get_engine(member[0].lead_session)._user_history()
return engine._user_history()
@@ -5495,6 +5497,8 @@ class SessionManager:
entry = self.personas.get(pid) if pid else None
return getattr(getattr(entry, "manifest", None), "approval_guidance", "")
owner = self.session_store.load(team.lead_session) if team else record
+ if team and owner is None:
+ raise ValueError("The approval owner session is unavailable")
actor = member[1].actor if member else (team.lead_actor if team else "")
assignments = self.team_store.list_items(
team.space, TeamActor(team.lead_actor, TeamRole.LEAD), assignee=actor,
diff --git a/tests/test_approval_guidance.py b/tests/test_approval_guidance.py
index e7551259..f9017e4e 100644
--- a/tests/test_approval_guidance.py
+++ b/tests/test_approval_guidance.py
@@ -88,3 +88,20 @@ def test_guidance_registry_roundtrip(tmp_path):
team = registry.create(space="acme", lead_session="lead", lead_actor="lead", workers=[
TeamWorker("sam", "swe-worker", "worker", approval_guidance="Tests only.\n No publishing.")])
assert TeamRegistry(path).get(team.team_id).workers[0].approval_guidance == "Tests only.\n No publishing."
+
+
+def test_missing_owner_does_not_create_a_replacement_session(manager, monkeypatch):
+ lead, _ = lead_for_review(manager, monkeypatch)
+ worker = manager.get_engine("worker", agent="swe-worker")
+ original = manager.session_store.load
+ monkeypatch.setattr(manager.session_store, "load", lambda sid: None if sid == "lead" else original(sid))
+ assert worker._review_inputs() == ("", [], {"context_unavailable": True})
+
+
+def test_direct_worker_restrictions_are_not_lost_in_delegated_review(manager, monkeypatch):
+ lead_for_review(manager, monkeypatch)
+ worker = manager.get_engine("worker", agent="swe-worker")
+ worker.messages.append({"role": "user", "content": "Do not run the database tests."})
+ _, request = request_for(manager)
+ context = manager.worker_review_context("lead", request.arguments)["context"]["approval_guidance_context"]
+ assert context["worker_session_unsourced_input"]["request"] == "Do not run the database tests."