Python
Responses stream: rebuild the turn when the terminal event's output is empty
Devika Vermaa217511d50d5
diff --git a/coworker/providers/openai_responses.py b/coworker/providers/openai_responses.pyindex 9d34f84a..d182a035 100644--- a/coworker/providers/openai_responses.py+++ b/coworker/providers/openai_responses.py@@ -396,6 +396,7 @@ class OpenAIResponsesProvider(ProviderClient):text_parts: list[str] = []reasoning_parts: list[str] = []+ done_items: list[Any] = []final: Optional[Any] = Nonefor event in events:kind = getattr(event, "type", None)@@ -409,13 +410,29 @@ class OpenAIResponsesProvider(ProviderClient):if delta:reasoning_parts.append(delta)yield StreamChunk(reasoning_delta=delta)+ elif kind == "response.output_item.done":+ item = getattr(event, "item", None)+ if item is not None:+ done_items.append(item)elif kind in ("response.completed", "response.incomplete", "response.failed"):final = getattr(event, "response", None)if final is not None:# The terminal event carries the full response — parse it whole so tool# calls, finish reason, and the `_openai` sidecar come from one place.- yield StreamChunk(turn=_parse_response(final))+ # Some Responses-compatible backends (the subscription backend) leave the+ # terminal response's `output` EMPTY — the items only ever stream — so+ # graft the streamed output_item.done items back on before parsing, or a+ # turn's text and tool calls silently vanish.+ if not (getattr(final, "output", None) or []) and done_items:+ try:+ final.output = done_items+ except Exception:+ pass+ turn = _parse_response(final)+ if turn.text is None and not turn.tool_calls and text_parts:+ turn.text = "".join(text_parts)+ yield StreamChunk(turn=turn)else:yield StreamChunk(turn=AssistantTurn(diff --git a/tests/test_openai_responses.py b/tests/test_openai_responses.pyindex 64edfc90..21df9861 100644--- a/tests/test_openai_responses.py+++ b/tests/test_openai_responses.py@@ -544,6 +544,42 @@ def test_stream_final_turn_carries_tool_calls_and_sidecar():]+def test_stream_rebuilds_turn_when_terminal_output_is_empty():+ """The subscription backend leaves `output` EMPTY on response.completed — items only+ ever stream. The turn must be rebuilt from the output_item.done events, or text and+ tool calls silently vanish (live bug: a turn produced deltas, then persisted empty)."""+ events = [+ SimpleNamespace(type="response.output_text.delta", delta="pong"),+ SimpleNamespace(+ type="response.output_item.done", item=_message_item("pong")+ ),+ SimpleNamespace(+ type="response.output_item.done", item=_call_item("call_1", "f", '{"x": 1}')+ ),+ SimpleNamespace(type="response.completed", response=_response([])),+ ]+ provider = OpenAIResponsesProvider(client=_FakeClient(events=events))+ turn = list(+ provider.stream(model="m", messages=[{"role": "user", "content": "x"}])+ )[-1].turn+ assert turn.text == "pong"+ assert turn.finish_reason == "tool_calls"+ assert turn.tool_calls[0].arguments == {"x": 1}+++def test_stream_falls_back_to_deltas_when_no_items_repeat_anywhere():+ events = [+ SimpleNamespace(type="response.output_text.delta", delta="po"),+ SimpleNamespace(type="response.output_text.delta", delta="ng"),+ SimpleNamespace(type="response.completed", response=_response([])),+ ]+ provider = OpenAIResponsesProvider(client=_FakeClient(events=events))+ turn = list(+ provider.stream(model="m", messages=[{"role": "user", "content": "x"}])+ )[-1].turn+ assert turn.text == "pong" and turn.finish_reason == "stop"++def test_stream_without_terminal_event_keeps_accumulated_text():events = [SimpleNamespace(type="response.output_text.delta", delta="partial")]provider = OpenAIResponsesProvider(client=_FakeClient(events=events))